github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-17 18:11:29 -05:00
Code Issues Packages Projects Releases Wiki Activity
25,885 Commits 140 Branches 571 Tags
54ce7495785f7106cb691321e80e37ed74b2192e
Commit Graph

58 Commits

Author SHA1 Message Date
Nathan Sobo
54ce749578 Remove unused local 2015-10-13 19:38:02 -06:00
Nathan Sobo
99b06e149b Remove AtomEnvironment::requireWithGlobals 2015-10-13 19:37:26 -06:00
Nathan Sobo
65ae175e72 Pass explicit window global into AtomEnvironment on construction 2015-10-13 19:35:51 -06:00
Nathan Sobo
c8407167ee Pass specific parameters to registerDefaultCommands 2015-10-13 19:20:06 -06:00
Nathan Sobo
f9a269ed99 Prompt about checking out head revision in TextEditor, not GitRepository 
This allows us not to inject confirm or ApplicationDelegate into
Project, GitRepositoryProvider, and GitRepository.
 2015-10-13 19:11:55 -06:00
Nathan Sobo
306ddf5491 Use ApplicationDelegate in CommandInstaller instead of bound confirm 2015-10-13 19:10:56 -06:00
Nathan Sobo
84aa8471b4 Pass AppDelegate to Workspace, Pane instead of bound functions 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
 2015-10-13 18:54:48 -06:00
Nathan Sobo
20e07649d4 Move confirm into ApplicationDelegate 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
 2015-10-13 18:09:35 -06:00
Nathan Sobo
cc0bf23f78 Add setRepresentedDirectoryPaths to ApplicationDelegate 
Also, use it to provide the default path in showSaveDialog
 2015-10-13 17:57:48 -06:00
Nathan Sobo
432a59b8e5 Move tests from window-event-handler-spec for moved functionality 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
 2015-10-13 17:53:01 -06:00
Nathan Sobo
f989ed65e1 Move ipc handling from WindowEventHandler to ApplicationDelegate 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
 2015-10-13 16:57:02 -06:00
Nathan Sobo
83a0cf28cd 🎨 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
 2015-10-13 15:47:45 -06:00
Nathan Sobo
e92cb86335 Introduce ApplicationDelegate to AtomEnvironment 
All external actions are performed via this delegate for test-isolation
purposes.
 2015-10-13 15:42:57 -06:00
Nathan Sobo
a8ca3165a0 Remove dead code 2015-10-13 14:46:28 -06:00
Antonio Scandurra
6459891c89 💚 Make sure to destroy AtomEnvironment in specs 2015-10-13 15:30:45 +02:00
Antonio Scandurra
e51bad5618 🐛 Install WindowEventHandler in ctor 2015-10-13 12:38:45 +02:00
Antonio Scandurra
3ac0656a26 Reset Workspace before Project 
Otherwise some paths will be leaked.
 2015-10-13 11:29:51 +02:00
Nathan Sobo
f7a3e6c425 Don’t load base style sheets until config is loaded 
We need to know what themes are active in order to load the correct LESS
variables.
 2015-10-12 16:12:46 -06:00
Nathan Sobo
69e8b0cfb1 Prevent title change during specs 2015-10-12 15:19:55 -06:00
Antonio Scandurra
3ee0be33d5 🐎 Speed up test suite by disposing Project::emitter 2015-10-12 19:46:12 +02:00
Antonio Scandurra
56e13bba69 Reset Workspace in AtomEnvironment 2015-10-12 15:01:00 +02:00
Antonio Scandurra
612664fd4d 📝 Remember how/when to reset AtomEnviroment::workspace 2015-10-12 09:00:58 +02:00
Antonio Scandurra
aebc1229f1 Always install uncaught error handler 2015-10-12 08:29:43 +02:00
Antonio Scandurra
e1a1474b8d 🐛 Clear views after resetting everything else 
This prevents a bug where calling `::getView` returns two different instances if
such method is invoked after views are cleared out (e.g. packages deactivation
in `packageManager.reset()`).
 2015-10-11 19:27:19 +02:00
Max Brunsfeld
74c0836be5 🔥 Duplicate devMode/inDevMode parameter to Package, PackageManager 2015-10-09 17:34:22 -07:00
Max Brunsfeld
75463829f9 Pass inDevMode to package-manager as a boolean value 
Rather than as a bound function
 2015-10-09 17:26:19 -07:00
Max Brunsfeld
369f3d2648 Don't use atom.{notifications,config,deserializers,confirm} in Pane 
Still need to get rid of one use of showSaveDialogSync
 2015-10-09 17:18:26 -07:00
Max Brunsfeld
778023c78b Make factory for StylesElements on atom.styles 2015-10-09 13:46:32 -07:00
Antonio Scandurra
1a8beef74f 🐛 Load config schema before loading base stylesheets 2015-10-09 19:10:55 +02:00
Antonio Scandurra
4ce814320d Call side effects methods after instantiating instance variables 
This prevents a 🐛 where the `onDidLoadBundledKeymaps` was fired before
`MenuManager` had the chance to listen to it thereby not showing the appropriate
menu entries.
 2015-10-09 17:41:33 +02:00
Antonio Scandurra
60e4b78da3 Move package reset down into PackageManager 2015-10-09 10:04:04 +02:00
Max Brunsfeld
43d0241685 Reset project in AtomEnvironment::reset 2015-10-08 17:54:43 -07:00
Max Brunsfeld
7617c35856 Rename AtomEnvironment::removeEditorWindow -> ::destroy 2015-10-08 17:51:27 -07:00
Max Brunsfeld
5c545c0898 Don't register CommandRegistry's window listeners in AtomEnvironment constructor 2015-10-08 17:34:41 -07:00
Max Brunsfeld
4835fef7be Reset service-hub in AtomEnvironment::reset() 2015-10-08 16:29:54 -07:00
Max Brunsfeld
fb2a1284f6 Clear notifications and context menus in AtomEnvironment::reset 2015-10-08 12:41:07 -07:00
Max Brunsfeld
d0283d8f05 Reset Clipboard in AtomEnvironment::reset 2015-10-08 11:56:12 -07:00
Max Brunsfeld
9664d34750 Reset MenuManager in AtomEnvironment::reset 2015-10-08 11:56:12 -07:00
Antonio Scandurra
fa41cf68a4 🐛 Fix ::registerDefaultOpeners 2015-10-08 15:49:01 +02:00
Nathan Sobo
aa682d5b19 Restore initial styles in AtomEnvironment::reset 2015-10-07 15:25:06 -05:00
Antonio Scandurra
a3a6db7f68 Don't use atom.{config,confirm} global in GitRepository 2015-10-07 15:25:05 -05:00
Antonio Scandurra
4108939201 Don't use atom.{themes,menu,contextMenu} global in Package 2015-10-07 15:25:05 -05:00
Antonio Scandurra
7b25af5ad4 Remove more globals from Package 
🔥 atom.{notifications,keymaps,commands,grammars,inDevMode}
 2015-10-07 15:25:05 -05:00
Antonio Scandurra
c192004b06 Don't use atom.{config,styles} global in Package 2015-10-07 15:25:05 -05:00
Nathan Sobo
b7d6dd5e8c Reset view registry in AtomEnvironment::reset 2015-10-07 15:25:02 -05:00
Antonio Scandurra
464cfd4474 Don't use atom.confirm in Workspace 2015-10-07 15:25:02 -05:00
Antonio Scandurra
04fcc1112e Fix some linter errors 2015-10-07 15:25:02 -05:00
Antonio Scandurra
2532a9cd59 Don't use atom globals in StylesElement 2015-10-07 15:25:02 -05:00
Antonio Scandurra
fa06124bb2 Don't use atom globals in PaneElement 2015-10-07 15:25:01 -05:00
Antonio Scandurra
721c5a1679 Don't use atom globals in PaneAxisElement 2015-10-07 15:25:01 -05:00