github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-25 06:48:28 -05:00
Code Issues Packages Projects Releases Wiki Activity
32,599 Commits 140 Branches 571 Tags
577dfe8deb54d47f0ff866647c238a79e5e34e62
Commit Graph

32599 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jason Rudolph
577dfe8deb Merge pull request #15154 from atom/jr-fix-15122 
Fix flaky test re: blinking cursor
 2017-08-03 20:19:07 -04:00
Jason Rudolph
15a055b6cd Revert some of the changes from 29810c6cd1 
xref: https://github.com/atom/atom/pull/15154#discussion_r131270263
 2017-08-03 17:57:13 -04:00
Nathan Sobo
f8f3252962 Merge pull request #15148 from atom/ns-disable-electron-logging-by-default 
Don't enable electron logging by default
 2017-08-03 13:27:43 -06:00
Nathan Sobo
18c5a31fbc Unset ELECTRON_ENABLE_LOGGING on Windows unless explicitly requested 2017-08-03 11:53:36 -06:00
Jason Rudolph
29810c6cd1 Attempt to fix flaky test re: blinking cursor 
As shown in #15122, this test sometimes fails in CI with the following
error:

  TextEditorComponent
    rendering
      it blinks cursors when the editor is focused and the cursors are not moving
        Expected '0' to be '1'.
          at it (C:\projects\atom\spec\text-editor-component-spec.js:414:49)
        Expected '0' to be '1'.
          at it (C:\projects\atom\spec\text-editor-component-spec.js:415:49)

I *think* this might be a case of overspecification in the test's
assertions. Prior to this commit, the test expected the blinking cursor
to *start* in the visible state, and then transition to the invisible
state. When we see the failure above, I suspect that the cursor has
already transitioned from the visible state to the invisible state by
the time the assertion runs.

Since the test aims to verify that the cursor blinks, it seems like we
should focus on the blinking, and not worry about the *initial* state of
the cursor. This commit removes the assertions that verify the initial
state of the cursor, and instead asserts that the cursor toggles between
the visible and the invisible state.
 2017-08-03 12:25:01 -04:00
Jason Rudolph
7d6bd2a6b1 Merge pull request #15147 from atom/ns-jr-fix-gutter-decoration-dimensions 
Ensure custom gutter decoration elements fill their container
 2017-08-03 10:11:04 -04:00
Ash Wilson
fc53b21857 Merge pull request #15124 from smashwilson/aw-spec-reporters 
Use spec reporters in CI
 2017-08-03 06:54:54 -04:00
Nathan Sobo
55748bd2c4 Document enable-electron-logging option 2017-08-02 21:12:02 -06:00
Nathan Sobo
b5bdf4acb9 Don't enable electron logging by default 2017-08-02 21:03:29 -06:00
Nathan Sobo
1584189962 Ensure custom decoration elements fill their container 2017-08-02 20:34:18 -06:00
Ash Wilson
e5139874d0 🔥 dumping the test environment 2017-08-02 20:08:20 -04:00
Ash Wilson
e90441303d 🔥 console.logs 2017-08-02 19:34:44 -04:00
Jason Rudolph
03b631a1da Merge pull request #15145 from atom/jr-tree-view-0-217-6 
⬆️ Upgrade tree-view to 0.217.6 to fix intermittent CI failures
 2017-08-02 18:30:44 -04:00
Wliu
977b337b4c ⬆️ language-php@0.41.0 2017-08-02 16:45:46 -04:00
Ash Wilson
219eabfa50 Use jasmine-reporters 1.x 2017-08-02 16:29:36 -04:00
Jason Rudolph
88c4d383fb ⬆️ Upgrade tree-view to 0.217.6 2017-08-02 15:36:02 -04:00
Wliu
03742f6343 Merge pull request #15138 from alanyee/patch-1 
Update README.md
 2017-08-02 12:57:48 -04:00
Alan Yee
9b6eff2d81 Update README.md 
Removing Homebrew install instructions
 2017-08-02 09:36:22 -07:00
Alan Yee
d57346f23a Update README.md 
Fix grammar error
 2017-08-02 08:35:15 -07:00
Ash Wilson
7244fb9670 Format script/test with standard 2017-08-02 08:18:25 -04:00
simurai
ad7e206a78 ⬆️ one-dark/light-ui@v1.10.6 2017-08-02 12:39:46 +09:00
Michelle Tilley
008ea39650 Merge pull request #15137 from atom/mkt-updoot-github-from-0-3-8 
⬆ github@0.3.9-0
 2017-08-01 10:40:21 -07:00
Jason Rudolph
ea5e6d51f8 Merge pull request #15135 from atom/js-ns-fix-gutter-layout 
Fix gutter decoration regression in v1.19 beta
 2017-08-01 13:39:52 -04:00
Max Brunsfeld
967c2a3440 Merge pull request #15121 from atom/mb-fix-spurious-text-buffer-conflict-events 
Upgrade text-buffer to fix spurious conflict and reload events
 2017-08-01 09:55:27 -07:00
Max Brunsfeld
7295e5de6f ⬆️ text-buffer 2017-08-01 09:53:03 -07:00
Alan Yee
e0b6ff6ebb Update README.md 
-Added Homebrew install instructions for macOS
-Made explicit HTTPS calls
-Minor url cleanup
 2017-08-01 09:47:20 -07:00
Michelle Tilley
cc753be2ca ⬆️ github@0.3.9-0 2017-08-01 09:20:52 -07:00
Ash Wilson
9ab9643b11 Use full paths for JUnit XML files 2017-08-01 11:27:16 -04:00
Ash Wilson
2ff3e654e0 Move test result uploading to on_finish on AppVeyor 2017-08-01 11:27:16 -04:00
Ash Wilson
41cb5ce076 Configure Mocha to use the JUnit XML reporter 2017-08-01 11:27:16 -04:00
Ash Wilson
8ea491f223 Use mocha Multi and JUnit reporters 2017-08-01 11:27:16 -04:00
Ash Wilson
adec6fe981 Dump the environment before running core main process tests 2017-08-01 11:27:16 -04:00
Ash Wilson
76af36939a Extra ) 2017-08-01 11:27:15 -04:00
Ash Wilson
5eef79c904 Quoting shenanigans maybe? 2017-08-01 11:27:15 -04:00
Ash Wilson
2574ca5736 More diagnostics 2017-08-01 11:27:15 -04:00
Ash Wilson
ca4f372c88 Let's dump that directory maybe? 2017-08-01 11:27:15 -04:00
Ash Wilson
db2b196404 Diagnostics for AppVeyor 2017-08-01 11:27:15 -04:00
Ash Wilson
0a0e5e9cea Still trying to get that Get-ChildItem call right 2017-08-01 11:27:15 -04:00
Ash Wilson
3690b682c8 Better filtering 2017-08-01 11:27:15 -04:00
Ash Wilson
e53cb5e5ef Powershell by means of StackOverflow 2017-08-01 11:27:15 -04:00
Ash Wilson
6813e4e945 These are JUnit results, not XUnit 2017-08-01 11:27:15 -04:00
Ash Wilson
fa89d53c8c Default to passing process.env to all suites in script/test 2017-08-01 11:27:15 -04:00
Ash Wilson
29005fad25 Set TEST_JUNIT_XML_ROOT on AppVeyor 2017-08-01 11:27:15 -04:00
Ash Wilson
830038f1ac Use TEST_JUNIT_XML_ROOT instead of the CircleCI-specific root 2017-08-01 11:27:15 -04:00
Ash Wilson
3e581d4936 Set TEST_JUNIT_XML_PATH and upload results on AppVeyor 2017-08-01 11:27:14 -04:00
Ash Wilson
37842fd2d4 Populate TEST_JUNIT_XML_PATH on CircleCI 2017-08-01 11:27:14 -04:00
Ash Wilson
a7105980a3 If TEST_JUNIT_XML_PATH is set, output JUnit XML format test results 2017-08-01 11:27:14 -04:00
Ash Wilson
81913776e8 Add the 1.x compatibility branch of jasmine-reporters 2017-08-01 11:27:14 -04:00
Max Brunsfeld
dbfc792df0 ⬆️ text-buffer (prerelease) 2017-07-31 16:28:37 -07:00
Max Brunsfeld
fe52743b82 ⬆️ text-buffer (prerelease) 2017-07-31 15:24:13 -07:00