Antonio Scandurra
5da32540b1
🎨
2015-10-08 11:54:11 +02:00
Antonio Scandurra
1d280e8d92
Introduce timeout option
...
The idea with this commit is to implement a timeout functionality that does not
rely on a system utility (such as unix `timeout`). Tests could hang because of a
CPU-bound task and, as a result, we need to handle timeouts in a separate
process.
An ideal implementation would first spawn the timeout, which in turn would spawn
the tests, acting as a supervisor and making sure they do not exceed the
supplied time. However, setting up such an environment would have been trickier,
thus the test process spawns the timeout cop before running any test. This, in
turn, invokes a `setTimeout` function and kills the parent process as soon as
the timeout gets triggered, logging to console the reason why the parent process
was killed (and exiting the parent process with code 130).
I haven't used `Task` because, in order to log stuff to the console, we need to
fork the ChildProcess from `remote`, as otherwise nothing gets written out.
2015-10-08 11:38:48 +02:00
Nathan Sobo
4746153cc5
Merge branch 'master' into ns-alternative-test-env
2015-10-07 16:53:39 -05:00
Nathan Sobo
8e834794a9
Remove scroll listener on destroy so we don’t call undefined onScroll
...
/cc @izuzak because no PR, @as-cii because this fixes an unexpected
issue with your change.
2015-10-07 16:52:37 -05:00
Nathan Sobo
4808c9f9e8
Eliminate config and confirm global references in Pane
2015-10-07 16:32:47 -05:00
Nathan Sobo
4c51d29868
Merge remote-tracking branch 'origin/master' into ns-alternative-test-env
2015-10-07 16:10:29 -05:00
Nathan Sobo
3636eb35d8
Merge pull request #8811 from atom/as-double-reflow-measurements
...
DOM-based measurements
2015-10-07 15:43:59 -05:00
Nathan Sobo
993419f0c5
Merge pull request #9067 from atom/as-memory-leaks
...
Avoid leaking DOM objects
2015-10-07 15:32:17 -05:00
Nathan Sobo
ca0dda77b6
Don’t bind window:close in spec helper
2015-10-07 15:25:07 -05:00
Nathan Sobo
0f4558c448
Don’t load key bindings in spec helper
2015-10-07 15:25:06 -05:00
Nathan Sobo
499272dfa1
Remove unused locals in spec-helper
2015-10-07 15:25:06 -05:00
Nathan Sobo
a9a6f38858
Don’t clear document requests in spec helper; happens in reset
2015-10-07 15:25:06 -05:00
Nathan Sobo
aa682d5b19
Restore initial styles in AtomEnvironment::reset
2015-10-07 15:25:06 -05:00
Nathan Sobo
dc7a4a8168
Increase wait time in spec
...
This kinda sucks, but it’s not the end of the world.
2015-10-07 15:25:06 -05:00
Antonio Scandurra
c3d85f85a4
🔥 Remove unused LOC
2015-10-07 15:25:06 -05:00
Antonio Scandurra
52c43a71d3
Pass legacyTestRunner parameter
2015-10-07 15:25:06 -05:00
Max Brunsfeld
13301b551c
📝 Document Workspace::buildTextEditor
2015-10-07 15:25:06 -05:00
Thomas Johansen
d878092794
🎨 Replace unnecessary fat arrow
2015-10-07 15:25:06 -05:00
Thomas Johansen
669eff5d20
🔥 Remove duplicate keys
2015-10-07 15:25:06 -05:00
Thomas Johansen
a28a42b610
🔥 Remove duplicate key
2015-10-07 15:25:05 -05:00
Max Brunsfeld
5aee514ef5
🔥 debuggers
2015-10-07 15:25:05 -05:00
Max Brunsfeld
4988f6be11
Remove application:run-all-specs command
2015-10-07 15:25:05 -05:00
Max Brunsfeld
9924288a6f
Use atom environment argument to deserialize in Pane, PaneAxis
2015-10-07 15:25:05 -05:00
Antonio Scandurra
a3a6db7f68
Don't use atom.{config,confirm} global in GitRepository
2015-10-07 15:25:05 -05:00
Antonio Scandurra
ff86eb6a59
Don't use atom.config global in ScopedProperties
2015-10-07 15:25:05 -05:00
Antonio Scandurra
b5fc710f15
Don't use atom.clipboard global in Selection
2015-10-07 15:25:05 -05:00
Antonio Scandurra
b2d178f641
💚 Avoid resetting atom.grammars
...
...because it messes up subsequent tests that hit code paths that make use of
atom.grammars.
/cc: @nathansobo @maxbrunsfeld
2015-10-07 15:25:05 -05:00
Antonio Scandurra
4108939201
Don't use atom.{themes,menu,contextMenu} global in Package
2015-10-07 15:25:05 -05:00
Antonio Scandurra
7b25af5ad4
Remove more globals from Package
...
🔥 atom.{notifications,keymaps,commands,grammars,inDevMode}
2015-10-07 15:25:05 -05:00
Antonio Scandurra
c192004b06
Don't use atom.{config,styles} global in Package
2015-10-07 15:25:05 -05:00
Nathan Sobo
b7d6dd5e8c
Reset view registry in AtomEnvironment::reset
2015-10-07 15:25:02 -05:00
Antonio Scandurra
097a035dc4
Don't use atom globals in OverlayManager
2015-10-07 15:25:02 -05:00
Antonio Scandurra
534f038631
Don't use atom globals in TokenIterator
2015-10-07 15:25:02 -05:00
Antonio Scandurra
464cfd4474
Don't use atom.confirm in Workspace
2015-10-07 15:25:02 -05:00
Antonio Scandurra
cb950b65b0
💚 Adapt specs to pass atom.views in ctors
2015-10-07 15:25:02 -05:00
Antonio Scandurra
df2d73a8df
Don't use atom globals in TokenizedBuffer
2015-10-07 15:25:02 -05:00
Antonio Scandurra
04fcc1112e
Fix some linter errors
2015-10-07 15:25:02 -05:00
Antonio Scandurra
eba18092fb
Don't use atom globals in LinesComponent
2015-10-07 15:25:02 -05:00
Antonio Scandurra
6fed847cce
Don't use atom globals in gutter components
2015-10-07 15:25:02 -05:00
Antonio Scandurra
45f536a5ee
Remove leftover global in WorkspaceElement
2015-10-07 15:25:02 -05:00
Antonio Scandurra
2532a9cd59
Don't use atom globals in StylesElement
2015-10-07 15:25:02 -05:00
Antonio Scandurra
8686b2009e
Port leftover global in PanelContainerElement
2015-10-07 15:25:01 -05:00
Antonio Scandurra
fa06124bb2
Don't use atom globals in PaneElement
2015-10-07 15:25:01 -05:00
Antonio Scandurra
721c5a1679
Don't use atom globals in PaneAxisElement
2015-10-07 15:25:01 -05:00
Antonio Scandurra
6e915c0afd
Don't use atom globals in PaneContainerElement
2015-10-07 15:25:01 -05:00
Antonio Scandurra
b65bfc408e
Don't use atom globals in PanelContainerElement
2015-10-07 15:25:01 -05:00
Antonio Scandurra
112ee01bd9
Don't use atom globals in TextEditorElement
...
...except when the element is instantiated via HTML
2015-10-07 15:25:01 -05:00
Nathan Sobo
e1c9f3332d
Reset commands in AtomEnvironment::reset
2015-10-07 15:25:01 -05:00
Nathan Sobo
ad8c0e93d4
Reset deserializers in AtomEnvironment::reset
2015-10-07 15:25:01 -05:00
Nathan Sobo
75fbeab8b4
🎨
2015-10-07 15:25:01 -05:00
