Commit Graph

33451 Commits

Author SHA1 Message Date
Michelle Tilley
662a397860 👕 2017-10-19 16:19:44 -07:00
Michelle Tilley
8111ba6c1e Allow core URI handlers to determine which window to trigger the URI on 2017-10-19 15:50:24 -07:00
Michelle Tilley
e1bc9b593b Run URI handlers in last non-spec window 2017-10-19 14:37:08 -07:00
Michelle Tilley
9c6a87199e Merge branch 'mkt-core-uri-handlers' of github.com:atom/atom into mkt-core-uri-handlers 2017-10-19 14:19:32 -07:00
Michelle Tilley
158622ce48 Convert array of windows in AtomApplication to a WindowStack 2017-10-19 14:19:24 -07:00
Michelle Tilley
2901a484c2 👕 2017-10-18 17:34:24 -07:00
Michelle Tilley
a11efa7376 Add core URI handlers 2017-10-18 16:00:37 -07:00
Michelle Tilley
85c9f2291d ⬆️ settings-view@0.252.0 2017-10-18 15:16:11 -07:00
Antonio Scandurra
280253fdfa Merge pull request #15916 from atom/as-jr-stop-dragging-when-interacting-with-keyboard
Stop dragging only when user interacts with keyboard
2017-10-18 11:38:52 +02:00
Michelle Tilley
d6a3a60469 Merge pull request #11399 from atom/mkt-url-based-command-dispatch
Package URL handlers - mapping atom:// URIs to package functions
2017-10-17 16:29:27 -07:00
Michelle Tilley
5bbf0b6ade 🎨 package activation 2017-10-17 15:37:49 -07:00
Michelle Tilley
8b989ffc4e More url -> URI 2017-10-17 15:29:27 -07:00
Michelle Tilley
9b5f95a14d openWithAtomUrl -> openPackageUriHandler 2017-10-17 15:26:29 -07:00
Michelle Tilley
5e43084cd3 url -> URI 2017-10-17 15:23:10 -07:00
Michelle Tilley
e02337265a Reset history when destroying UrlHandlerRegistry 2017-10-17 14:42:11 -07:00
Michelle Tilley
2504118d8b ⌨️ fix typo 2017-10-17 14:42:00 -07:00
Michelle Tilley
2b70f57405 🎨 return undefined 2017-10-17 14:41:50 -07:00
Michelle Tilley
7aa79bc3a1 Unregister package URL handlers when deactivating 2017-10-17 12:59:21 -07:00
Wliu
641898ed2a ⬆️ tree-view@0.219.0 2017-10-17 21:55:02 +02:00
Michelle Tilley
e3b00f8dde Merge pull request #15918 from FalkF/fix-redundant-text
textChange(CoreSettings): remove redundancy
2017-10-17 11:32:04 -07:00
anon
894f5471e6 textChange(CoreSettings): remove redundancy 2017-10-18 22:09:11 +02:00
Michelle Tilley
5e96429c9e Merge remote-tracking branch 'origin/master' into mkt-url-based-command-dispatch 2017-10-17 11:18:02 -07:00
Antonio Scandurra
65af9e953b Stop dragging only when user interacts with keyboard
Previously, we used to prevent the user from dragging the selection
further when the buffer was about to change. This was problematic
because any change in the buffer, even one that was performed
"automatically" by a package, would cancel the dragging action and
result in a confusing experience for the user.

On the other hand, we want to prevent users from accidentally selecting
text when they perform an edit (see #15217, #15405).

This commit addresses both concerns by canceling the dragging as soon as
the user interacts with the keyboard, instead of canceling the dragging
when the buffer is about to change.

One downside of this approach is that it changes the behavior of
pressing a keystroke that does not result in a buffer change, e.g.
Shift, Arrow Keys, etc.

Signed-off-by: Jason Rudolph <jasonrudolph@github.com>
2017-10-17 18:50:20 +02:00
Jason Rudolph
274b809b12 Merge pull request #15898 from atom/decaf-project
Decaffeinate `src/project.coffee`
2017-10-16 21:23:14 -04:00
Katrina Uychaco
de66cf218a ⬆️ github@0.7.0 2017-10-16 17:53:45 -07:00
leroix
83cb0b9a14 Merge pull request #15894 from leroix/jr-overlay-resize-bug
Fix overlay resizing infinite loop
2017-10-16 13:31:51 -06:00
Lee Dohm
2f02a095d2 Merge pull request #15906 from atom/b3-move-docs-to-flight-manual
Link to the flight-manual instead of duplicating documentation
2017-10-16 12:15:15 -07:00
Linus Eriksson
9b61114c0f Update contributing-to-packages.md 2017-10-16 21:05:41 +02:00
Linus Eriksson
be61d6d6b9 Merge pull request #15904 from laurmurclar/patch-1
Link to more accurate local dev instructions
2017-10-16 21:03:17 +02:00
Laura Murphy-Clarkin
2ae8b5d46c Link to more accurate local dev instructions
The Flight Manual contains more accurate instructions for local development on official Atom packages. I was caught out by this (as you can see in https://github.com/atom/bracket-matcher/issues/306) so I'm changing it for future contributors. 😊 I think it's better to just link to the Flight Manual rather than maintaining the instructions in two places.
2017-10-16 19:27:06 +01:00
Jason Rudolph
a4ea46c57e Rename local variable
/xref: https://github.com/atom/atom/pull/15898#discussion_r144850427
2017-10-16 11:04:56 -04:00
Jason Rudolph
5ec9d0f134 🐛 Fix bug disposing watchers in Project::addPath
`this.rootDirectories` is an Array of Directory objects. `path` is a
String. Therefore, `this.rootDirectories.includes(path)` will always
evaluate to `false`. We instead need to look for an entry in
`this.rootDirectories` where the Directory object's path is equal to the
given path.
2017-10-15 10:00:14 -04:00
Jason Rudolph
5937b95b49 Fix loop contructs that got borked by decaffeinate 2017-10-15 10:00:02 -04:00
Jason Rudolph
790e202549 🎨 2017-10-15 10:00:02 -04:00
Jason Rudolph
8df4cfbe58 🎨 2017-10-15 10:00:02 -04:00
Jason Rudolph
48625584e4 🎨 Use shorter variations of null checks 2017-10-15 10:00:02 -04:00
Jason Rudolph
b2571e8976 Avoid inline assignments 2017-10-15 10:00:02 -04:00
Jason Rudolph
99aaafed1b DS103: Rewrite code to no longer use __guard__ 2017-10-15 10:00:02 -04:00
Jason Rudolph
94a552149d Remove unnecessary use of Array.from 2017-10-15 10:00:01 -04:00
Jason Rudolph
c1b0afe969 Remove unnecessary code created because of implicit returns 2017-10-15 10:00:01 -04:00
Justin Ratner
0c35c26805 fix infinite overlay resizing loop 2017-10-14 19:05:54 -06:00
Jason Rudolph
8f40af16a9 🎨 2017-10-14 17:07:09 -04:00
Jason Rudolph
dd6359b507 Remove Babel/TypeScript constructor workaround 2017-10-14 12:47:19 -04:00
Jason Rudolph
cab8824aae 👔 Fix linter violations 2017-10-14 12:47:00 -04:00
Jason Rudolph
25b7ddb328 ☠️ Decaffeinate src/project.coffee
Apply results of running:

```
$ decaffeinate --keep-commonjs --prefer-const --loose-default-params --loose-for-expressions --loose-for-of --loose-includes'

$ standard --fix src/project.js
```
2017-10-14 11:58:47 -04:00
Justin Ratner
8952cd315d ⬆️ text-buffer@13.5.7 2017-10-13 13:21:10 -06:00
leroix
6f1595c766 Merge pull request #15882 from leroix/jr-decaf-decoration
decaffeinate decoration.coffee
2017-10-13 09:37:54 -06:00
Justin Ratner
ae65b49b9b fix lint errors 2017-10-12 23:46:53 -06:00
Justin Ratner
763297df82 decaffeinate decoration.coffee 2017-10-12 21:26:52 -06:00
Ian Olsen
1fe2548ab9 ⬆️ electron@1.6.15 2017-10-11 13:21:10 -07:00