Antonio Scandurra
6fed847cce
Don't use atom globals in gutter components
2015-10-07 15:25:02 -05:00
Antonio Scandurra
112ee01bd9
Don't use atom globals in TextEditorElement
...
...except when the element is instantiated via HTML
2015-10-07 15:25:01 -05:00
Antonio Scandurra
f17767a2bc
Merge pull request #8905 from atom/as-display-buffer-logical-coordinates
...
Use logical coordinates in DisplayBuffer
2015-09-26 18:05:10 +02:00
Antonio Scandurra
051baebd9c
Shim ::setHeight and ::getHeight to TextEditorElement
2015-09-25 11:15:41 +02:00
Antonio Scandurra
33a67ad3c9
Shim ::setWidth and ::getWidth to TextEditorElement
2015-09-25 11:05:41 +02:00
Antonio Scandurra
b0d70a63c6
Prevent default event for actions that won't lead to scrolling
2015-09-25 10:55:03 +02:00
Antonio Scandurra
d65b5d1793
Revert "Maintain scroll history"
...
This reverts commit 2e6bb53303
2015-09-25 10:31:48 +02:00
Antonio Scandurra
2e6bb53303
Maintain scroll history
2015-09-24 16:25:58 +02:00
Antonio Scandurra
270334b713
Adjust pixelRectForScreenRange to return absolute values
2015-09-24 11:30:46 +02:00
Antonio Scandurra
19ca87f79f
💚 Fix specs
2015-09-24 11:27:54 +02:00
Antonio Scandurra
535a9da946
wip
2015-09-24 11:21:26 +02:00
Antonio Scandurra
a137e50857
Merge pull request #8895 from atom/as-undefined-offset-height
...
Allow null TextEditorComponent::domNode during visibility check
2015-09-24 10:33:44 +02:00
Antonio Scandurra
3236c8f0f8
Let's start with deprecations!
2015-09-24 10:07:38 +02:00
Antonio Scandurra
c76525fc63
Restore scroll position after we have pixel position requirements
2015-09-24 10:01:11 +02:00
Antonio Scandurra
6673c892d5
Remove references to TextEditor::scroll...
2015-09-24 09:15:10 +02:00
Antonio Scandurra
1f81c633e0
Serialize state using logical coordinates
2015-09-24 09:01:51 +02:00
Antonio Scandurra
4ffeb68403
Ensure domNode is not set arbitrarily to null
2015-09-23 19:01:57 +02:00
Antonio Scandurra
91ef57ed29
Merge branch 'master' into as-display-buffer-logical-coordinates
...
# Conflicts:
# src/display-buffer.coffee
2015-09-23 18:46:16 +02:00
Antonio Scandurra
baf27bf99a
Preserve un-rounded scroll positions
2015-09-23 17:40:48 +02:00
Antonio Scandurra
7666e4b82e
Commit pending positions when a frame is being served
2015-09-23 16:48:00 +02:00
Antonio Scandurra
87c7a0ae30
💚 Fix some TextEditorComponent specs
2015-09-23 16:25:50 +02:00
Antonio Scandurra
57a006d19b
Start porting scroll-related specs
2015-09-23 15:34:41 +02:00
Antonio Scandurra
37fb253bfd
Prevent default for mousewheel event on mini editors
...
(ref. 0346e58
2015-09-23 15:34:27 +02:00
Antonio Scandurra
ddd7aacd9d
💚 Fix TextEditorComponent specs
2015-09-23 15:34:22 +02:00
Antonio Scandurra
620e87420b
Allow null TextEditorComponent::domNode during visibility check
...
* Use `atom.assert` to verify that the ctor was run before the exception.
2015-09-22 21:18:55 +02:00
Nathan Sobo
1549235288
🔥 Remove deprecations from TextEditorComponent
2015-09-22 10:37:09 -06:00
Antonio Scandurra
374309fc47
🔥 Remove deprecated code
2015-09-21 14:50:17 +02:00
Nathan Sobo
c7ecad5576
Remove EditorView
2015-09-18 20:48:45 -06:00
Antonio Scandurra
3575928cce
Move continuous reflow setting into TextEditorElement
2015-09-17 17:14:00 +02:00
Antonio Scandurra
c6948b36dc
Clear pool after updating
2015-09-17 10:38:40 +02:00
Antonio Scandurra
ad83a03440
Merge branch 'master' into as-recycle-nodes
...
# Conflicts:
# src/line-numbers-tile-component.coffee
# src/lines-tile-component.coffee
2015-09-15 11:50:54 +02:00
Antonio Scandurra
daf4316974
Clear the pool when font or lineHeight change
2015-09-15 10:59:32 +02:00
Antonio Scandurra
f86c9b2331
Let TextEditorComponent manage DOMElementPool
2015-09-15 10:58:24 +02:00
Antonio Scandurra
c8c69a99b9
Release free nodes after destroying TextEditor
2015-09-15 10:36:47 +02:00
Antonio Scandurra
23cb2740cd
🐎 Remove class from tiles
2015-09-08 16:44:44 +02:00
Nathan Sobo
5be64cdc89
Merge pull request #8627 from atom/ns-terminate-drag-on-any-text-change
...
Terminate drag on any buffer change
2015-09-01 14:22:29 -06:00
Nathan Sobo
f3def3a7ed
Terminate drag on any buffer change
...
Not just text insertion.
2015-09-01 12:58:34 -06:00
Nathan Sobo
f1276f59de
Autoscroll when mouse gets close to the edge of the editor scroll view
...
Previously, we required the cursor to exceed the bounds of the editor,
but that makes it impossible to scroll when the window is maximized.
2015-09-01 10:43:45 -06:00
Nathan Sobo
2a3a304410
Terminate drag when editor is destroyed
...
Fixes #4562
2015-08-28 12:41:58 -06:00
Nathan Sobo
567199a3d2
Autoscroll the editor as a quadratic function of mouse cursor overshoot
...
This was a spike and still needs tests, but it’s going to be way better.
2015-08-28 12:17:59 -06:00
Jacek Kopecky
763d871470
use undo in IME composition
2015-08-26 20:28:23 +01:00
Nathan Sobo
55a0be9c81
Merge pull request #8377 from atom/ns-select-screen-lines-from-gutter
...
Select screen rows when click-dragging in gutter
2015-08-19 14:15:34 -06:00
Nathan Sobo
8ae3761cd7
Terminate selection drag on text input
...
On recent versions of OS X Yosemite, there is a delay before we receive
the `mouseup` event when dragging selections with the trackpad. This
means that we’re frequently accidentally inserting text before the
selection process terminates, leading to unexpected selections after the
text insertion. This fixes that behavior and makes the behavior more
straightforward even in the case where the mouse button is remains held
down during text insertion.
2015-08-19 13:44:17 -06:00
Nathan Sobo
31bdd563ed
Select by buffer row on gutter click, but by screen row on gutter drag
2015-08-19 12:46:20 -06:00
Nathan Sobo
3cf9238d79
Select screen rows when click-dragging in gutter
...
…Instead of entire buffer rows
2015-08-19 12:46:20 -06:00
Nathan Sobo
a88b648144
Unify gutter drag logic
...
This ensures the same approach is used to drag the gutter for all modes
of selection.
2015-08-13 15:55:35 -06:00
Nathan Sobo
216e98140d
Eliminate unused argument
2015-08-13 15:55:35 -06:00
Nathan Sobo
fbea2d7954
Autoscroll correctly when dragging gutter selections
...
* Explicitly assign the orientation of the selection when it crosses
the initially clicked row.
* Autoscroll to the cursor, not the entire selection.
2015-08-12 13:13:15 -06:00
Nathan Sobo
db72ce8362
Defer merging likewise gutter selections until mouseup
2015-08-04 11:29:08 -06:00
Nathan Sobo
52e640156c
Defer selection merge until dragging completes
2015-08-03 21:43:43 -06:00
