Nathan Sobo
72b971e01e
Revert "Replace @getLastVisibleScreenRow with @getFirstVisibleScreenRow"
...
This reverts commit 89ac1f50af
2012-05-31 17:56:26 -06:00
Nathan Sobo
645f57bb40
Merge branch 'master' of github.com:github/atom
2012-05-31 17:49:31 -06:00
Nathan Sobo
acb01bba37
Correctly render lines when destroying a fold forces an autoscroll
2012-05-31 17:48:50 -06:00
Corey Johnson
89ac1f50af
Replace @getLastVisibleScreenRow with @getFirstVisibleScreenRow
...
My 💄 commit awhile back was more than skin deep.
2012-05-31 16:23:38 -07:00
Corey Johnson
1a9566d954
Merge branch 'master' into binding-viewer
2012-05-31 15:55:23 -07:00
Corey Johnson
130361fc1c
Keybinding view is an extension
2012-05-31 15:54:40 -07:00
Corey Johnson
1d1eeb5c09
meta-w is a global keybinding
2012-05-31 15:26:59 -07:00
Nathan Sobo
fdb8ba8a2b
Remove redundant gutter spec. Corey's is in a better spot.
2012-05-31 12:13:36 -06:00
Nathan Sobo
06fffe6c4b
Merge branch 'master' of github.com:github/atom
...
Conflicts:
src/app/editor.coffee
2012-05-31 12:11:07 -06:00
Nathan Sobo
6291635586
Add Editor.logRenderedLines to help debugging
2012-05-31 12:06:20 -06:00
Nathan Sobo
c901417a19
When lines are added, remove any that get pushed down to exceed the max allowed row
...
This fixes issues where unfolding or pasting caused rendering artifacts below the last visible row.
2012-05-31 12:06:00 -06:00
Corey Johnson
477a11b6ba
💄
2012-05-31 10:27:14 -07:00
Corey Johnson
17c0526bc3
Add test for gutter rendering of fold lines
2012-05-31 10:26:34 -07:00
Nathan Sobo
39fb14e5f5
Add a spec for line number updates after folding/unfolding
2012-05-31 10:57:04 -06:00
Nathan Sobo
27f1117069
Bugfix: Render additional line numbers when unfolding (still needs a test)
2012-05-31 10:50:57 -06:00
Nathan Sobo
6c64d2a13b
spec 💄
2012-05-31 10:46:00 -06:00
Corey Johnson
46e94b33d4
💄
2012-05-30 10:20:39 -07:00
Corey Johnson
e6f3112aea
Merge pull request #8 from github/scroll-perf
...
Scroll performance tweaks
2012-05-30 10:19:18 -07:00
Nathan Sobo
c291cd1bb3
Cache hidden/visible state of cursor to avoid extra DOM hit when updating its appearance
2012-05-30 10:51:27 -06:00
Nathan Sobo
b1573438a7
Kill inset box-shadow on editor frame because it slows down repaint
2012-05-30 10:51:02 -06:00
Corey Johnson
cbf5c5d16c
ctrl-? brings up keybindings for focused view.
...
it is very ugly.
2012-05-29 17:59:00 -07:00
Corey Johnson
893564945e
Add rootView.activeKeybindings().
...
This will return all active keybindings available for the focused element.
2012-05-29 15:46:38 -07:00
Nathan Sobo
a160aef0e0
Merge branch 'overdraw'
2012-05-29 16:05:41 -06:00
Nathan Sobo
a32015f2e0
Un-F benchmark
2012-05-29 16:05:24 -06:00
Corey Johnson
64bd26a392
Add Keymap.bindingsForElement method
2012-05-29 14:15:54 -07:00
Nathan Sobo
0ef4c7e172
Only re-render the gutter when we render new lines
2012-05-29 15:12:11 -06:00
Nathan Sobo
3e26386f98
Always re-render gutter from the first rendered to the last rendered screen row
2012-05-29 14:51:19 -06:00
Nathan Sobo
0700aba67f
All specs pass again with overdraw
2012-05-29 13:39:13 -06:00
Nathan Sobo
6e34124f12
Overdraw gutter line numbers in addition to editor lines
2012-05-29 13:07:24 -06:00
Nathan Sobo
a9c9a854ac
Only truncate change ranges to the last visible row if the last rendered row is smaller
...
This happens, for example, when the entire buffer is shorter than the number of rows on screen. In this case, the last rendered row is not smaller than the last possible visible row.
2012-05-29 13:03:29 -06:00
Nathan Sobo
c00c3317f0
Down to 2 failures by truncating change ranges to the range of the current rendered lines
2012-05-29 12:52:39 -06:00
Nathan Sobo
e9a67208e6
Adjust otherwise-passing spec for overflow
2012-05-29 11:50:54 -06:00
Nathan Sobo
8fba4ff935
Fix some off by one errors in the overdraw calculations
2012-05-26 13:52:48 -07:00
Nathan Sobo
328aa3ba6b
WIP: Redoing overdraw code… it's broken
2012-05-26 13:05:25 -07:00
Nathan Sobo
351c283ed6
Merge branch 'master' into overdraw
2012-05-25 13:13:06 -07:00
Nathan Sobo
7c105a0446
Tweak fold line colors
...
The deselected orange is now a darkened version of the orange used for coffeescript arrows in the twilight theme. The selected color is now a green based on the color of the cursor, to lend a feeling of similarity between the fold line and the cursor.
2012-05-25 12:46:27 -07:00
Nathan Sobo
e2ca3814a9
Hide the cursor when it is on a fold line
2012-05-25 12:35:32 -07:00
Corey Johnson & Nathan Sobo
ce5a31b5a2
Merge branch 'fold-simplification' of github.com:github/atom into fold-simplification
2012-05-25 11:41:19 -07:00
Corey Johnson & Nathan Sobo
f6db1a2051
remove bufferRow arg from Renderer.registerFold()
2012-05-25 11:17:50 -07:00
Corey Johnson & Nathan Sobo
35b2f0e8c7
Buffer changes updates a stable list of folds
2012-05-25 11:05:45 -07:00
Corey Johnson & Nathan Sobo
bbcb59fe93
Buffer changes updates a stable list of folds
2012-05-25 10:58:30 -07:00
Corey Johnson & Nathan Sobo
f8c3d89e60
When folds are selected they are highlighted
2012-05-24 16:39:14 -07:00
Corey Johnson & Nathan Sobo
c11ee74405
Remove unused css
2012-05-24 14:08:32 -07:00
Corey Johnson & Nathan Sobo
74594ed2be
Destroy folds before inserting text on a fold line. Spec for deleting a fold line.
2012-05-24 13:53:48 -07:00
Corey Johnson & Nathan Sobo
f97912c160
💄
2012-05-24 11:43:09 -07:00
Corey Johnson & Nathan Sobo
9b83ce6545
renderer tells editor when the gutter needs to be updated
2012-05-24 11:17:37 -07:00
Corey Johnson & Nathan Sobo
c1197c1d0e
spec 💄
2012-05-23 14:56:22 -07:00
Corey Johnson & Nathan Sobo
dd7fff4522
WIP: Adding specs for various fold corner cases… think we still have some issues and gutter updates are failing.
2012-05-23 11:03:33 -07:00
Corey Johnson & Nathan Sobo
04f4a9a765
WIP: Handle buffer change events correctly with respect to folded lines
...
We're handling changes that straddle the start row and are in the middle of the fold, but we're still screwing up when the old range straddles the end row.
2012-05-22 19:02:13 -07:00
Corey Johnson & Nathan Sobo
13416bd6f2
Add Buffer.logLines()
2012-05-22 18:58:11 -07:00
