Ben Ogle
7a3893c7bb
Update doc strings
2014-09-03 16:10:33 -07:00
Ben Ogle
06165b2167
Remove the max call
2014-09-03 16:10:33 -07:00
Ben Ogle
f82c59d865
Add columnCount to moveRight
2014-09-03 16:10:33 -07:00
Ben Ogle
29f15d0f20
Make moveLeft() with huge values span multiple rows
2014-09-03 16:10:33 -07:00
Ben Ogle
99c07decf2
Add columnCount var to Editor::moveLeft and Cursor::moveLeft
2014-09-03 16:10:33 -07:00
Ben Ogle
851034c8d3
Failing test
2014-09-03 16:10:33 -07:00
Ben Ogle
3a85148f69
Fix doc strings
2014-09-03 16:10:33 -07:00
Ben Ogle
b90670ff2d
Gracefully handle the case when there is no screenline
2014-09-03 16:00:57 -07:00
Ben Ogle
523a255e48
Add Editor::lineTextForScreenRow()
...
Closes #3055
2014-09-03 14:42:46 -07:00
Ben Ogle
5e21d1ca5b
Deprecate Editor::lineLengthForBufferRow
2014-09-03 14:42:46 -07:00
Ben Ogle
0703788209
Editor::linesForScreenRows -> ::tokenizedLinesForScreenRows
2014-09-03 14:42:46 -07:00
Ben Ogle
c0c941b8db
lineForBufferRow -> lineTextForBufferRow
2014-09-03 14:42:46 -07:00
Ben Ogle
e3a0339fe3
Editor::lineForScreenRow -> ::tokenizedLineForScreenRow
2014-09-03 14:42:46 -07:00
Ben Ogle
c4265776b3
Rename unused method
2014-09-03 14:42:46 -07:00
Ben Ogle
ae49fd50b7
DisplayBuffer::linesForRows -> ::tokenizedLinesForScreenRows
...
Clarity!
2014-09-03 14:42:46 -07:00
Ben Ogle
cdbbec91f0
row -> bufferRow for clarity
2014-09-03 14:42:45 -07:00
Ben Ogle
dbb0ff9830
Remove unused method
2014-09-03 14:42:45 -07:00
Ben Ogle
99f899dc4a
lineForScreenRow -> tokenizedLineForRow
...
The method was severely mislabeled
2014-09-03 14:42:45 -07:00
Ben Ogle
2b9b4a48ef
tokenizedLineForRow -> tokenizedLineForScreenRow
2014-09-03 14:42:45 -07:00
Ben Ogle
b516f5a74d
lineForBufferRow -> lineTextForBufferRow
2014-09-03 14:42:45 -07:00
Ben Ogle
05bbc480b0
displayBuffer::lineForRow -> tokenizedLineForRow
2014-09-03 14:42:45 -07:00
Ben Ogle
c0e2ed4282
Fix comments
2014-09-03 12:04:21 -07:00
Ben Ogle
d3c2cd756a
Fix comment
2014-09-03 12:01:36 -07:00
Nathan Sobo
d3422786c3
Unmount component when EditorView is detached
...
Fixes #3431
When a pane item is moved to another pane, we *detach* the associated
view but we don’t fully remove it. This was to prevent removing a view
when it was used as the pane item directly. However, this was causing
the editor component not to be unmounted, which caused leaks and
incorrect measurements.
We need to unmount the component, but we don’t want to destroy the
editor. So I’ve moved editor destruction to the wrapper view for now,
and I only do it when the view is actually removed.
Ultimately, we need to have a 1:1 relationship with pane items and their
views and only allow a pane item to appear once in the pane tree. Then
we can recycle the same view and avoid this confusing situation where
the old view is detached and a new view is created.
2014-09-03 11:42:56 -06:00
Nathan Sobo
d753a7f38d
Merge pull request #3440 from atom/ns-exclusive-selection-intersection
...
Don’t merge adjacent non-empty selections
2014-09-03 09:24:05 -06:00
Nathan Sobo
cfd2722348
Don’t merge adjacent non-empty selections
...
This improves the behavior of #3433
2014-09-02 18:10:05 -06:00
Ben Ogle
ae0bffc4ea
Fix some doc strings
2014-09-02 17:01:20 -07:00
Ben Ogle
81532d52f7
Move select all fn so docs read better
2014-09-02 16:45:49 -07:00
Ben Ogle
0b34e46a1a
Merge pull request #3420 from atom/bo-update-cursor-selection-apis
...
Update cursor and selection APIs
2014-09-02 16:41:42 -07:00
Ben Ogle
1f925078e9
Remove deprecation
2014-09-02 14:59:06 -07:00
Ben Ogle
a564da1eb0
Remove unnecessary deprecated methods
2014-09-02 14:58:20 -07:00
Ben Ogle
3f67252757
Add row count docs
2014-09-02 14:50:15 -07:00
Ben Ogle
a7db555030
Order the getting ranges / positions by their insertion order
2014-09-02 14:38:11 -07:00
Ben Ogle
659c05c825
Add selectToBufferPosition
2014-09-02 14:09:56 -07:00
Ben Ogle
5ea64f8b11
selectWord() -> selectWordsContainingCursors()
2014-09-02 14:03:57 -07:00
Ben Ogle
70af6198bd
selectLine -> selectLinesContainingCursors
2014-09-02 14:02:26 -07:00
Kevin Sawicki
1aa391a207
Don't load ~/.atom/init.coffee in safe mode
...
This ensures the code from the init script isn't causing issues
when trying to reproduce something in safe mode.
Refs #2772
2014-09-02 13:51:26 -07:00
Kevin Sawicki
24add494ae
Normalize project path in Project::setPath
...
This will remove consecutive slashes as well as . and ..
characters and make path comparisons accurate.
Closes atom/tree-view#191
2014-09-02 10:49:02 -07:00
Nathan Sobo
c5aa446bc2
Prevent focusout events on hidden input when clicking focused editors
...
Fixes #3384
This is achieved by calling .preventDefault() on mousedown events when
the editor is already focused, which prevents the moving of focus to
the editor itself.
2014-09-02 11:37:46 -06:00
Kevin Sawicki
d43702f017
🐎 Use direct comparison instead of regex
2014-08-29 09:55:50 -07:00
Kevin Sawicki
690d32cca9
Document undefined case
2014-08-29 09:42:51 -07:00
Kevin Sawicki
d870cb8f36
Return undefined to ? fallback works
2014-08-29 09:42:01 -07:00
Kevin Sawicki
7cd080786c
Return a boolean like the comment says
2014-08-29 09:40:55 -07:00
Kevin Sawicki
a8a251c457
💄
2014-08-29 09:36:55 -07:00
Kevin Sawicki
9574458feb
📝 💄
2014-08-29 09:34:59 -07:00
Kevin Sawicki
692bf534b6
Merge pull request #3369 from khakionion/master
...
Better autodetection of Soft Tabs.
2014-08-29 09:34:01 -07:00
Kevin Sawicki
78f7ff6ee7
Focus existing window after opening path
2014-08-29 09:10:12 -07:00
Ben Ogle
4b4af946cf
Fix specs
2014-08-28 18:30:08 -07:00
Ben Ogle
5163d0f810
Fix dupe functions
2014-08-28 18:19:12 -07:00
Ben Ogle
08388d87c0
Remove getSelectionAtIndex
...
We’re going to eventually get rid of the clone in
getSelections / getCursors freeze those properties
and return them directly. Then they can operate
on the list garbage free.
2014-08-28 18:16:33 -07:00
