Commit Graph

25945 Commits

Author SHA1 Message Date
Nathan Sobo
82c2323feb Merge remote-tracking branch 'origin/master' into ns-alternative-test-env 2015-10-15 16:37:08 -06:00
Max Brunsfeld
93fe0208a5 Make atom.setSize() synchronous again, for now
This method is public, and a spec for TextEditorComponent dependend on it
staying synchronous
2015-10-15 15:12:57 -07:00
Nathan Sobo
28ed6f3d9f Restore async window method calls
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2015-10-15 13:26:30 -06:00
Nathan Sobo
52946db179 Ensure windows/workspace present before proceeding in integration specs
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2015-10-15 12:54:33 -06:00
Nathan Sobo
be1b2e6122 Increase timeout when waiting for atom-workspace to exist
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2015-10-15 12:08:07 -06:00
Thomas Johansen
eddf2bd2da ⬆️ settings-view@0.230.1 2015-10-15 11:27:13 +02:00
Antonio Scandurra
82fbec0879 🐛 Give priority to initial window background
Otherwise, since we now add styles element right during AtomEnvironment
construction, the default background gets showed (i.e. white on my machine).

/cc: @nathansobo
2015-10-15 11:05:16 +02:00
Antonio Scandurra
c38cd48555 Bring back failure reports when running grunt run-specs
Log output to stderr as we did before, so that grunt can, in turn, output it to
console when specs fail.

Welcome back build failures! 🎉

/cc: @nathansobo @maxbrunsfeld
2015-10-15 09:56:13 +02:00
Antonio Scandurra
edddb6516e Remove shim to remote.process
This doesn't seem to work as expected. I think it's just better to encourage
emitting an event like 'write-to-stdout' or using directly `remote.process`.

/cc: @nathansobo
2015-10-15 09:55:28 +02:00
Nathan Sobo
b58b3504f4 Only load/save AtomEnvironment state if persistence is enabled 2015-10-14 22:10:51 -06:00
Nathan Sobo
dc44d11a2c Don’t load/save config if enablePersistence option is false 2015-10-14 20:05:06 -06:00
Nathan Sobo
9df40b4f4e Remove unnecessary fat arrow 2015-10-14 19:53:16 -06:00
Wliu
a4efded72f 📝 Fix typo
/cc @benogle
2015-10-14 21:32:25 -04:00
Ben Ogle
7e730100db Merge pull request #9152 from atom/bo-help-wanted
Add the help-wanted and beginner issues to the contributing guide
2015-10-14 17:02:00 -07:00
Ben Ogle
1c9d5616da Title case 2015-10-14 16:51:42 -07:00
Ben Ogle
9d59514248 Add Making your first contribution section to guide 2015-10-14 16:49:21 -07:00
Nathan Sobo
95dd628d42 Fix for packages with no spec/fixtures directory 2015-10-14 17:10:30 -06:00
Nathan Sobo
a6a175c4a6 Don’t hide window when reloading specs 2015-10-14 16:40:40 -06:00
Nathan Sobo
f0da8f6324 Resolve package names to package currently being tested
This logic existed previously, but I accidentally removed it.
2015-10-14 16:35:00 -06:00
Nathan Sobo
a85a8d20de Don’t register defaultTarget for keymaps in constructor after all
We’re clearing the views on reset, so this view will end up being
different between test runs. Also, we didn’t previously always create
the workspace view in many cases, and it makes sense to apply that here.

We may want to get the default target for the keymap via a function so
we can defer view creation until one is needed.
2015-10-14 15:57:45 -06:00
Nathan Sobo
82cbf01c5b Set useCapture to true when handling keydown events in test windows
Prevents these events from getting intercepted by other handlers.
2015-10-14 15:57:45 -06:00
Nathan Sobo
c1d5cdcd64 Group requires at the top of atom-environment.coffee 2015-10-14 15:57:45 -06:00
Nathan Sobo
df66ca8d73 Remove unused params 2015-10-14 15:57:45 -06:00
Wliu
dfda029f71 Merge pull request #9135 from atom/wl-node-docs
Update Node versions in the docs
2015-10-14 17:51:28 -04:00
Max Brunsfeld
32780e2823 Merge branch 'master' into ns-alternative-test-env
Conflicts:
	package.json
2015-10-14 14:12:42 -07:00
Max Brunsfeld
db96fe62c9 Merge branch 'beta' 2015-10-14 13:54:52 -07:00
Max Brunsfeld
6c3b8cc034 Prepare 1.1.0-beta1 2015-10-14 13:54:18 -07:00
Max Brunsfeld
395ffde7a1 Merge pull request #9131 from atom/mb-fix-config-unset
Fix setting default values in config
2015-10-14 09:51:53 -07:00
Max Brunsfeld
974b45ce2c ⬆️ line-ending-selector 2015-10-14 09:50:49 -07:00
Ivan Žužak
6a0daebede Merge pull request #9096 from atom/iz-config-settings-descriptions
Add descriptions for config settings
2015-10-14 18:36:08 +02:00
Antonio Scandurra
6a77532d1e Merge pull request #9141 from atom/as-scroll-infinite-loop
Avoid stack overflow when scrolling with non-integer values
2015-10-14 18:25:43 +02:00
Antonio Scandurra
f2a32eb1dc Return empty string unless configDirPath is passed 2015-10-14 18:25:25 +02:00
Ivan Zuzak
b3a7fe3fc9 Clarify how auto-detection works 2015-10-14 18:01:43 +02:00
Antonio Scandurra
6a53034a12 Move GrammarRegistry reset after Workspace
...as some elements could still use grammars upon Workspace destruction.
2015-10-14 17:48:47 +02:00
Ivan Žužak
8dc61a667b ⬆️ settings-view@0.230.0 2015-10-14 17:16:14 +02:00
Antonio Scandurra
582fa571b8 📝 Better spec description 2015-10-14 16:20:42 +02:00
Antonio Scandurra
6b01811d20 Avoid stack overflow when scrolling with non-integer values
We were mistakenly using the rounded scroll top to guard against such cases.
This fixes it by using `@realScrollTop` instead.
2015-10-14 16:10:12 +02:00
Kevin Sawicki
cc179a06e2 ⬆️ text-buffer@7.1.3 2015-10-14 06:21:57 -07:00
Wliu
e916bd83b2 📝 node.js -> Node.js
[ci skip]
2015-10-14 13:03:22 +00:00
Antonio Scandurra
789af9fc69 Use params instead of loadSettings 2015-10-14 13:01:54 +02:00
Antonio Scandurra
c5860ce6b6 🐛 Fix typo 2015-10-14 12:59:22 +02:00
Antonio Scandurra
4b10f8a2b0 🔥 Avoid mocking atom.config in spec-helper 2015-10-14 12:47:33 +02:00
Antonio Scandurra
b25d3e944b Parameterize configDirPath and move config.load in ctor 2015-10-14 12:41:36 +02:00
Antonio Scandurra
d9af8686ed 🔥 Avoid attaching CommandRegistry to window twice 2015-10-14 10:29:56 +02:00
Antonio Scandurra
ed201d41cd 💚 Clear CommandRegistry on AtomEnvironment destruction 2015-10-14 10:11:53 +02:00
Antonio Scandurra
57f6fc5772 Observe core.autoHideMenuBar in AtomEnvironment ctor 2015-10-14 09:56:46 +02:00
Antonio Scandurra
f5f2d5dcd6 Remove remaining references to window global 2015-10-14 09:50:50 +02:00
Antonio Scandurra
0ea84ab192 Register default target for keymaps in ctor 2015-10-14 09:31:50 +02:00
Antonio Scandurra
a3190e4551 Use @window when (un)installing uncaught error handler 2015-10-14 09:18:54 +02:00
Nathan Sobo
974743d46c Attach CommandRegistry to window in constructor 2015-10-13 20:11:52 -06:00