Commit Graph

7482 Commits

Author SHA1 Message Date
Wliu
82faad9f92 Merge pull request #13825 from atom/wl-relativize-specs-more
Relativize spec paths more when reporting
2017-02-23 17:44:47 -05:00
Damien Guard
e04c31445d Merge pull request #13754 from hron/normalize-disk-drive-letter
Normalize disk drive letter in path on Windows
2017-02-20 09:54:19 -08:00
Aleksei Gusev
fd9dbb6e87 Normalize disk drive letter in path on Windows
Currently atom creates two buffers for the same file if passed
paths use difference case for disk drive letter,
e.g. d:\file.txt and D:\file.txt
2017-02-18 11:32:44 +03:00
Antonio Scandurra
4acd477559 Merge pull request #13818 from atom/ns-as-return-all-decorations
Return decorations for markers from *all* marker layers from decorationsForScreenRowRange
2017-02-17 11:15:15 +01:00
Antonio Scandurra
85dde00e82 Merge branch 'master' into as-use-babel6 2017-02-16 12:59:05 +01:00
Max Brunsfeld
97340ee4c5 Merge pull request #13810 from atom/mb-fix-state-key-when-opening-new-files
Restore correct directory's project state when opening a new file from the CLI
2017-02-15 14:13:28 -08:00
Max Brunsfeld
0c3b774c94 Avoid sending file path to renderer process in main process test
On windows, because the path contains backslashes, evaling a string containing
the path can interpret the backslashes as escape sequences
2017-02-15 13:53:08 -08:00
Max Brunsfeld
13055c8620 Wait on loadedPromise for workspace to deserialize in main process test 2017-02-15 11:05:21 -08:00
Wliu
b8a08affc6 Relativize spec paths more when reporting
* `[object Object].anonymous` changed a while back to just `.anonymous`
* Windows uses `file:///path` notation, so take that into account
* Also relativize paths in parentheses
2017-02-15 11:36:57 -05:00
Antonio Scandurra
cf329d0f63 Use octal integer literal 2017-02-15 17:19:55 +01:00
Nathan Sobo
c427daaadd Fix spurious rename 2017-02-14 14:12:20 -07:00
Max Brunsfeld
ec0270b250 Explicitly save window states in main process test 2017-02-14 12:40:00 -08:00
Max Brunsfeld
ee962052b2 Tweak naming in main process test
Signed-off-by: Nathan Sobo <nathan@github.com>
2017-02-14 12:05:17 -08:00
Nathan Sobo
e736656380 Don't pass default marker layer to decoration manager 2017-02-14 11:44:56 -07:00
Nathan Sobo
28508d9a3f Make decorationsForScreenRowRange return all decorations
Even if they are for markers that aren't on the default marker layer
2017-02-14 11:44:38 -07:00
Nathan Sobo
4abcace5c3 Throw exceptions when decorating destroyed marker layers 2017-02-14 09:44:02 -07:00
Max Brunsfeld
aea6896c2b Restore correct directory's project state when opening a new file from the command line 2017-02-13 17:23:11 -08:00
Nathan Sobo
ee749bf286 Assign className in DOMElementPool when building new elements
Also, improve test coverage
2017-02-13 11:27:44 -07:00
Nathan Sobo
1528561c9b Only free elements that the DOMElementPool created 2017-02-13 10:46:37 -07:00
Nathan Sobo
5753b75f09 Fail assertion with content metadata if the same element is freed twice
This changes the element pool to only remove elements' children right
before we use an element again in order to preserve the structure of
double-freed elements. This will aid in debugging double-free
occurrences. It's also less work in cases where nodes aren't reused.
2017-02-13 10:30:51 -07:00
Nathan Sobo
2ad6f83239 Allow metadata to be passed to atom.assert 2017-02-13 10:29:04 -07:00
Nathan Sobo
bb9d1f49c0 Convert DOMElementPool and specs to JS 2017-02-13 09:51:20 -07:00
Nathan Sobo
c6cae5b8fd Store represented directory paths directly on AtomWindow in main process
Fixes #13729

Previously, when adding a window, we were unable to read its current
project paths out of the hash of the URL during window initialization
because the window still considered itself to be loading. Rather than
fixing this issue, we decided to completely eliminate the sharing of
state between processes in the window.location and instead switch to
cached synchronous RPC for the loadSettings and a dedicated RPC-based
mechanism for the project paths.
2017-02-07 13:15:27 -07:00
undefined
14348855ef Show first project path as window title if no pane items are open
Fixes #13647.

This restores the behavior we had prior to #13475 when there are no pane
items while preserving its improved behavior for paths outside of the
current project.
2017-02-06 16:02:20 -07:00
Damien Guard
83266c7486 Revert "Normalize disk drive letter in path on Windows" 2017-02-06 07:10:18 -08:00
Damien Guard
f3468d2955 Merge pull request #13725 from hron/normalize-disk-drive-letter
Normalize disk drive letter in path on Windows
2017-02-04 17:51:40 -08:00
Aleksei Gusev
ae76925926 Normalize disk drive letter in path on Windows
Currently atom creates two buffers for the same file if passed
paths use difference case for disk drive letter,
e.g. d:\file.txt and D:\file.txt
2017-02-01 18:32:08 +03:00
Antonio Scandurra
e49ac783f8 Fix infinite recursion when calling getLastSelection from onDidAddCursor 2017-01-24 12:18:09 +01:00
Antonio Scandurra
c5fbb79ac9 Merge pull request #13668 from atom/as-dont-throw-exception-for-malformed-css
Don't transform deprecated selectors containing malformed CSS
2017-01-23 13:36:23 +01:00
Nathan Sobo
82741c7cac Merge pull request #13664 from atom/fb-as-show-cursor-on-selection
Add showCursorOnSelection config
2017-01-20 14:07:21 -07:00
Damien Guard
1d2331b7e9 Merge pull request #13671 from atom/dg-yardstick-win32-specs
Ensure win32 has parity with macOS for yardstick specs
2017-01-20 12:47:50 -08:00
Damien Guard
d6553ab62c Ensure win32 has parity with macOS for yardstick specs 2017-01-20 11:36:27 -08:00
Antonio Scandurra
93f2e34ded Don't transform deprecated selectors containing malformed CSS 2017-01-20 15:09:57 +01:00
Andres Suarez
1ee9d7b0f9 Add showCursorOnSelection config 2017-01-20 08:53:28 -05:00
Antonio Scandurra
1af1400911 Fix increasing/decreasing font size via ctrl-mousewheel
This regression was introduced with the removal of the shadow DOM from
`<atom-text-editor>` elements. Previously we were relying on Chrome
always reporting `<atom-text-editor>` as the mousewheel `event.target`.
As a result, removing the shadow boundary caused the mousewheel event to
be potentially dispatched from anywhere inside the editor element,
making our previous logic for handling ctrl-mousewheel invalid. This
commit fixes it by recognizing mousewheel events that are dispatched
from within an editor.
2017-01-20 13:53:49 +01:00
Damien Guard
afe7f9a1fa Revert unintentional commit to lines-yardstick-spec.coffee 2017-01-19 23:32:02 -08:00
Damien Guard
d50b56b6a1 Add title for proxy settings config 2017-01-19 18:55:04 -08:00
Damien Guard
6dd6f171c2 Allow a bufferdprocess to be manually started 2017-01-19 13:30:39 -08:00
Nathan Sobo
0410ac9e8f Fix uncaught exceptions in ThemeManager specs 2017-01-18 10:19:25 -07:00
Nathan Sobo
4ef2924f55 Fix exceptions activating invalid packages in tests 2017-01-18 10:19:25 -07:00
Nathan Sobo
a433a84ab5 Fix describe block indentation 2017-01-18 10:19:25 -07:00
Max Brunsfeld
a57b627a58 Re-throw package activation exceptions in test mode 2017-01-18 10:19:25 -07:00
Damien Guard
623caaf85d Merge pull request #13605 from atom/dg-correct-portable-path-windows
Correct the portable path location on Windows
2017-01-14 09:35:27 -08:00
Damien Guard
090bbf9e77 Fix spec for path 2017-01-14 09:04:49 -08:00
Nathan Sobo
76d84a7890 Handle multiple selections intersecting a line in duplicateLines 2017-01-12 13:38:19 -07:00
Christopher Chedeau
ef7ce7cd3a Always reserve two digits on the line number gutter
We are working on a feature that changes the content of the editor when you mouse over some things and it makes the UI jump when going from 1 line to > 10. This makes the UI feel really bad.

I've looked at Sublime and the 1-9 state is the same as 1-99, only when you reach 100 lines then it jumps. I think that it is a better behavior as you want to minimize jumps as much as possible and it is extremely likely that you are going to hit the 9-10 lines threshold.

![](http://g.recordit.co/ABIlZf5eTx.gif)

While this is being reviewed and until the new version shipped, we are going to monkeypatch Atom in order to get this feature.

```js
var presenter = atom.textEditors.editors.entries().next().value[0].presenter.__proto__;
var old_updateLineNumberGutterState = presenter.updateLineNumberGutterState;
presenter.updateLineNumberGutterState = function() {
  var res = old_updateLineNumberGutterState.apply(this, arguments);
  this.lineNumberGutter.maxLineNumberDigits = Math.max(2, this.lineNumberGutter.maxLineNumberDigits);
  return res;
};
```

Released under CC0
2017-01-10 18:14:50 -08:00
Max Brunsfeld
d6bddb4ce6 Avoid assertions about application.json in main process test
We can test the user-facing behavior by launching a second instance
of AtomApplication.

Refs #13564
2017-01-09 11:31:25 -08:00
Vladimir Timofeev
a7dda0e6f6 Refactor test code 2017-01-08 00:03:36 +03:00
Vladimir Timofeev
be57e4cd48 Additional check that storage/application.json exists 2017-01-07 23:58:28 +03:00
Vladimir Timofeev
4d5312fec5 Restore test behaviour to check content of storage/application.json 2017-01-07 23:52:29 +03:00