github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-01-23 22:08:08 -05:00
Code Issues Packages Projects Releases Wiki Activity
24,274 Commits 140 Branches 571 Tags
8a4b631dfedd855bda445b2697cd8fb5cd60cfb0
Commit Graph

5710 Commits

Author SHA1 Message Date
Kevin Sawicki
a6dfbb2804 Remove string detail check 
This appears to be in use by other packages

Refs atom/notifications#50
 2015-07-07 13:46:53 -07:00
Kevin Sawicki
93069fad75 Add stricter object checking 2015-07-07 13:46:53 -07:00
Kevin Sawicki
24a56e974b Add specs for message, options, and detail 2015-07-07 13:46:52 -07:00
Kevin Sawicki
b371b2f0c9 Guard against missing stdout/stderr 2015-07-07 09:50:07 -07:00
Kevin Sawicki
f4284b91ea Add failing spec for missing stdout/stderr 2015-07-07 09:50:07 -07:00
Max Brunsfeld
1761f19efb Merge pull request #7748 from atom/mb-emit-will-insert-text-on-paste 
Emit will-insert-text event when pasting
 2015-07-07 09:14:07 -07:00
Antonio Scandurra
4e4b49eef8 🐛 updateContentDimensions when model changes 2015-07-07 11:28:30 +02:00
Max Brunsfeld
8c3400c084 Emit will-insert-text event when pasting 2015-07-06 18:29:44 -07:00
Ben Ogle
5d42b27f5f Merge pull request #7411 from deprint/multiline-mini-editor 
Mini editor with TextEditor::setMini
 2015-07-06 13:56:20 -07:00
Nathan Sobo
a3308ef04d Clear notifications between specs 2015-07-01 16:35:59 -05:00
Nathan Sobo
550efc8397 Merge pull request #7633 from atom/ns-pane-items-must-be-objects 
Throw an exception when adding a non-object pane item
 2015-07-01 14:09:14 -05:00
Nathan Sobo
8348b2c039 Throw exception when adding a non-object pane item 2015-07-01 13:29:13 -05:00
Fabian Stiewitz
eca4ed170e Add specs for TextEditor::setMini in TextEditorElement 2015-07-01 12:36:10 +02:00
Nathan Sobo
df6ef94b60 🎨 add spaces after commas 2015-06-30 23:03:55 -05:00
Nathan Sobo
e472830063 Merge remote-tracking branch 'origin/master' into dsandstrom-add-subword-cursors-4 2015-06-30 22:55:40 -05:00
Nathan Sobo
ba3ab41f1f Eliminate hack to move cursor to beginning of buffer 
Use the structure of the regex plus a fix to text-buffer instead.
 2015-06-30 22:52:35 -05:00
Ben Ogle
4d77d4161d Merge pull request #7395 from oggy/will-remove-item 
Add Pane::onWillRemoveItem event.
 2015-06-30 15:25:16 -07:00
Nathan Sobo
8b088926bb Merge pull request #7602 from atom/ns-mixed-indent 
Restore support for mixed tabs and spaces in line indentation
 2015-06-30 15:54:47 -05:00
Nathan Sobo
eae9a45579 🎨 Clean up spec language 2015-06-30 15:54:15 -05:00
Nathan Sobo
83bddaf34e Merge branch 'master' into add-subword-cursors-4 
Conflicts:
	spec/text-editor-spec.coffee
 2015-06-30 15:43:33 -05:00
Nathan Sobo
82e25872b2 Handle indentation with mixed tabs and spaces 2015-06-30 15:31:11 -05:00
Nathan Sobo
1d8035c3cc Back out changes to onDidThrowError API 2015-06-30 15:30:58 -05:00
Nathan Sobo
5d957b677b Revert "Merge pull request #7373 from atom/revert-7350-ns-assertions" 
This reverts commit 1a3441a503, reversing
changes made to 1aab5e74d9.
 2015-06-30 15:30:58 -05:00
Antonio Scandurra
eb3e1437d0 ✅ Add spec to check for tile background color 2015-06-30 14:52:47 +02:00
Antonio Scandurra
8cd9128bec Merge branch 'master' into as-tiled-gutter 2015-06-30 14:40:44 +02:00
Nathan Sobo
32705ab372 Merge branch 'master' into as-tiled-gutter 2015-06-29 17:10:45 -05:00
Nathan Sobo
b6d099ac78 Consider tabs or spaces mutually exclusively as indentation 
Previously, we allowed a mix of tabs and spaces to be counted toward the
indentation of a line. This caused problems when auto-indenting lines in
a hard-tabbed file that contained “alignment spaces”, such as occurs in
aligned comment blocks. For this case, it makes more sense to assume
that the line is indented via tabs only, and consider the subsequent
alignment space as part of the line’s content. Since it’s hard to
imagine actual source code in which a mixed treatment of tabs and spaces
is desirable, I’m going with this over any more complex approach.
 2015-06-29 17:05:28 -05:00
George Ogata
8a5dfeae05 Add Pane::onWillRemoveItem event. 2015-06-24 00:16:45 -04:00
Nathan Sobo
b7a8ddd153 Revert "Add assertion mechanism" 2015-06-22 14:27:05 -05:00
Kevin Sawicki
aa2530cb4e Merge pull request #7360 from atom/iz-blow-up-on-undefined-command-callback 
Throw error for commands registered with non-function callbacks
 2015-06-22 11:10:17 -07:00
Nathan Sobo
1fe873740f Merge pull request #7350 from atom/ns-assertions 
Add assertion mechanism
 2015-06-22 12:18:44 -05:00
Ivan Zuzak
326457d21b Add test for object target case 2015-06-22 18:55:08 +02:00
Ivan Zuzak
6521c869c4 Failing test to demonstrate problem 2015-06-22 07:56:21 +02:00
Ivan Žužak
852456fafe Merge pull request #7173 from atom/ns-prompt-on-large-files 
Show a warning prompt when opening files over 20MB
 2015-06-21 18:17:59 +02:00
Nathan Sobo
11c3b3444b Return a boolean from atom.assert 2015-06-20 18:37:53 +02:00
Nathan Sobo
a1f6a15c0b Add atom.assert and atom.onDidFailAssertion 2015-06-20 18:37:53 +02:00
Nathan Sobo
cd35107f8c Call atom.onDidThrowError handlers with the error object 
…and remove a bunch of dead source maps handling. Source map handling
for stack traces is now built into Chromium so it shouldn’t be needed
here.

Original event properties maintained for backward compatibility with the
1.0 API. Can be deprecated for 2.0 once we transition
exception-reporter.
 2015-06-20 18:37:53 +02:00
Antonio Scandurra
d6ac7863c9 Merge branch 'master' into as-tiled-gutter 2015-06-19 20:12:43 +02:00
Antonio Scandurra
d7156ff387 Remove event listeners from orphaned gutters 2015-06-19 10:24:48 +02:00
Antonio Scandurra
26b1d166fd Merge pull request #7320 from atom/as-remove-gutter-from-view-registry 
Fix TextEditorComponent Race Condition
 2015-06-19 09:01:59 +02:00
Antonio Scandurra
a3a8d8417b Merge branch 'as-remove-gutter-from-view-registry' into as-tiled-gutter 2015-06-18 19:58:33 +02:00
Antonio Scandurra
c8f24d2358 Revert "🐛 Remove Gutter from ViewRegistry" 
This reverts commit b0d93accf7.
 2015-06-18 19:54:37 +02:00
Max Brunsfeld
64dfda572d Use raw buffer text (w/o invisibles) when testing decreaseIndentRegex 2015-06-17 12:07:42 -07:00
Max Brunsfeld
3cdeaa8b51 Don't auto-indent when pasting text w/ no line breaks 2015-06-17 10:57:21 -07:00
Antonio Scandurra
b04b0a8dc4 🐛 Fix race condition as well 2015-06-17 13:48:31 +02:00
Antonio Scandurra
b0d93accf7 🐛 Remove Gutter from ViewRegistry 
Closes #7306

We started noticing that when a `TextEditor` pane got split, the same view for
`Gutter` was being shared amongst several models, thereby making the same DOM
element accessible simultaneously by more than one object. This made us
experience *orphaned line numbers*, caused by two instances of
`LineNumberGutterComponent` mutating `.line-numbers` at the same time.

This is a typical race condition which I would normally address by understanding
and possibly locking the correct order in which operations should happen.
However, I believe in this situation we shouldn’t actually care about ordering
at all, since I think views should be kept “local”, thus avoiding to expose them
to the world and/or reusing them across other views (either accidentally as in
this case or on purpose).
 2015-06-17 12:28:10 +02:00
aki
449c03cb35 Fix destroy listeners 2015-06-16 18:05:45 +09:00
Max Brunsfeld
c43233892b Merge pull request #7225 from lpommers/add-remove-cursor-when-there-are-multiple-cursors-if-cmd-clicking-on-it 
Add remove cursor when there are multiple cursors and cmd clicking on it
 2015-06-12 10:41:17 -07:00
Luke Pommersheim
8521b81051 spec - getCursorAtScreenPosition checks cursors instead of cursor.marker 2015-06-12 19:21:37 +02:00
Antonio Scandurra
ce3304b788 🔥 Delete redundant specs 2015-06-12 18:41:19 +02:00