Nathan Sobo
905b28975e
Add split methods
2014-06-04 21:06:41 +09:00
Nathan Sobo
7e5f667b31
Don't assume ::component is defined
2014-06-04 21:06:27 +09:00
Nathan Sobo
f103e72c01
Remove exceptions related to unassigned lineHeight
...
These exceptions break specs when simulateDomAttachment is used. They
were only present to ensure correct sequencing during development of the
react editor, so it's safe to remove them for now.
2014-06-04 21:05:29 +09:00
Nathan Sobo
6cba6af743
Temporary: Enable react editor for specs on this branch so we get CI feedback
2014-06-04 19:18:54 +09:00
Nathan Sobo
eeb44407e3
Add ReactEditorView::getModel
2014-06-04 19:15:56 +09:00
Nathan Sobo
68df603512
Upgrade space-pen to make $.fn.view work with nodes appended w/o jQuery
...
The autosave package uses $.Event.targetView on a node that's managed
by React. This upgrade to SpacePen allows us to retrieve the containing
SpacePen view.
2014-06-04 19:15:56 +09:00
Corey Johnson
087b52c9b4
Remove unnecessary append method.
2014-06-03 17:13:23 -07:00
Corey Johnson
18f7297968
Use actual property for overlayer
2014-06-03 17:12:56 -07:00
Corey Johnson
3cd34e0b4d
Add gutter.getLineNumberElement shim
2014-06-03 15:25:26 -07:00
Corey Johnson
25e3e46166
Make overlayer a property
2014-06-03 14:57:46 -07:00
Corey Johnson
2c84d69ff2
Add overlayer shim
2014-06-03 14:40:30 -07:00
Corey Johnson
3fb28803b5
Add append shim
2014-06-03 14:40:17 -07:00
Corey Johnson
8e095d7b5b
Merge pull request #2164 from steffengy/fix-indent
...
Fix indenting of HTML tags for instance. Fix #1294
2014-06-03 12:01:44 -07:00
Ivan Žužak
9899e7f2e3
Merge pull request #2493 from atom/iz-update-build-docs
...
Add links to build error reports in build docs
2014-06-03 20:45:58 +02:00
Ivan Zuzak
a62a0f4bb7
add links to build error reports in build docs
2014-06-03 20:38:38 +02:00
Corey Johnson
dac792a243
Remove .editor class from ReactEditorView
...
ReactEditorView and EditorComponent were using the editor class. This
caused context menus that used `.editor` as the selector to display
twice.
2014-06-03 11:36:55 -07:00
Kevin Sawicki
31b3d8f967
Add missing require
2014-06-03 11:06:02 -07:00
Ben Ogle
55fb816998
Upgrade to base16-tomorrow-dark@0.16.0
2014-06-03 10:58:31 -07:00
Corey Johnson
ce527aea10
Pull out menu item building into seperate method
2014-06-03 10:51:46 -07:00
Kevin Sawicki
a7a9301f25
Quote all arguments to cmd.exe
...
This is required since the command or arguments may have spaces that will
be interpreted as separate arguments unless quotes surround it.
Closes #2231
Closes atom/symbols-view#37
2014-06-03 10:50:00 -07:00
Corey Johnson
0f551d4b11
Add expectations to context-menu specs
2014-06-03 10:44:45 -07:00
Corey Johnson
35a7bb115d
Fix context-menu specs
2014-06-03 10:44:45 -07:00
Kevin Sawicki
553abc2009
Merge pull request #2492 from p-e-w/linux-dev-tools-keybinding
...
🐧 Make "Developer Tools" key binding match Chrome
2014-06-03 10:37:43 -07:00
Philipp Emanuel Weidmann
0ad1aeea43
🐧 Make "Developer Tools" key binding match Chrome
2014-06-03 19:31:32 +02:00
Corey Johnson
7e52c86095
📝 Update context menu doc
2014-06-03 10:25:12 -07:00
Corey Johnson
950338ed22
Fix linter errors
2014-06-03 10:17:53 -07:00
Corey Johnson
8ed3b7a250
Merge pull request #2134 from erikhakansson/AdvancedContextMenu
...
Advanced context menu
2014-06-03 10:13:37 -07:00
Ivan Žužak
390c36ca15
Upgrade to tree-view@0.96.0
2014-06-03 18:56:28 +02:00
Ivan Žužak
1df2e50bbf
Upgrade to settings-view@0.118.0
2014-06-03 15:30:19 +02:00
Nathan Sobo
749dba1ac7
Prevent LinesComponent from updating on simple cursor movement
2014-06-03 19:23:19 +09:00
Nathan Sobo
a28566a559
Add ScrollbarCornerComponent::shouldComponentUpdate
2014-06-03 19:18:14 +09:00
Nathan Sobo
64f1c8b80e
Merge pull request #2481 from atom/ns-react-clean-up-measurement
...
Fix cursor and selection positioning when changing line height, font size, and font family
2014-06-03 19:15:40 +09:00
Nathan Sobo
b47f6265c7
Move gutter width measurement into EditorComponent
2014-06-03 18:30:24 +09:00
Nathan Sobo
9511c952af
💄
2014-06-03 18:19:11 +09:00
Nathan Sobo
be0877327e
Kill comment
2014-06-03 18:18:53 +09:00
Nathan Sobo
3134bfda95
Update selections when the font size or font family change
2014-06-03 17:43:57 +09:00
Nathan Sobo
1c177aa206
Add spec for cursor position updates when the font family changes
2014-06-03 17:43:57 +09:00
Nathan Sobo
ec65def5d3
Add spec for cursor position updates when the font size changes
2014-06-03 17:43:57 +09:00
Nathan Sobo
3aefa53b33
Batch together line and character width measurement after font changes
...
This ensures we only perform a single update with the most up-to-date
information about line height, default character width, and specific
character widths. If this update causes more lines to be drawn we may
measure again, but not necessarily.
2014-06-03 17:43:56 +09:00
Nathan Sobo
4fd07a4cf3
Subscribe to scroll view DOM events in ::listenForDOMEvents
2014-06-03 17:43:56 +09:00
Nathan Sobo
03463da729
Allow Editor::batchUpdates calls to be nested
2014-06-03 17:43:56 +09:00
Nathan Sobo
1cc5ef3479
Update selections when the line height changes
2014-06-03 17:43:56 +09:00
Nathan Sobo
77f78d0a11
Update cursors component if the defaultCharWidth changes
2014-06-03 17:43:56 +09:00
Nathan Sobo
8f98f2368b
Base gutter updates on defaultCharWidth instead of fontSize/Family
2014-06-03 17:43:56 +09:00
Nathan Sobo
f467e3eed4
Move decision to measure lineHeight/charWidths to EditorComponent
...
This prevents the double-update of the lines component when changing
the font-size, line-height and font-family. We detect the update of
these values in the root component and trigger a measurement. If the
measurement determines that the pixel values have changed, *then* we
update the lines.
2014-06-03 17:43:56 +09:00
Nathan Sobo
3052fe3f3b
Update cursors when the line height in pixels changes
2014-06-03 17:43:56 +09:00
Nathan Sobo
1bce626324
Compute ranges of cursors & selections in EditorComponent and pass down
...
Previously, SelectionsComponenet::shouldComponentUpdate was storing the
ranges for selections as a side effect. We also were passing boolean
values (cursorMoved and selectionUpdated) to determine if these
components should update.
Now, we compute a simple hash of screen ranges for selections and
cursors in the root component and pass them down. This simplifies
shouldComponentUpdate for selections and allows us to implement one
for cursors.
2014-06-03 17:43:55 +09:00
Nathan Sobo
e222998f82
Only compare screenRow to mouseWheelScreen row when it is defined
...
Fixes #2482
2014-06-03 17:43:35 +09:00
Kevin Sawicki
2aca16dc6b
Upgrade to language-hyperlink@0.10
2014-06-02 21:38:26 -07:00
Kevin Sawicki
653a2623bf
🏁 bind ctrl-alt-up-down to adding selections
2014-06-02 15:59:13 -07:00
