Commit Graph

173 Commits

Author SHA1 Message Date
Nathan Sobo
92395a9cfb Merge branch 'master' of github.com:github/atom
Conflicts:
	src/app/editor.coffee
2012-05-16 14:07:44 -06:00
Nathan Sobo
2d8ba3b1ee Use translate3d to scroll lines / gutter in attempt to improve repaint.
Also: Add custom scrollTop method to editor that manages all the custom optimizations we are doing around scrolling.
2012-05-16 13:47:59 -06:00
Corey Johnson
2c508f5a31 Fix tests
Certain tests resize the editor and expect the number of lines to adjust, this forces the test to meet that expectation.
2012-05-16 11:30:25 -07:00
Corey Johnson
3614ad6e76 Update lines when the font size changes 2012-05-16 10:58:19 -07:00
Corey Johnson
399fc71b3c Make Atom SpacePen view's default to empty object (where needed) 2012-05-16 10:35:50 -07:00
Corey Johnson
484b55800a Call updateLines when lines are removed from buffer 2012-05-15 14:27:22 -07:00
Corey Johnson
54a3823606 Buffer change events update the @lastRenderedScreenRow 2012-05-15 12:29:59 -07:00
Corey Johnson
6b3664a040 Vertical scrollbar height is updated when switching buffers 2012-05-15 10:02:56 -07:00
Corey Johnson & Nathan Sobo
9079bcb103 Meta-a selects everything 2012-05-14 16:18:37 -06:00
Corey Johnson & Nathan Sobo
513e15e369 Make editor tall so that all line numbers are rendered for this test 2012-05-14 15:42:51 -06:00
Corey Johnson
b35a2502c6 Gutter line numbers are rendered similarly to the scroll view's lines 2012-05-14 12:32:53 -07:00
Corey Johnson
5e4aef95d0 Only visible lines numbers are rendered by the gutter 2012-05-14 09:53:58 -07:00
Nathan Sobo
0c89db37a5 Editor scroll position is correctly restored on refresh.
When we attach the editor we need to scroll it to the correct position before rendering lines. But to scroll it to the right position, the lines container and the scrollbar need to be assigned a height that allows them to scroll. So now we call `prepareForVerticalScrolling` on attach, then set the scroll position based on the edit session and render the visible lines.
2012-05-11 17:51:47 -06:00
Nathan Sobo
96d92be230 Rename Editor.scrollbar to verticalScrollbar for clarity 2012-05-11 13:45:57 -06:00
Nathan Sobo
b64e9ae10f Rename Editor.scroller to Editor.scrollView to distinguish it from the vertical scrollbar.
Also, base edit session scroll top on the scrollbar instead of the scrollView.
2012-05-11 13:42:57 -06:00
Corey Johnson & Nathan Sobo
9427c82084 WIP: Getting specs passing with new stand-in vertical scrollbar 2012-05-11 11:52:03 -06:00
Corey Johnson & Nathan Sobo
02da32d372 Update visible lines when scrolling up 2012-05-10 16:11:05 -06:00
Corey Johnson & Nathan Sobo
43ac7edf0f Scrolling to bottom renders correct lines
When we scroll more than a single screen's worth of lines, the new first visible screen row ends up exceeding the previous last rendered screen row, so we need to use the maximum of the two when deciding which new rows to render.
2012-05-10 15:15:34 -06:00
Corey Johnson & Nathan Sobo
c5d2616155 WIP: Removing lines that are no longer visible 2012-05-10 12:08:58 -07:00
Corey Johnson & Nathan Sobo
22548141d7 Editor updates lines when it is resized 2012-05-10 11:14:03 -07:00
Corey Johnson & Nathan Sobo
f6e9d99865 Editor only does not pre-build lines, it only builds them when they are visible on the screen 2012-05-10 10:40:16 -07:00
Corey Johnson & Nathan Sobo
6eda0d345b 💄 2012-05-10 08:58:38 -07:00
Nathan Sobo
1e2d333a15 WIP: working on only rendering on-screen lines. still half-baked. 2012-05-10 09:27:04 -06:00
Corey Johnson & Nathan Sobo
5ae40a3cb8 Editor only renders lines when it is attached to the DOM 2012-05-09 19:19:54 -06:00
Nathan Sobo
5b7ea95a11 Meta+ and meta- change the editor font size 2012-05-09 10:57:25 -06:00
Nathan Sobo
f2f44b9ab6 Can match key patterns with the '-' character
Add a parser to parse keystroke patterns instead of splitting on '-' with a regex
2012-05-09 10:56:31 -06:00
Nathan Sobo
8b1ac28b89 Editor font sizes can be adjusted with RootView.proto.setFontSize 2012-05-09 08:34:08 -06:00
Nathan Sobo
6dda27e771 Go ahead and build a RootView in the editor spec 2012-05-08 20:20:56 -06:00
Corey Johnson & Nathan Sobo
4665321b37 Project.getFilePaths does not traverse into ignored directories 2012-05-08 17:59:38 -07:00
Corey Johnson
cb45675f14 Remove @path var from project 2012-05-08 13:02:14 -07:00
Nathan Sobo
9215d7f083 Remove console.log from root view spec 2012-05-08 13:16:24 -06:00
Nathan Sobo
648649d472 Merge branch 'master' of github.com:github/atom
Conflicts:
	spec/app/root-view-spec.coffee
	src/app/root-view.coffee
2012-05-07 19:38:01 -06:00
Nathan Sobo
31163f1d8c Convert FileFinder to a proper extension and remove references from RootView code 2012-05-07 19:30:07 -06:00
Corey Johnson
e4125448ec Make RootView.initialize unaware of deserialization.
When RootView is created without a pathToOpen, no editor is created.
2012-05-07 17:51:08 -07:00
Corey Johnson
dd1e617a41 remove compiled coffee file from src dir 2012-05-07 17:51:08 -07:00
Nathan Sobo
37438c6da8 Status bar path and cursor position updates 2012-05-04 13:58:11 -06:00
Corey Johnson & Nathan Sobo
28ff26e845 Merge branch 'master' into statusbar
Conflicts:
	src/app/editor.coffee
	src/app/project.coffee
	src/app/root-view.coffee
2012-05-04 11:41:13 -06:00
Corey Johnson
670717ca3b RootView deactivates extensions when it is deactivated 2012-05-03 17:31:37 -07:00
Corey Johnson & Nathan Sobo
f3c89240a3 Rename RootView.registerExtension() to RootView.activateExtension() 2012-05-03 17:13:09 -07:00
Corey Johnson & Nathan Sobo
870db53d3e Directory spec calls .off() when testing unwatch path 2012-05-03 09:43:45 -07:00
Corey Johnson & Nathan Sobo
5864fa5145 Add RootView.registerExtension() 2012-05-02 15:25:57 -07:00
Corey Johnson
d04be05e95 Root view sets project's path using project.setPath(path) 2012-05-01 10:00:53 -07:00
Corey Johnson
28f39cbdab When project's constructor is given a file as its path, it sets its path to the parent directory of the given file 2012-05-01 09:18:22 -07:00
Corey Johnson
acae9d63ca fs.directory does not append a trailing '/' to directories 2012-05-01 08:41:35 -07:00
Nathan Sobo
47c013f817 After each spec runs, make sure there are no subscriptions on directories (which would leak memory) 2012-04-26 15:54:54 -06:00
Nathan Sobo
fb6a967a18 EventEmitter.off with no args removes all subscriptions 2012-04-26 15:54:12 -06:00
Nathan Sobo
d6f5a5631c If temporary file is present in beforeEach, wait 20ms after deleting it to ensure the add event fires 2012-04-26 12:20:18 -06:00
Nathan Sobo
05bcd3e5e0 Fix EventEmitter… need to wait until after the loop to return! 2012-04-26 11:59:47 -06:00
Nathan Sobo
5156a37471 WIP: Tree view spec isn't there yet 2012-04-26 09:32:49 -06:00
Nathan Sobo
5c057e11b1 Make unwatchPath spec make a valid negative assertion and return the watchId from $native.watchPath 2012-04-25 20:14:35 -06:00