Nathan Sobo
97988eb62e
Clear font style in afterEach so it doesn't cause test pollution
2013-02-12 17:07:14 -07:00
Nathan Sobo
13db9169e9
Don't simulate DOM attachment. Pixel translation needs the real thing.
2013-02-12 17:07:14 -07:00
Nathan Sobo
405a918280
Never redraw when the font size changes on a detached editor
...
When the font size changes and the editor is detached, it schedules
itself to be redrawn the next time we're reattached rather than
updating the display in a detached state.
Detached display updates worked in the past because we didn't need to
be on the DOM to determine horizontal and vertical positions once we
had calculated dimensions once. So it worked to temporarily attach
the editor when calculating new dimensions, and then continue updates
even when it was detached. That now breaks because we can't ask for
pixel positions if we aren't on the DOM.
2013-02-12 17:07:14 -07:00
Nathan Sobo
81145eb35f
Initial support for variable width fonts
...
When translating a logical screen position (columns/rows) to a pixel
position, the editor now builds a temporary version of the line for the
given row. It then uses the DOM range API to insert an empty range
at the correct text node and offset for the given column and determines
the left position based on its clientRect.
Depending on the speed impact, we may want to optimize this by
recycling the existing line node if it exists on screen rather than
building a new one every time. We will still have to build one if the
line we're moving to isn't on screen yet. We could also increase the
chances of the line being on screen by autoscrolling to the vertical
position first, and *then* calculating the horizontal position. Lots
to explore here.
2013-02-12 17:07:14 -07:00
Kevin Sawicki
8922a27eb3
Subtract skipped count from complete and total counts
2013-02-12 15:52:00 -08:00
Kevin Sawicki
07c5a94613
Remove unused packages ivar
2013-02-12 15:47:31 -08:00
Kevin Sawicki
37ff0d05ed
Subscribe to grammars-loaded event in editor
...
Previously an error would be logged if this event fired
after an editor had been removed.
2013-02-12 15:12:59 -08:00
Kevin Sawicki
2910a90916
Round spec time to 2 decimal points
2013-02-12 14:48:16 -08:00
Justin Palmer
f19e536b25
style code
2013-02-12 14:32:45 -08:00
Justin Palmer
64b187a7e3
style markdown quote
2013-02-12 14:25:29 -08:00
Justin Palmer
12b340f072
🔪 markup 🔫
2013-02-12 14:13:58 -08:00
Kevin Sawicki
963a67dc9e
Add 'link' to expected scopes
2013-02-12 14:04:10 -08:00
Kevin Sawicki
f30f175c4e
Remove unneeded id
2013-02-12 13:59:57 -08:00
Justin Palmer
658b243a16
Merge pull request #257 from github/gfm-styles
...
Simple styles for GFM
2013-02-12 13:59:01 -08:00
Kevin Sawicki
54c3cdb4cb
Use input element to test focus after cancel
2013-02-12 13:55:28 -08:00
Kevin Sawicki
ae1be0ff2c
Remove unneeded rootView variable
2013-02-12 13:34:51 -08:00
Justin Palmer
b5ddbe9043
tweak colors, make link label different shade than link
2013-02-12 13:31:16 -08:00
Kevin Sawicki
5f84ec711b
Add class to hard tabs and leading/trailing spaces
...
This allows whitespace to be still be styled when invisibles
are disabled.
2013-02-12 13:25:22 -08:00
Kevin Sawicki
9af54de0f6
Add type of invisible as second class in span
...
This allows hard tabs, leading whitespace, and
trailing whitespace to be styled independently.
2013-02-12 13:02:34 -08:00
Kevin Sawicki
ad4398c4c5
Always return focus to the editor after a tab drop
2013-02-12 12:36:22 -08:00
Kevin Sawicki
85f404daf4
Find destination editor in single query
2013-02-12 12:25:53 -08:00
Justin Palmer
609342af16
light markdown
2013-02-12 12:08:48 -08:00
Justin Palmer
be94f14d61
dark markdown
2013-02-12 12:08:38 -08:00
Justin Palmer
5acf544fce
remove colors from main stylesheet
...
They won't work for light and dark styles
2013-02-12 12:08:30 -08:00
Justin Palmer
f7893f4e21
name the link match
2013-02-12 12:01:07 -08:00
Justin Palmer
cc9707bd35
add markdown.css
2013-02-12 12:00:54 -08:00
Kevin Sawicki
1f4aedeb10
Rename isReadme to isReadmePath
2013-02-12 11:47:13 -08:00
Kevin Sawicki
0b2e2dad71
Merge pull request #135 from github/undo-tab-close
...
Restore last closed tab
2013-02-12 11:22:46 -08:00
Kevin Sawicki
d234c8fdce
Don't track closed sessions with no path
2013-02-12 11:20:21 -08:00
Kevin Sawicki
eceabf0e31
Add spec for clearing opened session from undo stack
2013-02-12 11:17:43 -08:00
Kevin Sawicki
9e39a382e8
DRY up checking if path is .cson or .json
2013-02-12 11:02:07 -08:00
Kevin Sawicki
4c4b57abc7
Support .json snippets
2013-02-12 09:50:13 -08:00
Kevin Sawicki
5944c351ec
Suppport .json grammars
2013-02-12 09:48:25 -08:00
Kevin Sawicki
5ecbda0aac
Restore closed tab at previous index
2013-02-12 09:41:32 -08:00
Jon Rohan
83fc0fb0e0
Making the light theme close icons a tiny tiny less bold.
2013-02-12 09:28:51 -08:00
Kevin Sawicki
fb9451556d
Bind to body instead of #root-view
2013-02-12 09:00:07 -08:00
Jon Rohan
c43a1e5ce5
Undo last closed tab
2013-02-12 08:56:39 -08:00
Kevin Sawicki
1ee1fa02ba
Merge pull request #255 from github/rearrange-tabs
...
Drag and drop tabs
2013-02-12 08:38:52 -08:00
Kevin Sawicki
a8e068ade0
💄
2013-02-12 08:36:57 -08:00
Justin Palmer
7e83a138cf
Revert "Use octicon for drop target indicator"
...
This reverts commit ad9114c95e
2013-02-12 08:34:46 -08:00
Kevin Sawicki
728681a34e
💄
2013-02-12 08:24:32 -08:00
Kevin Sawicki
21e5f550c8
Assert editor receives focus after tab is dropped
2013-02-11 21:11:15 -08:00
Kevin Sawicki
9057f044bf
Add specs for Editor.moveEditSessionToEditor
2013-02-11 21:01:21 -08:00
Kevin Sawicki
9eae796be3
Add move edit session specs
2013-02-11 20:54:04 -08:00
Kevin Sawicki
ad9114c95e
Use octicon for drop target indicator
2013-02-11 20:35:41 -08:00
Kevin Sawicki
c9fae85375
Rename moveEditSessionAtIndex to moveEditSessionToIndex
2013-02-11 20:29:48 -08:00
Kevin Sawicki
472b436b24
Add spec for dragging/dropping tabs across editors
2013-02-11 20:24:01 -08:00
Corey Johnson
06e96cc346
Fold failed specs on click
2013-02-11 20:23:42 -08:00
Corey Johnson
6515d09a06
Tweak jasmine spec css
2013-02-11 20:14:52 -08:00
Kevin Sawicki
867e8d5678
Add spec for dragging/dropping tab in the same editor
2013-02-11 20:03:28 -08:00
