Max Brunsfeld
ca146c991a
Merge pull request #7341 from atom/as-remove-orphaned-gutter-events
...
Remove event listeners from orphaned gutters
2015-06-19 10:52:17 -07:00
Kevin Sawicki
bde74dee0b
Merge pull request #7281 from atom/sm-default-editor-font
...
New default editor font
2015-06-19 09:12:18 -07:00
simurai
533abc5a63
Increase default line height even a bit more
2015-06-19 21:31:36 +09:00
Antonio Scandurra
d7156ff387
Remove event listeners from orphaned gutters
2015-06-19 10:24:48 +02:00
Antonio Scandurra
26b1d166fd
Merge pull request #7320 from atom/as-remove-gutter-from-view-registry
...
Fix TextEditorComponent Race Condition
2015-06-19 09:01:59 +02:00
simurai
2017e3fe23
Increase default line height
2015-06-19 10:22:26 +09:00
Antonio Scandurra
a3a8d8417b
Merge branch 'as-remove-gutter-from-view-registry' into as-tiled-gutter
2015-06-18 19:58:33 +02:00
Antonio Scandurra
c8f24d2358
Revert " 🐛 Remove Gutter from ViewRegistry"
...
This reverts commit b0d93accf7
2015-06-18 19:54:37 +02:00
Max Brunsfeld
64dfda572d
Use raw buffer text (w/o invisibles) when testing decreaseIndentRegex
2015-06-17 12:07:42 -07:00
Max Brunsfeld
3cdeaa8b51
Don't auto-indent when pasting text w/ no line breaks
2015-06-17 10:57:21 -07:00
Antonio Scandurra
b04b0a8dc4
🐛 Fix race condition as well
2015-06-17 13:48:31 +02:00
Antonio Scandurra
b0d93accf7
🐛 Remove Gutter from ViewRegistry
...
Closes #7306
We started noticing that when a `TextEditor` pane got split, the same view for
`Gutter` was being shared amongst several models, thereby making the same DOM
element accessible simultaneously by more than one object. This made us
experience *orphaned line numbers*, caused by two instances of
`LineNumberGutterComponent` mutating `.line-numbers` at the same time.
This is a typical race condition which I would normally address by understanding
and possibly locking the correct order in which operations should happen.
However, I believe in this situation we shouldn’t actually care about ordering
at all, since I think views should be kept “local”, thus avoiding to expose them
to the world and/or reusing them across other views (either accidentally as in
this case or on purpose).
2015-06-17 12:28:10 +02:00
Max Brunsfeld
dbb1200e1b
🔥 unused method
2015-06-16 14:54:01 -07:00
aki
449c03cb35
Fix destroy listeners
2015-06-16 18:05:45 +09:00
Max Brunsfeld
41773b0861
Fix incorrect state save when exiting
2015-06-15 14:14:08 -07:00
simurai
e4ba689e40
Replaces default editor font
...
Only affects OS X
2015-06-15 16:03:50 +09:00
Antonio Scandurra
a7ff49ebaa
🎨
2015-06-13 17:36:20 +02:00
Antonio Scandurra
e190d441ed
🔥
2015-06-13 14:25:50 +02:00
Antonio Scandurra
e893b5105b
Remove presenter as a dependency where possible
...
Although we have a couple of components which still access it, we
agreed it would have been just better to avoid relying on
`TextEditorPresenter` where possible and use it purposefully in other
places (e.g. `LinesComponent` which needs it to store text
measurements).
/cc: @jssln
2015-06-13 14:18:36 +02:00
Max Brunsfeld
715238c3cd
Add by clauses to for loops to avoid complex loop increments
2015-06-12 16:38:07 -07:00
Max Brunsfeld
6282e7e533
Merge pull request #7234 from atom/mb-keep-state-when-auto-updating
...
Avoid saving state when closing windows due to auto-update
2015-06-12 10:50:57 -07:00
Max Brunsfeld
c43233892b
Merge pull request #7225 from lpommers/add-remove-cursor-when-there-are-multiple-cursors-if-cmd-clicking-on-it
...
Add remove cursor when there are multiple cursors and cmd clicking on it
2015-06-12 10:41:17 -07:00
Antonio Scandurra
b6049857ed
🎨
2015-06-12 19:00:15 +02:00
Antonio Scandurra
374aaac7b5
Rename to LinesTileComponent
2015-06-12 18:32:40 +02:00
Antonio Scandurra
6bff934b76
🎨
2015-06-12 18:22:43 +02:00
Antonio Scandurra
7ac0cdcbf5
Start porting TextEditorComponent spec
2015-06-12 18:22:33 +02:00
Antonio Scandurra
13087eb58e
Handle Max Line Number Digits
2015-06-12 12:39:24 +02:00
Antonio Scandurra
d45fc8a41f
Port TextEditorPresenter specs
2015-06-12 12:10:55 +02:00
Antonio Scandurra
f1c5745780
Merge branch 'master' into as-tiled-gutter
2015-06-12 10:49:19 +02:00
Antonio Scandurra
d14e7b9456
Enable maxLineNumberDigits
2015-06-12 10:41:50 +02:00
Luke Pommersheim
9f0f4c0530
refactor getCursorAtScreenPosition to avoid temporary array
2015-06-12 08:38:25 +02:00
Luke Pommersheim
3b3dc83a38
📝 updating docs for getCursorAtScreenPosition - can also take an {Array}
2015-06-12 08:36:44 +02:00
Max Brunsfeld
e47221bc3f
Never save window state in the middle of quitting
2015-06-11 17:24:12 -07:00
Kevin Sawicki
7a6a48d7ea
Move getSaveDialogOptions near other save methods
2015-06-11 15:31:43 -07:00
Kevin Sawicki
a0778217df
Merge pull request #7145 from FoldingText/Item-provides-save-panel-options
...
Item provides save panel options
2015-06-11 15:28:24 -07:00
Kevin Sawicki
48bf4203e1
Merge pull request #7237 from ssorallen/git-repository-docs
...
Add missing docs for GitRepository
2015-06-11 15:22:47 -07:00
Nicklas Gummesson
51dcc84fce
Bind core:cut to native action
...
Using same pattern as the others
2015-06-11 23:10:26 +02:00
Ross Allen
51016550c3
Add missing docs for GitRepository
...
Add argument and return type docs to fill in the documentation site.
2015-06-11 13:45:06 -07:00
Max Brunsfeld
844cfcb7ae
Avoid saving state when closing windows due to auto-update
2015-06-11 12:51:36 -07:00
Antonio Scandurra
eb48f06d2f
Merge branch 'master' into as-tiled-gutter
2015-06-11 18:38:31 +02:00
Luke Pommersheim
c67f98febb
if there are multiple cursors and you click a cursor, it is removed, otherwise new cursor is added. Cannot remove if there is only one cursor and you click on it
2015-06-11 13:26:09 +02:00
Luke Pommersheim
5822eb11f1
function that returns the first matched Cursor at a given screen position Point if it exists in that location
2015-06-11 13:02:14 +02:00
herkyl
b3687265bb
Fixed 'setBufferRange' documentation parameter name
2015-06-11 10:37:38 +03:00
Kevin Sawicki
0edce07446
Use folder name when metadata name is empty string or non-string
2015-06-10 16:46:35 -07:00
Kevin Sawicki
4d76e607f0
Use dirname for forwarding atom/apm commands
...
Refs #7141
2015-06-10 16:30:54 -07:00
Max Brunsfeld
48ca93261f
Merge pull request #7219 from atom/bf-revert-the-revert-of-pr-7022
...
Re-introduce atom.directory-searcher service v0.1.0.
2015-06-10 15:51:19 -07:00
Kevin Sawicki
3b6015954b
Merge pull request #7176 from atom/mq-package-name-metadata
...
Only use package directory name as fallback
2015-06-10 15:38:31 -07:00
Michael Bolin
ad46b37cfe
In workspace-spec.coffee, updated FakeSearch to match the spec, which
...
helped uncover a bug.
2015-06-10 23:30:42 +01:00
Michael Bolin
3c44bc06f4
Revert "Revert "Introduce atom.directory-searcher service v0.1.0.""
...
This reverts commit 262d41c306
2015-06-10 23:30:25 +01:00
Kevin Sawicki
c3953dbbd4
Don't focus when opening locations
2015-06-10 09:27:20 -07:00
