Commit Graph

7302 Commits

Author SHA1 Message Date
Matthew Dapena-Tretter
f1be4f057e Add methods for checking if initial packages have been loaded/activated
This will allow packages to observe the state without having to worry
about subscribing to the events after they've already fired.

Originally suggested in #10839
2016-10-06 15:36:28 -07:00
Max Brunsfeld
e6cac10a23 Always return Disposable from maintain{Config,Grammar} 2016-10-05 12:03:53 -07:00
Indrek Ardel
fd1e060592 Use inline source maps for coffeescript 2016-09-30 15:03:04 +03:00
Max Brunsfeld
d79690e2d5 Merge pull request #12823 from atom/mb-as-guard-tab-length
Guard against null tab length value
2016-09-29 14:21:54 -07:00
Wliu
0e99232615 Merge pull request #12782 from Ingramz/remove-unused-variables-obvious
Remove unused variables (obvious ones)
2016-09-29 16:58:06 -04:00
Max Brunsfeld
51a2360a9b Fix uses of call-window-method IPC channel in specs 2016-09-29 12:13:24 -07:00
Max Brunsfeld
556d79b544 Guard against null tab length value
Signed-off-by: Antonio Scandurra <as-cii@github.com>
2016-09-29 12:01:39 -07:00
Indrek Ardel
55f3311c01 Remove unused variables 2016-09-26 20:52:13 +03:00
Nathan Sobo
85efc08d13 Merge pull request #12753 from lgeiger/tildify-path
Tildify path in title bar
2016-09-22 15:07:50 -07:00
Nathan Sobo
b7126aff4c Don't serialize packages in deactivatePackages
Serialization still occurs when deactivating a single package via the
API. Otherwise, when the window is closed or reloaded we will serialize
all packages as a result of saving the window state.

Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2016-09-22 12:39:06 -06:00
Lukas Geiger
498a56a603 Tildify path in title bar
This will use ~/ for the path to the home directory
2016-09-22 11:14:03 +02:00
Max Brunsfeld
b88fa984cf Wait for project folder to be added in main process tests 2016-09-21 11:37:37 -07:00
Max Brunsfeld
3039024d17 Go back to using promise based on window:loaded event in main process tests 2016-09-21 11:37:24 -07:00
Max Brunsfeld
cff4de5195 Wait for project directory to be added in main process test 2016-09-21 11:04:29 -07:00
Max Brunsfeld
da6bfedc76 Merge branch 'master' into mb-ns-avoid-adding-non-existent-project-directories 2016-09-21 09:54:04 -07:00
Max Brunsfeld
890436a456 Spy on AtomEnvironment.destroy in window event handler spec 2016-09-20 17:45:58 -07:00
Max Brunsfeld
d1a4fd2378 Wait for reused window's project paths to update in main process test
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-09-20 16:52:47 -07:00
Max Brunsfeld
833b3b0ab0 Save state when reloading AtomWindow
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-09-20 16:10:11 -07:00
Max Brunsfeld
c2c7241eda Destroy AtomEnvironment in beforeunload handler, not unload handler
See https://github.com/electron/electron/issues/7278

Signed-off-by: Nathan Sobo <nathan@github.com>
2016-09-20 16:10:05 -07:00
Nathan Sobo
fa41da182e Merge pull request #12697 from atom/ns-upgrade-atom-keymap
Improve support for international keyboards
2016-09-20 14:43:01 -07:00
Max Brunsfeld
46eb861f84 Try manually tearing down atom env before reloading window in main process spec 2016-09-20 12:37:40 -07:00
Max Brunsfeld
cec2c87793 Assert about remote directories' types in main process test 2016-09-20 09:54:28 -07:00
Max Brunsfeld
7c93063861 Merge remote-tracking branch 'origin/master' into mb-ns-avoid-adding-non-existent-project-directories 2016-09-19 12:31:38 -07:00
Max Brunsfeld
ee1b8160e5 Wait for each window to save its state in main process test
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-09-19 12:06:37 -07:00
Max Brunsfeld
511fe1a576 Tweak test again for travis
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-09-19 11:02:48 -07:00
Nathan Sobo
7bba3e86b2 Try this on travis 2016-09-16 16:47:33 -06:00
Nathan Sobo
f62bf2c7e0 Focus test on for travis 2016-09-16 14:22:23 -06:00
Nathan Sobo
5fad2bdbf9 Return a promise from AtomWindow.reload that resolves on window:loaded 2016-09-16 14:10:34 -06:00
Max Brunsfeld
e444076a46 WIP - debug travis CI failures 2016-09-15 17:29:02 -07:00
Max Brunsfeld
0d2b7d12b7 Fix test description 2016-09-15 16:56:10 -07:00
Max Brunsfeld
3758fe5646 Use fake directory provider in integration test for remote dirs
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-09-15 16:33:04 -07:00
Max Brunsfeld
09b50f8740 Don't remove non-local directories on Project deserialization 2016-09-15 16:32:14 -07:00
Nathan Sobo
a6094d2ed0 Don't allow menu shortcuts that could conflict with AltGraph characters
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2016-09-15 14:08:35 -06:00
Max Brunsfeld
fe480d8fa4 Do not add project directories that do not exist
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-09-14 13:48:17 -07:00
Max Brunsfeld
3aaa738944 Activate atom.directory-provider services before deserialization
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-09-14 13:26:03 -07:00
Matthew Dapena-Tretter
283a573ce5 Test that destroyed panes aren't included in PaneContainer::getPanes() 2016-09-12 18:03:40 -07:00
Nathan Sobo
e313bbe89c Ensure pane is added to container before invoking onDidAddPane listeners
Fixes #12654
2016-09-12 11:00:26 -06:00
Thomas Johansen
5de0e5016e 🐛 Invoke reload instead of non-existant restart
Fix #12665
2016-09-12 07:59:10 +02:00
Max Brunsfeld
2dfa06f24c Merge pull request #12501 from atom/fb-as-add-observe-buffers
Add atom.project.observeBuffers
2016-09-09 13:45:46 -07:00
Antonio Scandurra
5c3bad077d Run platform-specific specs without mocking process.platform 2016-09-09 17:58:23 +02:00
Antonio Scandurra
924ca8ecf6 Run main process tests on Windows 2016-09-09 17:58:23 +02:00
Antonio Scandurra
6841babc4a Run main process tests on Linux 2016-09-09 17:58:23 +02:00
Antonio Scandurra
ccd381b8ad Merge pull request #12645 from atom/as-fix-app-not-quitting-on-windows-and-linux
Fix app not quitting on win32 and linux when closing the last window
2016-09-09 17:57:57 +02:00
Antonio Scandurra
e2a3b75db2 Fix app not quitting on win32 and linux when closing the last window
This regression was caused by a nuance in the way we maintain state in
`AtomApplication` for open windows. Specifically, when closing the last
window on Windows and Linux, we were explicitly calling `app.quit`
*before* removing such window from the list of open ones. In turn, this
caused the new `before-quit` behavior introduced in #12619 to work
improperly because it made the application wait on saving the state of a
stale window before exiting.

With this commit we are fixing that by making sure the stale window is
removed before calling `app.quit` in `removeWindow`.
2016-09-09 10:51:40 +02:00
Joe Fitzgerald
d4d05244b3 ATOM_SUPPRESS_ENV_PATCHING > ATOM_DISABLE_SHELLING_OUT_FOR_ENVIRONMENT 2016-09-08 12:24:33 -06:00
Joe Fitzgerald
3c7a89ec93 Add Spec To Validate Updating An Existing Env Var
- 🎨 Update spec description to more accurately reflect the intent
2016-09-08 11:17:42 -06:00
Joe Fitzgerald
b321ab6a38 Prevent Regression For Common Shells
- Fix lint warnings
2016-09-08 10:56:01 -06:00
Joe Fitzgerald
10270609d8 Use ATOM_SUPPRESS_ENV_PATCHING Environment Variable
- Stop using shell whitelist
2016-09-08 10:56:01 -06:00
Joe Fitzgerald
c570e14420 Get Environment From Shell On Linux 2016-09-08 10:56:01 -06:00
Antonio Scandurra
bb7ff6d535 🎨 2016-09-07 16:36:01 +02:00