Commit Graph

10702 Commits

Author SHA1 Message Date
Max Brunsfeld
d90daf07f8 In PackageManager::activatePackage reject, don't throw 2014-12-23 16:47:43 -08:00
Max Brunsfeld
388428b074 Fix logic error when exception is thrown in config observer 2014-12-23 16:47:43 -08:00
Max Brunsfeld
a1b4820c04 Revert "Revert "Merge pull request #4631""
This reverts commit dc2a453986.

Conflicts:
	spec/config-spec.coffee
	src/config.coffee
2014-12-23 09:26:40 -08:00
Kangaroopower
04ceaf36bf Actually return the new grammar, as per the API
Previously, the emitter didn't return the new type of grammar, just an undefined to signal when the grammar changed. This patch makes it so that the type of grammar is returned when the texteditor's grammar changes, as per what the API says it does
2014-12-22 21:46:16 -08:00
Max Brunsfeld
08d183dff1 Remove unused $ variable in Package 2014-12-22 17:33:30 -08:00
aershov
11112cb374 Call setCursorBufferPosition only if this method exists
@kevinsawicki:
That way in the case where a custom editor is opened that isn't a text editor,
it won't blow up if the custom editor doesn't implement setCursorBufferPosition.
2014-12-23 00:42:43 +03:00
aershov
229e7e03b2 Respect initialLine and initialColumn options when reopening a file
Fix #1743
2014-12-21 21:08:18 +03:00
Kevin Sawicki
85456ad920 Add missing s in comspec 2014-12-19 18:59:46 -08:00
Kevin Sawicki
aabf4dfbab Add missing path require
Closes atom/settings-view#288
2014-12-19 18:37:05 -08:00
Ben Ogle
44327724a8 Default followSymlinks to false 2014-12-19 17:25:53 -08:00
Ben Ogle
3c3e72e36d Update follow symlinks setting description 2014-12-19 17:14:30 -08:00
Ben Ogle
e0741d2073 Merge pull request #4689 from ebayer/follow-symlinks
Create a global option to follow symlinks in project-wide search
2014-12-19 17:12:03 -08:00
Ben Ogle
20504fc7a8 Pull load settings out of the focused window 2014-12-19 10:38:03 -08:00
Ben Ogle
0db1971825 Default devMode and safeMode to false 2014-12-19 10:38:03 -08:00
Ben Ogle
80c828d001 Pass the load settings through so all windows share devMode and safeMode 2014-12-19 10:38:03 -08:00
Ben Ogle
e688df57f2 Add atom.inSafeMode() 2014-12-19 10:38:03 -08:00
Kevin Sawicki
12d4fae91c Fall back to system root for cmd.exe path 2014-12-18 17:58:18 -08:00
Kevin Sawicki
2f334979d5 Add explorer check using SystemRoot path
Closes #4551
2014-12-18 17:20:40 -08:00
Kevin Sawicki
f5ae96820a Update spec for new middle mouse paste behavior 2014-12-18 11:04:52 -08:00
Kevin Sawicki
435fee1433 Use skinny arrow 2014-12-18 10:40:44 -08:00
Kevin Sawicki
c96f976162 Write to selection clipboard from setTimeout
This is so that in progress transactions aren't written to the
selection clipboard.
2014-12-18 10:40:04 -08:00
Kevin Sawicki
5115540f8e Track middle button mouse down events on Linux 2014-12-18 09:51:32 -08:00
Kevin Sawicki
d642553351 Paste selection clipboard after finalizing selections 2014-12-18 09:26:14 -08:00
Erdem Bayer
a0038b6f56 Create a global option to follow symlinks in project-wide search
Fixes https://github.com/atom/find-and-replace/issues/271
2014-12-18 17:23:23 +02:00
Max Brunsfeld
b0501c9cb2 Merge pull request #4672 from atom/mb-optimize-config-events
Avoid firing repeated config events while packages are loaded
2014-12-17 18:11:33 -08:00
Max Brunsfeld
28ac51d140 Add Config::transact
Use this method to avoid emitting unecessary config events
when activating or deactivating multiple packages
2014-12-17 16:54:47 -08:00
Max Brunsfeld
b0731afd4c Don't pass keyPath to Config::onDidChange callback
The keyPath field was never used by core or any package, and
for scoped settings, its value was always equal to the keyPath
specified by the caller.
2014-12-17 12:03:46 -08:00
Kevin Sawicki
1c81aa90c0 Add initial SquirrelUpdate specs 2014-12-17 10:47:43 -08:00
Kevin Sawicki
bbf6930061 💄 2014-12-17 10:02:34 -08:00
Kevin Sawicki
3d149eb9d1 Only update desktop shortcut if it already exists
Delete the created shortcut if it was previously deleted
after it was first installed.

Closes #4665
2014-12-17 09:55:46 -08:00
Max Brunsfeld
dc2a453986 Revert "Merge pull request #4631 from atom/mb-new-config-api"
This reverts commit 5147fb6a8b, reversing
changes made to 9bbbb58084.
2014-12-16 15:27:39 -08:00
Kevin Sawicki
fdd55dfd27 Restart Atom with project path from focused window
Closes #4653
2014-12-16 15:26:42 -08:00
Max Brunsfeld
5147fb6a8b Merge pull request #4631 from atom/mb-new-config-api
New config API
2014-12-16 15:22:15 -08:00
Ben Ogle
509976fa18 Merge pull request #4655 from atom/bo-fix-dragging
Handle the case when the editor is destroyed while dragging
2014-12-16 15:05:58 -08:00
Ben Ogle
aad5700418 Merge pull request #4652 from atom/bo-fix-unmount
Properly unmount the component when the shadow DOM is enabled
2014-12-16 14:52:37 -08:00
Ben Ogle
09a0773043 Handle editor destruction when dragging.
Closes #4622
2014-12-16 14:52:07 -08:00
Ben Ogle
0829da53b0 Properly unmount the component when the shadow DOM is enabled. 2014-12-16 14:36:51 -08:00
Kevin Sawicki
2ea92cf0e5 💄 2014-12-16 14:31:52 -08:00
Max Brunsfeld
9a2cc36c6b 💄 2014-12-16 14:27:57 -08:00
Max Brunsfeld
503fa30c28 Flesh out deprecation messages for Config::{is,set}Default
Also, simplify the shim in ::isDefault
2014-12-16 14:27:46 -08:00
Max Brunsfeld
b8f239cd39 Deprecate Config::isDefault and ::getDefault 2014-12-16 14:00:57 -08:00
Max Brunsfeld
231da60e13 📝 new config APIs 2014-12-16 14:00:57 -08:00
Max Brunsfeld
a47719eb53 Fix config priorities 2014-12-16 14:00:57 -08:00
Max Brunsfeld
9f851e55d1 Add Config::unset
Deprecate Config::restoreDefault
2014-12-16 14:00:57 -08:00
Max Brunsfeld
ab89776f01 Throw when Config::set is called w/ source and no scope 2014-12-16 14:00:57 -08:00
Max Brunsfeld
2cea51b50e Take 'scope' option in Config::onDidChange
Deprecate passing the scope as an optional first argument
2014-12-16 14:00:57 -08:00
Max Brunsfeld
4e4794f3fd Take 'scope' option in Config::observe
Deprecate using the scope as an optional first argument
2014-12-16 14:00:57 -08:00
Max Brunsfeld
f859ad5fc5 Allow null keyPath with options argument in ::get 2014-12-16 14:00:56 -08:00
Nathan Sobo
c35fb90653 Don’t return schema defaults when sources are specified in Config::get 2014-12-16 14:00:56 -08:00
Nathan Sobo
73df017d83 Add a ‘sources’ and ‘excludeSources’ options to Config::get
If the option is supplied, we will only retrieve values from the
specified sources.
2014-12-16 14:00:56 -08:00