Nathan Sobo
a24816f76b
Handle null errors to support existing uses in tests
2015-06-20 18:37:54 +02:00
Nathan Sobo
64fca5db20
Absorb exception in isFoldableCodeAtRow and report assertion failure
...
Can’t figure out what’s going on in this bug, but we can hopefully make
it less damaging and collect more information via the new assertion
system.
Refs #5905
2015-06-20 18:37:53 +02:00
Nathan Sobo
11c3b3444b
Return a boolean from atom.assert
2015-06-20 18:37:53 +02:00
Nathan Sobo
a1f6a15c0b
Add atom.assert and atom.onDidFailAssertion
2015-06-20 18:37:53 +02:00
Nathan Sobo
cd35107f8c
Call atom.onDidThrowError handlers with the error object
...
…and remove a bunch of dead source maps handling. Source map handling
for stack traces is now built into Chromium so it shouldn’t be needed
here.
Original event properties maintained for backward compatibility with the
1.0 API. Can be deprecated for 2.0 once we transition
exception-reporter.
2015-06-20 18:37:53 +02:00
Max Brunsfeld
ca146c991a
Merge pull request #7341 from atom/as-remove-orphaned-gutter-events
...
Remove event listeners from orphaned gutters
2015-06-19 10:52:17 -07:00
Kevin Sawicki
bde74dee0b
Merge pull request #7281 from atom/sm-default-editor-font
...
New default editor font
2015-06-19 09:12:18 -07:00
simurai
533abc5a63
Increase default line height even a bit more
2015-06-19 21:31:36 +09:00
Antonio Scandurra
d7156ff387
Remove event listeners from orphaned gutters
2015-06-19 10:24:48 +02:00
Antonio Scandurra
26b1d166fd
Merge pull request #7320 from atom/as-remove-gutter-from-view-registry
...
Fix TextEditorComponent Race Condition
2015-06-19 09:01:59 +02:00
simurai
2017e3fe23
Increase default line height
2015-06-19 10:22:26 +09:00
Antonio Scandurra
c8f24d2358
Revert " 🐛 Remove Gutter from ViewRegistry"
...
This reverts commit b0d93accf7
2015-06-18 19:54:37 +02:00
Max Brunsfeld
64dfda572d
Use raw buffer text (w/o invisibles) when testing decreaseIndentRegex
2015-06-17 12:07:42 -07:00
Max Brunsfeld
3cdeaa8b51
Don't auto-indent when pasting text w/ no line breaks
2015-06-17 10:57:21 -07:00
Antonio Scandurra
b04b0a8dc4
🐛 Fix race condition as well
2015-06-17 13:48:31 +02:00
Antonio Scandurra
b0d93accf7
🐛 Remove Gutter from ViewRegistry
...
Closes #7306
We started noticing that when a `TextEditor` pane got split, the same view for
`Gutter` was being shared amongst several models, thereby making the same DOM
element accessible simultaneously by more than one object. This made us
experience *orphaned line numbers*, caused by two instances of
`LineNumberGutterComponent` mutating `.line-numbers` at the same time.
This is a typical race condition which I would normally address by understanding
and possibly locking the correct order in which operations should happen.
However, I believe in this situation we shouldn’t actually care about ordering
at all, since I think views should be kept “local”, thus avoiding to expose them
to the world and/or reusing them across other views (either accidentally as in
this case or on purpose).
2015-06-17 12:28:10 +02:00
Max Brunsfeld
dbb1200e1b
🔥 unused method
2015-06-16 14:54:01 -07:00
aki
449c03cb35
Fix destroy listeners
2015-06-16 18:05:45 +09:00
Max Brunsfeld
41773b0861
Fix incorrect state save when exiting
2015-06-15 14:14:08 -07:00
simurai
e4ba689e40
Replaces default editor font
...
Only affects OS X
2015-06-15 16:03:50 +09:00
Max Brunsfeld
715238c3cd
Add by clauses to for loops to avoid complex loop increments
2015-06-12 16:38:07 -07:00
Max Brunsfeld
6282e7e533
Merge pull request #7234 from atom/mb-keep-state-when-auto-updating
...
Avoid saving state when closing windows due to auto-update
2015-06-12 10:50:57 -07:00
Max Brunsfeld
c43233892b
Merge pull request #7225 from lpommers/add-remove-cursor-when-there-are-multiple-cursors-if-cmd-clicking-on-it
...
Add remove cursor when there are multiple cursors and cmd clicking on it
2015-06-12 10:41:17 -07:00
Luke Pommersheim
9f0f4c0530
refactor getCursorAtScreenPosition to avoid temporary array
2015-06-12 08:38:25 +02:00
Luke Pommersheim
3b3dc83a38
📝 updating docs for getCursorAtScreenPosition - can also take an {Array}
2015-06-12 08:36:44 +02:00
Max Brunsfeld
e47221bc3f
Never save window state in the middle of quitting
2015-06-11 17:24:12 -07:00
Kevin Sawicki
7a6a48d7ea
Move getSaveDialogOptions near other save methods
2015-06-11 15:31:43 -07:00
Kevin Sawicki
a0778217df
Merge pull request #7145 from FoldingText/Item-provides-save-panel-options
...
Item provides save panel options
2015-06-11 15:28:24 -07:00
Kevin Sawicki
48bf4203e1
Merge pull request #7237 from ssorallen/git-repository-docs
...
Add missing docs for GitRepository
2015-06-11 15:22:47 -07:00
Nicklas Gummesson
51dcc84fce
Bind core:cut to native action
...
Using same pattern as the others
2015-06-11 23:10:26 +02:00
Ross Allen
51016550c3
Add missing docs for GitRepository
...
Add argument and return type docs to fill in the documentation site.
2015-06-11 13:45:06 -07:00
Max Brunsfeld
844cfcb7ae
Avoid saving state when closing windows due to auto-update
2015-06-11 12:51:36 -07:00
Luke Pommersheim
c67f98febb
if there are multiple cursors and you click a cursor, it is removed, otherwise new cursor is added. Cannot remove if there is only one cursor and you click on it
2015-06-11 13:26:09 +02:00
Luke Pommersheim
5822eb11f1
function that returns the first matched Cursor at a given screen position Point if it exists in that location
2015-06-11 13:02:14 +02:00
herkyl
b3687265bb
Fixed 'setBufferRange' documentation parameter name
2015-06-11 10:37:38 +03:00
Kevin Sawicki
0edce07446
Use folder name when metadata name is empty string or non-string
2015-06-10 16:46:35 -07:00
Kevin Sawicki
4d76e607f0
Use dirname for forwarding atom/apm commands
...
Refs #7141
2015-06-10 16:30:54 -07:00
Max Brunsfeld
48ca93261f
Merge pull request #7219 from atom/bf-revert-the-revert-of-pr-7022
...
Re-introduce atom.directory-searcher service v0.1.0.
2015-06-10 15:51:19 -07:00
Kevin Sawicki
3b6015954b
Merge pull request #7176 from atom/mq-package-name-metadata
...
Only use package directory name as fallback
2015-06-10 15:38:31 -07:00
Michael Bolin
ad46b37cfe
In workspace-spec.coffee, updated FakeSearch to match the spec, which
...
helped uncover a bug.
2015-06-10 23:30:42 +01:00
Michael Bolin
3c44bc06f4
Revert "Revert "Introduce atom.directory-searcher service v0.1.0.""
...
This reverts commit 262d41c306
2015-06-10 23:30:25 +01:00
Kevin Sawicki
c3953dbbd4
Don't focus when opening locations
2015-06-10 09:27:20 -07:00
Kevin Sawicki
7d7b2375e1
Focus right after showing
2015-06-10 09:27:20 -07:00
Max Brunsfeld
6bccfcd0a3
Guard for atom windows w/ no webContents
2015-06-09 16:45:27 -07:00
Max Brunsfeld
f2851ac11d
Merge pull request #7192 from atom/as-fix-empty-partially-off-screen-markers
...
Delete partially off-screen markers which are empty
2015-06-09 15:04:52 -07:00
Antonio Scandurra
f73435e053
🐛 Delete partially off-screen markers which are empty
...
* 🔥 Delete old code which was used to support some non-batched
methods in a previous version;
* ✅ Cover “partially off-screen markers which are
empty” scenario, since that code path was not hit by previous specs
Fixes #7183
2015-06-09 21:35:01 +02:00
Max Brunsfeld
262d41c306
Revert "Introduce atom.directory-searcher service v0.1.0."
2015-06-09 11:51:30 -07:00
Max Brunsfeld
f830623512
Merge pull request #7022 from atom/bf-directory-searcher
...
Introduce atom.directory-searcher service v0.1.0.
2015-06-09 09:40:06 -07:00
Kevin Sawicki
fb48b38aa7
Guard against no resizing with no siblings
...
Closes #7091
2015-06-09 09:36:58 -07:00
Michael Bolin
535c0e2f34
Fix documentation bug.
2015-06-09 15:34:10 +01:00
