Nathan Sobo
a264eaa18a
Serialize TextEditor autoHeight and autoWidth properties
2016-08-18 14:03:44 -06:00
Nathan Sobo
dd82902bf2
Disable autoHeight on text editor pane items
2016-08-18 14:03:44 -06:00
Nathan Sobo
f723bccc29
Add test coverage for deprecated implicit disabling of autoHeight
2016-08-18 14:03:44 -06:00
Nathan Sobo
9f8f03b10f
Add test coverage for TextEditor autoHeight
2016-08-18 13:45:00 -06:00
Nathan Sobo
7a49013057
Only create a single deprecation warning per editor and improve message
2016-08-17 16:58:17 -06:00
Nathan Sobo
67313aec8d
Default editor height to 100%
...
Previously, when autoHeight was assigned to false on the editor, we would assign an inline style of height: 100%. This preserves the essence of that behavior without prohibiting users from assigning their own height via more specific CSS rules.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2016-08-17 16:14:04 -06:00
Nathan Sobo
6a0b4d8fc0
Default autoWidth in getter method to match autoHeight
2016-08-17 15:52:51 -06:00
Nathan Sobo
13c00995d4
Return default value of true from TextEditor.getAutoHeight
...
When we need to check for unassigned in the deprecated code path, we
can just read the instance variable directly to avoid getting the
deafult.
Signed-off-by: Antonio Scandurra <as-cii@github.com >
2016-08-17 15:52:51 -06:00
Nathan Sobo
106621e161
Deprecate automatic assignment of autoHeight for text editors
...
Previously, we attempted to automatically determine whether the editor’s
height should be based on the editor’s content or the height of its
container. Unfortunately, DOM APIs are insufficient to make this
determination in a complete way, leading to unpredictable behavior.
This PR deprecates the automatic determination of this behavior. By
default, editors base their height on their content. If an editor has
an explicit height assigned via its style or is positioned absolute with
an explicit top and bottom, we disable the content-based autoHeight and
log a deprecation warning telling the user to assign autoHeight
explicitly.
This paves the way to add an autoWidth setting, which will default to
false.
2016-08-17 15:52:51 -06:00
Nathan Sobo
351bad432b
Merge pull request #12448 from atom/as-editor-auto-width
...
Introduce autoWidth for TextEditors
2016-08-17 12:55:54 -06:00
Antonio Scandurra
1587dcbe89
Take the gutter width into account when sizing TextEditorElement
2016-08-17 19:21:56 +02:00
Antonio Scandurra
c37138e09e
Revert refactoring to make the diff shorter
2016-08-17 18:08:02 +02:00
Antonio Scandurra
3642292302
🔥 debugger
2016-08-17 18:05:58 +02:00
Antonio Scandurra
6f0fd965cd
Clear out width on TextEditorElement only if autoWidth was previously on
2016-08-17 18:05:16 +02:00
Antonio Scandurra
e71027ed36
Ensure editors don't scroll or show scrollbars when autoWidth is enabled
2016-08-17 17:58:36 +02:00
Antonio Scandurra
5b44b51150
🎨 Clarify naming
2016-08-17 17:20:24 +02:00
Antonio Scandurra
e8f2e3a608
Size TextEditorElement according to the autoWidth property
2016-08-17 16:20:00 +02:00
Antonio Scandurra
2e37d7f0cf
Change state.content.width based on autoWidth
2016-08-17 16:14:57 +02:00
Antonio Scandurra
683bf37907
Add autoWidth to TextEditor
2016-08-17 16:14:36 +02:00
Max Brunsfeld
f376316d60
Merge pull request #12125 from atom/ns-mb-detangle-editor
...
Remove some of the TextEditor class's Atom-specific dependencies
2016-08-16 12:07:42 -07:00
Max Brunsfeld
c5a6e9c697
Merge branch 'master' into ns-mb-detangle-editor
2016-08-16 09:11:11 -07:00
Max Brunsfeld
782b070964
Use es6 export in null-grammar.js
2016-08-16 09:03:50 -07:00
Antonio Scandurra
2b3adaeace
Merge pull request #12393 from atom/as-remove-backup-before-saving
...
Remove config option `editor.backUpBeforeSaving`
2016-08-16 13:29:59 +02:00
Max Brunsfeld
2fa48a13e4
Merge pull request #12434 from atom/mb-atom-home-from-shell-child-process
...
Allow ATOM_HOME to be reassigned if the new value is valid
2016-08-15 17:50:19 -07:00
Max Brunsfeld
8702b4ca47
Remove 'Some textSome textSome textSome text'
2016-08-15 17:12:40 -07:00
Max Brunsfeld
8018dc9d57
Allow ATOM_HOME to be reassigned if the new value is valid
2016-08-15 17:05:18 -07:00
Max Brunsfeld
4b0183d074
Remove extraneous TextEditor setter methods
2016-08-15 16:45:10 -07:00
Max Brunsfeld
0d099d2fd5
Serialize all TextEditor parameters needed for the DisplayLayer
2016-08-15 15:51:22 -07:00
Max Brunsfeld
4bcdbf4d2f
Don't have registry update any editors before initial packages are loaded
2016-08-15 15:29:27 -07:00
Max Brunsfeld
1c99c399d1
Merge branch 'master' into ns-mb-detangle-editor
2016-08-15 11:17:07 -07:00
simurai
4fe20fdde5
⬆️ image-view@v0.58.3
2016-08-14 20:26:35 +02:00
Nathan Sobo
66d66508c1
Fight the screen saver on CircleCI
2016-08-13 13:12:23 -06:00
Damien Guard
d47fd28c86
Focus new window when existing copy of Atom running fixes #4324
2016-08-12 17:45:24 -07:00
Nathan Sobo
274dee20dd
Merge pull request #12409 from atom/ns-mock-animation-frames-in-editor-spec
...
Mock clock and animation frames in TextEditorComponent specs
2016-08-12 16:35:05 -06:00
Nathan Sobo
ebb03f022b
Merge branch 'master' into ns-mock-animation-frames-in-editor-spec
2016-08-12 16:16:09 -06:00
Max Brunsfeld
bf644d1a6b
Remove some unnecessary TextEditor accessor methods
2016-08-12 14:31:07 -07:00
Nathan Sobo
ced2174b5a
Mock clock and animation frames in TextEditorComponent specs
2016-08-12 15:21:46 -06:00
Max Brunsfeld
94808303e5
Fix spec for preserving custom grammars when panes are split
2016-08-12 14:11:20 -07:00
Max Brunsfeld
a11a235ef1
Don't reset display layer twice in TextEditor constructor
2016-08-12 13:36:50 -07:00
Nathan Sobo
2710ce33d1
Merge pull request #12394 from atom/ns-as-switch-offset-test-to-mocha
...
Replace ChromeDriver integration tests main process Mocha tests
2016-08-12 14:17:16 -06:00
Nathan Sobo
b6ab5530b5
Fix focus issues on CircleCI
2016-08-12 13:35:08 -06:00
Max Brunsfeld
09d232ba41
Introduce TextEditorRegistry::build
...
This way, we can construct text editors with the right parameters from the start
2016-08-12 12:21:51 -07:00
Max Brunsfeld
65f385c0a4
Don't reset editor's display layer when setting identical invisibles
2016-08-12 12:21:03 -07:00
Wliu
f68009cce0
Merge pull request #12404 from nirajk42/split-pane-menu-bug
...
#12386 Splitting panes using the menu gives me an empty panel
2016-08-12 14:13:47 -04:00
Nathan Sobo
41a49eaf44
Restore all suites in spec-task.coffee
...
Signed-off-by: Antonio Scandurra <as-cii@github.com >
2016-08-12 12:08:45 -06:00
Nathan Sobo
c861abc2a9
Fix timing issues in atom-application-test
...
Signed-off-by: Antonio Scandurra <as-cii@github.com >
2016-08-12 11:46:12 -06:00
Antonio Scandurra
e02863e86e
Destroy AtomEnvironment on window unload
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-08-12 18:15:51 +02:00
Antonio Scandurra
7e7f7722e6
Run only main process specs for now
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-08-12 17:47:34 +02:00
Antonio Scandurra
9847c4fc24
Wait until the window is focused before interacting with it in tests
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-08-12 17:46:13 +02:00
Antonio Scandurra
87d684132c
Extract timeoutPromise into async-spec-helpers
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-08-12 17:46:12 +02:00
