Nathan Sobo
dd82902bf2
Disable autoHeight on text editor pane items
2016-08-18 14:03:44 -06:00
Nathan Sobo
f723bccc29
Add test coverage for deprecated implicit disabling of autoHeight
2016-08-18 14:03:44 -06:00
Nathan Sobo
9f8f03b10f
Add test coverage for TextEditor autoHeight
2016-08-18 13:45:00 -06:00
Nathan Sobo
13c00995d4
Return default value of true from TextEditor.getAutoHeight
...
When we need to check for unassigned in the deprecated code path, we
can just read the instance variable directly to avoid getting the
deafult.
Signed-off-by: Antonio Scandurra <as-cii@github.com >
2016-08-17 15:52:51 -06:00
Nathan Sobo
106621e161
Deprecate automatic assignment of autoHeight for text editors
...
Previously, we attempted to automatically determine whether the editor’s
height should be based on the editor’s content or the height of its
container. Unfortunately, DOM APIs are insufficient to make this
determination in a complete way, leading to unpredictable behavior.
This PR deprecates the automatic determination of this behavior. By
default, editors base their height on their content. If an editor has
an explicit height assigned via its style or is positioned absolute with
an explicit top and bottom, we disable the content-based autoHeight and
log a deprecation warning telling the user to assign autoHeight
explicitly.
This paves the way to add an autoWidth setting, which will default to
false.
2016-08-17 15:52:51 -06:00
Antonio Scandurra
1587dcbe89
Take the gutter width into account when sizing TextEditorElement
2016-08-17 19:21:56 +02:00
Antonio Scandurra
3642292302
🔥 debugger
2016-08-17 18:05:58 +02:00
Antonio Scandurra
e71027ed36
Ensure editors don't scroll or show scrollbars when autoWidth is enabled
2016-08-17 17:58:36 +02:00
Antonio Scandurra
e8f2e3a608
Size TextEditorElement according to the autoWidth property
2016-08-17 16:20:00 +02:00
Antonio Scandurra
2e37d7f0cf
Change state.content.width based on autoWidth
2016-08-17 16:14:57 +02:00
Antonio Scandurra
683bf37907
Add autoWidth to TextEditor
2016-08-17 16:14:36 +02:00
Max Brunsfeld
c5a6e9c697
Merge branch 'master' into ns-mb-detangle-editor
2016-08-16 09:11:11 -07:00
Max Brunsfeld
8702b4ca47
Remove 'Some textSome textSome textSome text'
2016-08-15 17:12:40 -07:00
Max Brunsfeld
8018dc9d57
Allow ATOM_HOME to be reassigned if the new value is valid
2016-08-15 17:05:18 -07:00
Max Brunsfeld
4b0183d074
Remove extraneous TextEditor setter methods
2016-08-15 16:45:10 -07:00
Max Brunsfeld
0d099d2fd5
Serialize all TextEditor parameters needed for the DisplayLayer
2016-08-15 15:51:22 -07:00
Max Brunsfeld
4bcdbf4d2f
Don't have registry update any editors before initial packages are loaded
2016-08-15 15:29:27 -07:00
Max Brunsfeld
1c99c399d1
Merge branch 'master' into ns-mb-detangle-editor
2016-08-15 11:17:07 -07:00
Nathan Sobo
ebb03f022b
Merge branch 'master' into ns-mock-animation-frames-in-editor-spec
2016-08-12 16:16:09 -06:00
Max Brunsfeld
bf644d1a6b
Remove some unnecessary TextEditor accessor methods
2016-08-12 14:31:07 -07:00
Nathan Sobo
ced2174b5a
Mock clock and animation frames in TextEditorComponent specs
2016-08-12 15:21:46 -06:00
Max Brunsfeld
94808303e5
Fix spec for preserving custom grammars when panes are split
2016-08-12 14:11:20 -07:00
Max Brunsfeld
a11a235ef1
Don't reset display layer twice in TextEditor constructor
2016-08-12 13:36:50 -07:00
Nathan Sobo
2710ce33d1
Merge pull request #12394 from atom/ns-as-switch-offset-test-to-mocha
...
Replace ChromeDriver integration tests main process Mocha tests
2016-08-12 14:17:16 -06:00
Nathan Sobo
b6ab5530b5
Fix focus issues on CircleCI
2016-08-12 13:35:08 -06:00
Max Brunsfeld
09d232ba41
Introduce TextEditorRegistry::build
...
This way, we can construct text editors with the right parameters from the start
2016-08-12 12:21:51 -07:00
Nathan Sobo
c861abc2a9
Fix timing issues in atom-application-test
...
Signed-off-by: Antonio Scandurra <as-cii@github.com >
2016-08-12 11:46:12 -06:00
Antonio Scandurra
9847c4fc24
Wait until the window is focused before interacting with it in tests
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-08-12 17:46:13 +02:00
Antonio Scandurra
87d684132c
Extract timeoutPromise into async-spec-helpers
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-08-12 17:46:12 +02:00
Antonio Scandurra
82f0003302
Extract conditionPromise into async-spec-helpers
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-08-12 17:46:11 +02:00
Antonio Scandurra
ab3d0ba412
Rewrite async-spec-helpers in javascript
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-08-12 17:46:09 +02:00
Antonio Scandurra
4bd644bea2
Bump timeout to 1 minute on AtomApplication tests
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-08-12 17:45:59 +02:00
Antonio Scandurra
336f6425da
Discourage people from using temp directly
...
It's better if we fs.realpathSync the path returned by the temp module.
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-08-12 17:45:56 +02:00
Antonio Scandurra
04d8b9bb86
Ensure we don't reuse the same window when testing the offset distance
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-08-12 17:45:50 +02:00
Antonio Scandurra
753db274fc
Clear storage data after each AtomApplication test
...
This, along with using a temporary directory as the ATOM_HOME, will make
sure that tests won't share any state with one another, possibly
increasing the level of resiliency of the suite.
2016-08-12 15:20:58 +02:00
Antonio Scandurra
a817a354dc
Use project paths instead of tree view directories to test remote paths
2016-08-12 14:35:40 +02:00
Antonio Scandurra
fe8aabd908
Use spec reporter to know which specs hang
2016-08-12 12:22:36 +02:00
Antonio Scandurra
428106bcaa
Add smoke test to ensure Atom runs and basic operations can be performed
2016-08-12 11:46:48 +02:00
Antonio Scandurra
7fe0f6b455
Move another integration test
2016-08-12 11:29:34 +02:00
Antonio Scandurra
da7b951c07
Move another integration test
2016-08-12 11:22:32 +02:00
Antonio Scandurra
02bc4282d0
Move another integration test
2016-08-12 10:58:59 +02:00
Antonio Scandurra
fff2ecd162
Extract a AtomApplication.prototype.launch method
...
...so that we can exercise loading previously opened windows stored
state after the application is restarted. In addition, this resembles
more what we run in production, and therefore allows us to have a better
coverage of the code paths we run in the real application.
2016-08-12 10:44:09 +02:00
Antonio Scandurra
e8c7b27af4
Move another integration test
2016-08-12 10:10:20 +02:00
Max Brunsfeld
0a1834079f
Rename getSoftWrapIndentLength -> getSoftWrapHangingIndentLength
2016-08-11 16:38:34 -07:00
Joe Fitzgerald
f529ebb237
🎨 Update Describe / It Descriptions
2016-08-11 17:08:28 -06:00
Joe Fitzgerald
485cb71be7
🎨 envShouldBePatched > shouldGetEnvFromShell
2016-08-11 17:07:21 -06:00
Joe Fitzgerald
9ec63a8ffc
🎨 Cleanup
...
* shellShouldBePatched > envShouldBePatched
2016-08-11 16:45:19 -06:00
Nathan Sobo
3d99cde9e1
Move another integration spec to the main process tests
2016-08-11 16:43:26 -06:00
Max Brunsfeld
684952458f
Remove new TextEditor setters; just use update
2016-08-11 15:34:54 -07:00
Nathan Sobo
a29db76073
Move another integration test
2016-08-11 16:33:36 -06:00
