Nathan Sobo
1825af1309
Merge pull request #1415 from atom/ns-pane-model-specs
...
Move relevant pane specs from PaneView to Pane model
2014-01-15 15:06:43 -08:00
Nathan Sobo
b5947f5a56
Merge branch 'master' into ns-pane-model-specs
2014-01-15 15:54:49 -07:00
probablycorey
ac07cf3d9a
Merge remote-tracking branch 'origin/master' into cj-remove-editor-view-delegate-methods
...
Conflicts:
package.json
2014-01-15 13:52:42 -08:00
Nathan Sobo
d57e5f389d
Don't null out the model of a pane item view when removing it
...
Fixes #1422 (I think)
2014-01-15 14:20:30 -07:00
Nathan Sobo
dd0ae8a8ea
Don't remove PaneViews when their model is destroyed
...
They will be removed by their parent PaneContainerView or PaneAxisView,
and removing them in the previous way circumvented some of our focus
preservation logic.
2014-01-14 20:09:14 -07:00
Nathan Sobo
c0c2d797b1
Add some API documentation
2014-01-14 14:44:27 -07:00
Nathan Sobo
c350285044
Move Workspace and PaneContainer serialization to the model layer
...
The views are now stateless. You just construct them with a model to
deserialize.
2014-01-14 11:38:27 -07:00
Nathan Sobo
4a7b43f609
Write focusNext/PreviousPane in terms of activateNext/PreviousPane
...
"Activate" is the model level equivalent of focus.
2014-01-14 11:15:14 -07:00
Nathan Sobo
0d66c68fe8
Add delegator to model for PaneContainerView::saveAll
2014-01-14 11:12:08 -07:00
Nathan Sobo
a1d540d288
Revert WorkspaceView::getActivePane. It needs to return a PaneView.
2014-01-14 11:02:36 -07:00
Nathan Sobo
af4034ba39
Move WorkspaceView::destroyActivePaneItem to the model
2014-01-14 10:58:35 -07:00
Nathan Sobo
89cbd6b834
Move PaneContainerView::saveAll to the model
2014-01-14 10:58:35 -07:00
Nathan Sobo
fe01ded75b
Move WorkspaceView::saveActivePaneItem* to Workspace model
2014-01-14 10:58:35 -07:00
Nathan Sobo
aab4f3b761
Remove methods that I'm pretty sure are unused
2014-01-14 10:58:35 -07:00
Nathan Sobo
adf5cfc78c
Move WorkspaceView::reopenItemSync to the Workspace model
2014-01-14 10:58:34 -07:00
Nathan Sobo
66bb9dab93
Move WorkspaceView::openSingletonSync to the Workspace model
2014-01-14 10:58:34 -07:00
Nathan Sobo
c8e4535e8b
Move WorkspaceView::openSync to the Workspace model
2014-01-14 10:58:34 -07:00
Nathan Sobo
7199cda549
Derive PaneView::activeView from the model's activeItem
...
We're getting into some strange order-sensitive cases where we respond
to a change of the active item before the pane has a chance to reassign
the active view. Therefore it makes more sense to always just derive the
active view from the active item.
2014-01-14 10:58:34 -07:00
Nathan Sobo
1eb9c3d0d5
Move WorkspaceView::open to Workspace model
2014-01-14 10:58:34 -07:00
Nathan Sobo
27c03ae3f3
Move management of destroyedItemUris to Workspace model
2014-01-14 10:58:34 -07:00
Nathan Sobo
a8ddc530a2
Emit a pane-item-destroyed event from the workspace model
...
…Instead of calling itemDestroyed on the workspace view via a DOM query
2014-01-14 10:58:34 -07:00
Nathan Sobo
8e78583521
Emit 'item-destroyed' in ::removeItem when destroying flag is true
2014-01-14 10:58:34 -07:00
Nathan Sobo
7317d52896
Move paneForUri to PaneContainer model
2014-01-14 10:58:34 -07:00
Nathan Sobo
54dd5ea28e
Destroy the model when PaneContainerView is removed
2014-01-14 10:58:34 -07:00
Nathan Sobo
22fe04fb27
Drop out a basic workspace model
2014-01-14 10:58:33 -07:00
Nathan Sobo
adb174ef5f
Remove pane-model, which should have been removed during rename
...
Missed this somehow.
2014-01-14 10:57:50 -07:00
Nathan Sobo
159adcb00c
Bump serialization version on WorkspaceView
...
Since we've replaced views with models, the 'PaneContainer' deserializer
now loads a model instead of a view, which isn't what we want at this
layer.
2014-01-13 16:57:17 -07:00
probablycorey
95f2d02d18
Merge branch 'master' into cj-remove-editor-view-delegate-methods
...
Conflicts:
package.json
spec/workspace-view-spec.coffee
src/editor.coffee
src/gutter.coffee
2014-01-13 15:06:18 -08:00
Nathan Sobo
08716fd888
Merge pull request #1410 from atom/ns-rename-pane-views
...
Add -View suffix to pane views and remove -Model suffix from pane models
2014-01-13 13:39:13 -08:00
Kevin Sawicki
16c86047eb
Add buffer delegates for getLineCount/getTextInRange
2014-01-13 13:30:32 -08:00
Nathan Sobo
97999f1080
Rename PaneContainerModel to PaneContainer
2014-01-13 13:56:31 -07:00
Nathan Sobo
a268b3e963
Rename PaneAxisModel to PaneAxis
2014-01-13 13:54:04 -07:00
Nathan Sobo
8931bf8f3a
Rename PaneModel to Pane
2014-01-13 13:51:15 -07:00
Nathan Sobo
918c31905f
Rename PaneContainer to PaneContainerView
2014-01-13 13:46:28 -07:00
Nathan Sobo
c7ff4f9897
Rename PaneAxis to PaneAxisView
2014-01-13 13:46:27 -07:00
Nathan Sobo
4f604ced3c
Rename Pane to PaneView
2014-01-13 13:46:22 -07:00
Nathan Sobo
fe0cdbf349
Merge remote-tracking branch 'origin/master' into cj-ns-pane-models
...
Conflicts:
package.json
2014-01-13 12:55:02 -07:00
Nathan Sobo
4179d9d268
Add deprecated Pane::removeItem
2014-01-12 17:55:29 -07:00
Nathan Sobo
3fc3d48def
Destroy empty panes after deserializing
...
Fixes #1399
2014-01-12 17:53:25 -07:00
Nathan Sobo
b438b311f3
Rename showItem methods to activateItem
...
These methods set the *active* item, so the verb activate provides a
clearer correspondence. We could change the noun to "shown" item, but
that's awkward and having both active panes and active items is a nice
correspondence in terminology.
2014-01-12 17:40:57 -07:00
Nathan Sobo
561e31c0c5
Remove ::removeItemAtIndex and make ::removeItem private
...
Call ::destroyItem or just destroy the item directly (it should emit the
'destroyed' event)
2014-01-12 17:25:51 -07:00
Nathan Sobo
2a8a5268c6
Clean up PaneModel api docs
2014-01-11 22:09:10 -07:00
Nathan Sobo
28b085be1c
Rename ::makeActive to ::activate and focus panes when they're activated
2014-01-11 20:48:01 -07:00
Nathan Sobo
f5bc71e559
Move $.fn.hasFocus to space-pen
2014-01-11 19:49:25 -07:00
Nathan Sobo
b21eb6f934
Drop .flexbox-repaint-hack div and use pseudo selector instead
...
We don't actually need structural markup to ensure that all pane views
are absolutely positioned. We can just use the `> *` selector inside of
.pane-items.
/cc @probablycorey is there anything I'm missing here?
2014-01-11 19:13:00 -07:00
Kevin Sawicki
3c32a8e8fb
Throw error when sending to terminated process
...
Mirrors behavior of start method
2014-01-11 17:23:53 -08:00
Nathan Sobo
3ab7836ab2
Upgrade to emissary 0.31.0 for implicit 'value' subscriptions on signals
...
Previously, when you always had to specify the event name of 'value'
when calling `::subscribe` with a signal. Now, if you don't specify an
event name, 'value' is assumed.
2014-01-11 11:22:31 -07:00
Nathan Sobo
ef8b7531b0
Upgrade to theorist 0.13.0 to rename Signal::flatMapLatest -> ::switch
...
Shorter, simpler, less intimidating.
2014-01-11 11:19:19 -07:00
Nathan Sobo
b04f9f9488
Remove unused methods from PaneAxis
2014-01-11 11:11:04 -07:00
Nathan Sobo
e2170ea907
Remove unused requires and mixins
2014-01-11 10:45:33 -07:00