Commit Graph

19642 Commits

Author SHA1 Message Date
Nathan Sobo
b6b6b6d12b Add ‘mini’ attribute to TextEditorElement if .isMini() is true on model 2014-11-13 16:04:57 -08:00
Nathan Sobo
9f194ff4df Create an empty TextBuffer if needed in TextEditor constructor 2014-11-13 16:04:57 -08:00
Nathan Sobo
ed6ca9cd06 Remove .editor class to force themes to style background via :host
The goal is to allow the editor’s styling to be overridden as follows:

atom-text-editor {
  background: black;
  color: white;
}

If we retain these classes, themes will continue to style the root
element of the editor and destroy the ability to style the editor in
this way. You would instead have to do the following:

atom-text-editor::shadow .editor {
  background: black;
  color: white;
}

This is way less intuitive and confusing for people.
2014-11-13 16:04:57 -08:00
Nathan Sobo
08971562cd Store useShadowDOM setting when TextEditorElement is created
Rather than reading it repeatedly, since the value could potentially
change over time.
2014-11-13 16:04:56 -08:00
Nathan Sobo
263ff21cc1 Clean up shadow-DOM-specific text editor style sheet 2014-11-13 16:04:24 -08:00
Nathan Sobo
99b08826dd Style non-shadow DOM editor with it’s own style sheet
Trying to style both modes of the text editor with the same style sheet
is proving to be more trouble than it’s worth. This prepares the shadow
DOM style sheet to diverge more radically to enable the background color
to be overridden from the outside more easily.
2014-11-13 16:04:24 -08:00
Ben Ogle
417e00b938 Upgrade find and replace to 0.147.0 2014-11-13 16:00:32 -08:00
Kevin Sawicki
f8bb40c48f Merge pull request #4170 from atom/ks-use-grunt-installer-plugin
Use Grunt plugin to build Windows installer
2014-11-13 09:07:06 -08:00
Kevin Sawicki
01b75c4393 Use buildDir to build setup exe path 2014-11-13 08:46:25 -08:00
Kevin Sawicki
9f1ffeee25 Sign AtomSetup.exe 2014-11-13 08:46:25 -08:00
Kevin Sawicki
c55faac0a9 ⬆️ grunt-atom-shell-installer@0.6 2014-11-13 08:46:25 -08:00
Kevin Sawicki
aaa50bae90 ⬆️ grunt-atom-shell-installer@0.5 2014-11-13 08:46:25 -08:00
Kevin Sawicki
b0c4910815 Add community 2014-11-13 08:46:25 -08:00
Kevin Sawicki
654f84a26c Add authors 2014-11-13 08:46:25 -08:00
Kevin Sawicki
ff10ea601c Use root app dir 2014-11-13 08:46:24 -08:00
Kevin Sawicki
88bfba9fb2 ⬆️ grunt-atom-shell-installer@0.4 2014-11-13 08:46:24 -08:00
Kevin Sawicki
f11168df8e Load installer task 2014-11-13 08:46:24 -08:00
Kevin Sawicki
4ce056180c Remove installer code now handled by grunt plugin 2014-11-13 08:46:24 -08:00
Kevin Sawicki
8718828869 Add initial Windows installer task 2014-11-13 08:46:23 -08:00
Kevin Sawicki
edfcc134ec Add missing close import 2014-11-13 08:42:10 -08:00
Ben Ogle
6a34b88f79 Update wrap-guide to update when font-size is changed 2014-11-12 15:40:50 -08:00
Ben Ogle
e596bf6ef9 Merge pull request #4144 from atom/bo-overlay-decoration
Overlay decorations
2014-11-12 15:02:40 -08:00
Ben Ogle
b369a1085c Use headPixelPosition in overlay decoration rendering 2014-11-12 14:43:52 -08:00
Ben Ogle
2e7e90a8aa Update spec names 2014-11-12 14:43:26 -08:00
Ben Ogle
eae80ca46d Add a check for negative bounds when translating the overlay 2014-11-12 11:50:22 -08:00
Kevin Sawicki
fe7505745d Prepare 0.147 2014-11-12 10:55:14 -08:00
Max Brunsfeld
2ee3ab8577 Merge pull request #4162 from atom/mb-fix-copy-without-selection
Don't select the copied line when copying with no selection
v0.146.0
2014-11-12 10:25:38 -08:00
Max Brunsfeld
3521b96611 Don't select the copied line when copying with no selection 2014-11-12 10:12:26 -08:00
Kevin Sawicki
7abfd45baf Default to using hard tabs in Makefile files
This is a temporary solution until scoped settings supports this
type of restriction.

Closes atom/language-make#3
2014-11-12 09:31:12 -08:00
Ben Ogle
4141b456db Merge pull request #4157 from AgentAntelope/master
Make cmd-delete delete to end of line.
2014-11-12 09:14:50 -08:00
Agent Antelope
f86dc6b0a6 Revert change to cmd-shift-backspace 2014-11-12 17:09:42 +00:00
Agent Antelope
87be5af1ec Make cmd-delete delete to end of line.
This also affects cmd-shift-backspace.

The expected behaviour of cmd-delete is that it deletes to end of line,
with cmd acting as a modifier to delete/shift-backspace.
2014-11-12 13:41:32 +00:00
Ben Ogle
12b9f232c2 💄 2014-11-11 16:39:30 -08:00
Kevin Sawicki
19995df367 💄 Use two space indent 2014-11-11 16:39:24 -08:00
Ben Ogle
97a671cb49 Works with the shadow DOM disabled. 2014-11-11 16:30:22 -08:00
Ben Ogle
9acea88101 Change verbiage in spec names 2014-11-11 15:52:44 -08:00
Ben Ogle
b29c0ca2f7 nof 2014-11-11 15:52:21 -08:00
Ben Ogle
a4a3577163 💄 2014-11-11 15:50:34 -08:00
Ben Ogle
9dfaa8a4e5 Add bounds checking for overlay decorations 2014-11-11 15:46:27 -08:00
Ben Ogle
661b09ab1c Don’t need this 2014-11-11 15:45:57 -08:00
Nathan Sobo
e238292075 Remove WorkspaceElement::handleWindowFocus
We were getting stack traces in specs when the window got focused caused
by this subscription never getting disposed. We investigated, and can’t
find a case where removing this causes any issues.

Tested:
* Loading/reloading empty window
* Loading/reloading window with pane splits
* Opening/closing dev tools
* Switching focus between atom windows
* Switching focus between applications

Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2014-11-11 16:24:02 -07:00
Nathan Sobo
9fd52f600e Dispose of WorkspaceElement subscriptions when detached
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2014-11-11 16:24:02 -07:00
Nathan Sobo
c75e692269 Don’t add undefined context menus when activating package resources
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2014-11-11 16:24:02 -07:00
Nathan Sobo
6770570f13 Don't call Grim.deprecate for undefined context menus
This preserves the original behavior, in which passing undefined to
atom.contextMenu.add was a no-op that returned a no-op disposable.

Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2014-11-11 16:24:02 -07:00
Nathan Sobo
9875b069bc Merge pull request #4152 from atom/ns-highlight-region-classes
Add private API for adding classes to highlight regions for backward compatibility
2014-11-11 15:20:47 -07:00
Ben Ogle
9399e00033 Properly display when a marker is reversed 2014-11-11 13:32:13 -08:00
Ben Ogle
67d5d997c9 💄 in 📝 2014-11-11 13:08:27 -08:00
Ben Ogle
40c11410f0 Add Cursor::getMarker() method 2014-11-11 13:08:19 -08:00
Ben Ogle
307108ec6c Specs for positioning the overlay decorations 2014-11-11 13:08:05 -08:00
Ben Ogle
0bb173b646 Add spec for creation and removal of overlay 2014-11-11 11:25:36 -08:00