Cheng Zhao
bc211a2231
Should erase cef in rake clean.
2013-03-27 23:09:01 +08:00
Nathan Sobo
38924f5bb8
Upgrade to latest space pen, as an NPM
2013-03-27 11:06:49 -04:00
Cheng Zhao
ac30781db8
Merge pull request #444 from github/process-task
...
Add ProcessTask
2013-03-26 23:00:03 -07:00
Cheng Zhao
4768ae9008
Rename node-nsspellchecker to node-spellchecker.
2013-03-27 12:25:55 +08:00
Cheng Zhao
7effc4c456
💄
2013-03-27 12:25:55 +08:00
Cheng Zhao
6ce25d4c71
Fix the usage of spawn.
2013-03-27 12:25:54 +08:00
Cheng Zhao
371fdde4f9
Use atom/cefode.
2013-03-27 12:25:54 +08:00
Cheng Zhao
b5be1c378a
Replace Task's implementation with ProcessTask.
2013-03-27 12:25:54 +08:00
Cheng Zhao
3c5a79710a
Use _.isArray to determine whether a value is Array.
...
When passing arrays between child processes with node's IPC machanism,
`instance of Array` will return false for the deserialized array, we
should use the reiable way of detecting Array provided by underscore.
Read this for more:
http://perfectionkills.com/instanceof-considered-harmful-or-how-to-write-a-robust-isarray/
This bug was found when moving spell-check to use ProcessTask, and the
wrong Range object was returned for the passed misspelling value.
2013-03-27 12:25:54 +08:00
Cheng Zhao
3ed35574d4
Use node-nsspellchecker to replace $native's spell checker.
2013-03-27 12:25:54 +08:00
Cheng Zhao
142824ec01
Add test for ProcessTask.
2013-03-27 12:25:54 +08:00
Cheng Zhao
0d7f642675
Add ProcessTask.
2013-03-27 12:25:54 +08:00
Cheng Zhao
67c2a1473c
Cefode is using node v0.8.22.
2013-03-27 12:25:54 +08:00
Cheng Zhao
215cd64c9a
Use the node binary compiled with V8 used by Chromium.
...
The official node is using a different V8 version with the one used by
cefode, which causes incompatibility with cefode on native modules, this
special node binary fixes it.
The source code of this node binary can be found at:
https://github.com/atom/cefode-node/tree/chromium-v8
2013-03-27 12:25:54 +08:00
Kevin Sawicki
a772a9aa75
Remove unneeded std:: prefix
2013-03-26 23:32:05 -04:00
probablycorey
7e405138fc
Beep when only one matches is found by repeatRelativeAddress
...
Closes #45
2013-03-26 16:45:21 -07:00
probablycorey
f817e37a01
Refactor repeatRelativeAddress/repeatRelativeAddressInReverse
2013-03-26 16:45:21 -07:00
probablycorey
2ffb88e936
💄
2013-03-26 16:45:21 -07:00
probablycorey
34f3176259
Add $native.beep
...
I could have created an npm for this. I also could wash my hands every 10 seconds, but I'm not crazy, so I did neither.
2013-03-26 16:45:21 -07:00
Nathan Sobo
d3fa24be57
Remove scoped-properties when deactivating a TextMate package
2013-03-26 17:35:45 -06:00
Nathan Sobo
6a5ca3805e
Spec loading of scoped properties when activating TextMate packages
2013-03-26 17:35:44 -06:00
Nathan Sobo
eef13e7db8
Test that deferred packages don't require their main module
...
As opposed to asserting that the main module isn't present, which
might not be true if a previous spec required it.
2013-03-26 17:35:44 -06:00
Nathan Sobo
e32d7b1ff1
Remove unused test.tmbundle
2013-03-26 17:35:44 -06:00
Nathan Sobo
d8b4beb8bd
Now that we remove binding sets, track binding set indices explicitly
...
Previously we relied on the length of the binding sets, but now that
we remove them the length is not a strictly increasing number. This
could cause problem when using the index to break specificity ties.
2013-03-26 17:35:44 -06:00
Nathan Sobo
1f74b5ccb4
Rename textmate package w/ invalid snippets
2013-03-26 17:35:44 -06:00
Nathan Sobo
a07cd87c2c
Move testing of deferred deserializers to atom-spec
2013-03-26 17:35:44 -06:00
Nathan Sobo
2fe057bd9b
Move deferred activation specs to atom-spec
2013-03-26 17:35:44 -06:00
Nathan Sobo
2ac3af193b
Clean up deferred package activation
...
- Eliminate @deferActivation ivar
- Remove activation event listeners when deactivating unactivated packages
2013-03-26 17:35:44 -06:00
Corey Johnson & Nathan Sobo
81d4b764b8
Remove a package's scoped-properties when it is deactivated
...
Also: don't add the properties until `activate` is called. Previously
we were still adding the properties in the `load` method, which was
wrong.
2013-03-26 17:35:44 -06:00
Corey Johnson & Nathan Sobo
c8ec73d2f0
Allow scoped-properties to be added/removed by name
...
Also:
- remove "global" properties
- clear scoped properties between specs
2013-03-26 17:35:44 -06:00
Corey Johnson & Nathan Sobo
368e10a9f5
Move spec for scoped property loading to atom-spec
2013-03-26 17:35:44 -06:00
Corey Johnson & Nathan Sobo
3c561ef208
💄
2013-03-26 17:35:44 -06:00
Corey Johnson & Nathan Sobo
c8b9622bf4
Move specs for loading config defaults to atom-spec
2013-03-26 17:35:44 -06:00
Corey Johnson & Nathan Sobo
5d822b7305
Remove a package's stylesheets when it is deactivated
2013-03-26 17:35:43 -06:00
Corey Johnson & Nathan Sobo
1e51750b6c
Remove a package's keymaps when it is deactivated
2013-03-26 17:35:43 -06:00
Corey Johnson & Nathan Sobo
5410e9368f
Add ability to add/remove keymaps by name
2013-03-26 17:35:43 -06:00
Corey Johnson & Nathan Sobo
772787121c
Remove atom package grammars on deactivate
2013-03-26 17:35:43 -06:00
Corey Johnson & Nathan Sobo
c1954d869a
Add tests for TextMateGrammar@loadSync
2013-03-26 17:35:43 -06:00
Corey Johnson & Nathan Sobo
d37fbd43f1
Test that atom packages load their grammars
2013-03-26 17:35:43 -06:00
Corey Johnson & Nathan Sobo
de7d9bfcb1
Get deactivatePackage specs passing w/ new fixture data
2013-03-26 17:35:43 -06:00
Corey Johnson & Nathan Sobo
8c1f5658be
Allow packages to have stylesheet manifests
2013-03-26 17:35:43 -06:00
Corey Johnson & Nathan Sobo
c8804359c9
Rename fs -> fsUtils in atom-package
2013-03-26 17:35:43 -06:00
Corey Johnson & Nathan Sobo
b846a4db98
wip: cleanup package lifecycle specs
2013-03-26 17:35:43 -06:00
Corey Johnson & Nathan Sobo
643a5c6d0e
💄
2013-03-26 17:35:43 -06:00
Corey Johnson
da016114b6
Add specs for activating and deactivating TextMate packages
2013-03-26 17:35:43 -06:00
Corey Johnson & Nathan Sobo
8437f3ff7f
Only load TextMate packages as needed in specs
...
Also: when a TextMate package is deactivated, remove its grammars
2013-03-26 17:35:42 -06:00
Corey Johnson & Nathan Sobo
8340a084d3
Kill vestiges of CSON from TextMatePackage
2013-03-26 17:35:42 -06:00
Nathan Sobo
a41e3c1ebb
Don't clear loaded packages between specs
2013-03-26 17:35:42 -06:00
Nathan Sobo
bb8b3782b9
Serialize package states independently of RootView
...
Previously, package specs needed to deactivate the root view to test
their package serialization. Now, specs can just deactivate and then
reactivate the package, relying on serialization infrastructure that's
independent of the lifecycle of the RootView.
2013-03-26 17:35:42 -06:00
Nathan Sobo
f5774972e9
Add atom.deactivatePackage(id)
...
It serializes the package state to the atom.packageStates hash when
the package is deactivated, which means we will be able to test
package serialization independent of the overall window lifecycle by
just deactivating and re-activating the package.
2013-03-26 17:35:42 -06:00