Nathan Sobo
c7a4755808
If Workspace.open finds existing item, yield event loop
...
This ensures that the function always behaves asynchronously regardless
of the state of the workspace.
/cc @maxbrunsfeld
Signed-off-by: Antonio Scandurra <as-cii@github.com >
2017-03-29 09:27:21 -06:00
Nathan Sobo
45bd466384
Don’t add item in Workspace.open if activateItem is false
...
We thought it was a bug that activateItem: false caused the
item not to be added, but it turned out there were package
tests that depended on this behavior.
Ideally, we should have an addItem option that exhibits this
behavior instead.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2017-03-28 15:00:13 -06:00
Matthew Dapena-Tretter
08e8975a10
Always show the dock when an item is dropped into it
...
Previously, we were only showing it when going from 0 -> 1 items (which
is a bug).
2017-03-27 18:17:02 -07:00
Matthew Dapena-Tretter
3b23ab44bc
Add getLocation() to PaneContainer class
...
This allows the location to be inspected without having to jump to the
DOM and searching for a dock element.
2017-03-27 17:45:21 -07:00
Matthew Dapena-Tretter
401a549bf5
Don't open items in disallowed locations
2017-03-27 17:45:21 -07:00
Matthew Dapena-Tretter
41953ae7d6
Only show dock toggle buttons when dragging if item is allowed
2017-03-27 17:45:15 -07:00
Matthew Dapena-Tretter
f3c3917825
Don't show the dock toggle button if it's closed and empty
2017-03-27 14:20:47 -07:00
Matthew Dapena-Tretter
13f0c8a977
Docks: define handle size in CSS; measure in JS
2017-03-27 12:19:08 -07:00
Matthew Dapena-Tretter
d691c3e5aa
Docks: Don't change inherited presentation styles
2017-03-27 10:48:27 -07:00
Max Brunsfeld
bc872143cc
Avoid duplicate search for pane container in Workspace.open
2017-03-24 15:49:35 -07:00
Max Brunsfeld
4082b67fb0
Refactor Workspace.open
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-03-24 15:35:52 -07:00
Max Brunsfeld
93ba6109fa
Create Dock element lazily to be compatible w/ snapshotting
2017-03-24 15:29:46 -07:00
Max Brunsfeld
51b40edebd
⬆️ packages to fix test failures
2017-03-24 12:02:49 -07:00
Matthew Dapena-Tretter
52606171bf
Add "location" param to open()
2017-03-23 18:50:40 -07:00
Matthew Dapena-Tretter
d9e1fcc70b
Merge branch 'master' into HEAD
...
* master: (43 commits)
If one arch fails, kill the other for perf on appveyor
⬆️ dalek@0.2.1
Revert "⬆️ all packages that use atom-select-list"
⬆️ atom-keymap
⬆️ status-bar
⬆️ all packages that use atom-select-list
⬆️ language-ruby@0.71 .0
⬆️ autocomplete-css@0.16 .1
Ensure `packagesCache` exists before accessing it
🎨
⬆️ less-cache
Use `core/` instead of `<embedded>` for keymaps loaded during snapshot
Set also defaultSettings.core.projectHome when initializing Config
Fix tests
⬆️ atom-keymap
Replace CommandRegistry.addBundled with a boolean param in .add
Delete unused build scripts
🔥 Remove parserlib
Resolve style sheets paths during `script/build` for bundled packages
Don't use cached less sources and imported files in dev mode
...
2017-03-23 18:47:46 -07:00
Damien Guard
ce51074e6f
If one arch fails, kill the other for perf on appveyor
2017-03-23 17:57:18 -07:00
Lee Dohm
842b3f0f3c
⬆️ dalek@0.2.1
2017-03-23 14:37:32 -07:00
Wliu
ad27034f5d
Revert " ⬆️ all packages that use atom-select-list"
...
This reverts commit 363253522f .
2017-03-23 17:12:20 -04:00
bene
bfce347578
⬆️ atom-keymap
2017-03-23 19:51:52 +01:00
Matthew Dapena-Tretter
77ea97e623
Use async/await in openItem()
2017-03-23 11:43:06 -07:00
Matthew Dapena-Tretter
3e826591fd
Clean up storage of most recent location
2017-03-23 11:28:40 -07:00
Matthew Dapena-Tretter
791457d9a7
Add remaining pane container methods and documentation to docks
2017-03-23 11:24:41 -07:00
Matthew Dapena-Tretter
37a3c9b59c
Measure toggle button size instead of hardcoding it
2017-03-23 11:24:41 -07:00
Matthew Dapena-Tretter
e01bc40a78
"affordance" -> "hoverMargin"
2017-03-23 11:24:41 -07:00
Matthew Dapena-Tretter
d307c791c4
Be consistent about what "location" refers to
2017-03-23 11:24:37 -07:00
Matthew Dapena-Tretter
3fcec8b8cd
previousLocations -> itemLocationStore
2017-03-23 10:39:02 -07:00
Damien Guard
bb8db2acb0
⬆️ status-bar
2017-03-22 11:54:57 -07:00
Wliu
363253522f
⬆️ all packages that use atom-select-list
2017-03-22 11:27:37 -04:00
Antonio Scandurra
5150db2ff1
Merge pull request #14038 from atom/as-ns-optimize-stylesheets-loading
...
Optimize style sheets loading
2017-03-22 08:39:19 +01:00
Antonio Scandurra
cebe8adef2
Merge pull request #14024 from atom/as-snapshot-atom-environment
...
Snapshot `AtomEnvironment`
2017-03-21 09:37:05 +01:00
Matthew Dapena-Tretter
cd62357f0f
Mention dock getters in Dock docs
2017-03-20 22:39:28 -07:00
Matthew Dapena-Tretter
98e7fcc505
Prefer getElement() to view registry for Docks, PaneContainer & Pane
2017-03-20 22:39:23 -07:00
Matthew Dapena-Tretter
6f9893d77d
Rename "getActivePane" in tests to clarify intent
2017-03-20 19:50:35 -07:00
Wliu
bc14ff5855
⬆️ language-ruby@0.71.0
2017-03-20 20:40:04 -04:00
Wliu
d861e3a39e
⬆️ autocomplete-css@0.16.1
2017-03-20 16:53:36 -04:00
Max Brunsfeld
91780e6f18
Merge branch 'master' into fb-mdt-docks
2017-03-20 11:26:42 -07:00
Max Brunsfeld
89b338f819
⬆️ packages in preparation for docks feature
2017-03-20 11:25:38 -07:00
Antonio Scandurra
2ce66a724c
Ensure packagesCache exists before accessing it
2017-03-20 17:23:06 +01:00
Antonio Scandurra
e2637aac78
🎨
2017-03-20 10:20:36 +01:00
Antonio Scandurra
c156c9b7ea
⬆️ less-cache
2017-03-20 10:11:04 +01:00
Antonio Scandurra
95cf200a7c
Merge branch 'as-snapshot-atom-environment' into as-ns-optimize-stylesheets-loading
...
# Conflicts:
# script/tdd
2017-03-20 10:06:57 +01:00
Antonio Scandurra
31692f6e6c
Merge branch 'master' into as-snapshot-atom-environment
2017-03-20 09:58:15 +01:00
Antonio Scandurra
650ec8a94c
⬆️ keybinding-resolver
2017-03-20 09:57:58 +01:00
Antonio Scandurra
17611889d3
Use core/ instead of <embedded> for keymaps loaded during snapshot
2017-03-20 09:56:40 +01:00
Matthew Dapena-Tretter
417e9c6979
Add tests for open() and docks
2017-03-18 15:32:01 -07:00
Matthew Dapena-Tretter
47cdc74b6a
Only count panes in center in workspace test
2017-03-18 15:32:01 -07:00
Matthew Dapena-Tretter
d854a88dbb
Add workspace.toggle() method
2017-03-18 15:32:01 -07:00
Matthew Dapena-Tretter
5b4f402278
Add toggle commands
2017-03-18 15:32:01 -07:00
Matthew Dapena-Tretter
5c7bd66896
Remember previous item locations
2017-03-18 15:32:01 -07:00
Matthew Dapena-Tretter
64e290b57f
Make open() location aware
2017-03-18 15:32:01 -07:00