Nathan Sobo
c97ecf9da2
Don’t disable render backgrounding. Doesn’t seem to make a difference.
2015-11-09 14:56:42 -07:00
Nathan Sobo
5587bad758
Add description to waitsFor
2015-11-09 00:35:34 -07:00
Nathan Sobo
a35e24658d
Increase timeouts
2015-11-09 00:35:34 -07:00
Nathan Sobo
fc5788c43b
Disable renderer backgrounding
2015-11-09 00:35:34 -07:00
Nathan Sobo
6dd18b348b
Include more debug info when nextViewUpdatePromise times out
2015-11-09 00:35:34 -07:00
Nathan Sobo
98c420a408
Wait for nextTick after presenter updates
...
This gives any nextTick callbacks in the model a chance to complete
before proceeding with tests.
2015-11-09 00:35:34 -07:00
Nathan Sobo
21f8ad6958
Bump timeouts
2015-11-09 00:35:34 -07:00
Nathan Sobo
213e7d0b35
Schedule marker updates with nextTick instead of setImmediate
...
From what I understand, nextTick callbacks actually happen at the end
of the current event loop cycle rather than the next one. The naming is
confusing.
2015-11-09 00:35:33 -07:00
Nathan Sobo
1aa4b7e06a
Clear nextUpdatePromise immediately when an animation frame fires
2015-11-09 00:35:33 -07:00
Nathan Sobo
54a9012796
Clear next update promise when resetting ViewRegistry
2015-11-09 00:35:33 -07:00
Nathan Sobo
1a8adbb4e1
🎨
2015-11-09 00:35:33 -07:00
Nathan Sobo
fe88611e79
Tear down timers when destroying TextEditorPresenter
2015-11-09 00:35:33 -07:00
Nathan Sobo
b9528dcb39
Cancel ViewRegistry animation frames between specs
2015-11-09 00:35:33 -07:00
Nathan Sobo
ff681752f7
Add a nextViewUpdatePromise helper so we get stack traces from timeouts
2015-11-09 00:35:33 -07:00
Nathan Sobo
e9dfc080a3
Convert text-editor-component-spec to Babel for async/await
...
It's much easier to reason about async/await than Jasmine's
built-in queuing system, and using them made it easier to
debug flaky async tests.
2015-11-09 00:35:32 -07:00
Nathan Sobo
bddb601b45
⬆️ snippets
2015-11-09 00:35:32 -07:00
Nathan Sobo
51a7c9ea68
Always set devMode to true for spec windows
2015-11-09 00:35:32 -07:00
Nathan Sobo
7edb80155a
⬆️ text-buffer
2015-11-09 00:35:32 -07:00
Nathan Sobo
80adbe8562
⬆️ find-and-replace
2015-11-09 00:35:32 -07:00
Nathan Sobo
3a4199a0cd
Allow (start/end)(Buffer/Screen)Position in findMarker queries on layers
2015-11-09 00:35:32 -07:00
Nathan Sobo
533146bc6a
Document new APIs
2015-11-09 00:35:32 -07:00
Nathan Sobo
3f4d8d0104
⬆️ text-buffer
2015-11-09 00:35:31 -07:00
Nathan Sobo
9714f2e729
Emit decoration events synchronously in legacy spec environment
...
This is needed to keep a bunch of package tests passing that expect
synchronous decoration updates.
2015-11-09 00:35:31 -07:00
Nathan Sobo
5e9cec2ec7
⬆️ text-buffer
2015-11-09 00:35:31 -07:00
Nathan Sobo
f6859210d0
⬆️ text-buffer
2015-11-09 00:35:31 -07:00
Nathan Sobo
9ee3d53975
Destroy the selections marker layer when editors are destroyed
2015-11-09 00:35:31 -07:00
Nathan Sobo
2f81e5faac
Store folds in their own marker layer
2015-11-09 00:35:31 -07:00
Nathan Sobo
29bb1bb31b
Add TextEditor-level marker layers and use them for selections
2015-11-09 00:35:31 -07:00
Nathan Sobo
1ee6384332
Add TextEditorMarkerLayer
2015-11-09 00:35:31 -07:00
Nathan Sobo
b1a5b58fa2
Rename Marker to TextEditorMarker to resolve ambiguity w/ TextBuffer API
...
We expose both kinds of markers in Atom, and the docs were actually
wrong when we refer to Markers from TextBuffer because it linked to the
TextEditor layer’s Marker implementation. This will clarify the
difference.
2015-11-09 00:35:30 -07:00
Nathan Sobo
b508cc6d9f
Fix linter error
2015-11-09 00:35:30 -07:00
Nathan Sobo
205b6bf66c
⬆️ text-buffer
2015-11-09 00:35:28 -07:00
Nathan Sobo
78513f4528
Remove duplicated method definition
2015-11-09 00:35:28 -07:00
Nathan Sobo
4139863cee
⬆️ text-buffer (pre-release)
2015-11-09 00:35:28 -07:00
Nathan Sobo
a3ff0ad75a
🎨 Rename method
2015-11-09 00:35:28 -07:00
Nathan Sobo
75d0a0820c
Allow properties to be overridden for a single marker in LayerDecoration
2015-11-09 00:35:28 -07:00
Nathan Sobo
acf142863c
Add TextEditor::decorateMarkerLayer
2015-11-09 00:35:27 -07:00
Nathan Sobo
20f4c61325
Drop stray sample.js file
2015-11-09 00:35:27 -07:00
Nathan Sobo
3a25fe4975
Remove id from decoration properties
...
It doesn’t make sense to include this when we’ll reuse the same
properties for multiple decoration instances when decorating marker
layers.
2015-11-09 00:35:27 -07:00
Nathan Sobo
7d22ed788c
Test decorateMarker + decorationStateForScreenRowRange
2015-11-09 00:35:27 -07:00
Nathan Sobo
9d6168aac8
Fix gutter spec indentation
2015-11-09 00:35:27 -07:00
Nathan Sobo
d7b0ab9179
Simplify updating of custom gutter decoration state
2015-11-09 00:35:27 -07:00
Nathan Sobo
92ed7c8b15
Don’t return Decoration objects from model to view
...
Preparation for LayerDecorations, in which individual decoration objects
won’t exist for every marker.
2015-11-09 00:35:27 -07:00
Nathan Sobo
d46091d7e5
Remove dead code
2015-11-09 00:35:27 -07:00
Nathan Sobo
800440d5ca
Remove logging
2015-11-09 00:35:27 -07:00
Nathan Sobo
3c98c30b43
Wait for animation frames synchronously after actions
...
This avoids test flakiness, presumably due to an animation frame firing
before we have a chance to wait due to jasmine’s queueing.
2015-11-09 00:35:26 -07:00
Nathan Sobo
2af010e729
Remove dead test
...
It tests functionality that no longer matters since we don’t subscribe
to decorations being destroyed in DisplayBuffer
2015-11-09 00:35:26 -07:00
Nathan Sobo
0169c1160e
Wait for next DOM update synchronously after change to avoid flakiness
2015-11-09 00:35:26 -07:00
Nathan Sobo
0ac42a12f3
Add waitsForNextDOMUpdate helper function
2015-11-09 00:35:18 -07:00
Nathan Sobo
4b5e4d02eb
Use real clock in text-editor-component-spec
...
This will make it much easier to test asynchronous update logic.
2015-11-09 00:35:18 -07:00
