Nathan Sobo
4946eec367
Merge remote-tracking branch 'origin/master' into ns-simplify-events
...
Conflicts:
docs/your-first-package.md
2014-09-03 19:31:37 -06:00
Nathan Sobo
db571a2fbf
Avoid deprecation by calling ::getActivePaneItem
2014-09-03 19:26:19 -06:00
Nathan Sobo
22c62b3107
Replace ‘editor-created’ event with ::onDidAddTextEditor
2014-09-03 19:26:07 -06:00
Nathan Sobo
83327eeabb
Don’t test for editor-created events when editor is copied
...
We can handle this through ::onDidAddTextEditor when the copy is added
back to the pane.
2014-09-03 19:25:40 -06:00
Ben Ogle
8e286194f1
Merge pull request #3446 from atom/bo-move-var
...
Add columnCount variables to cursor::moveLeft and moveRight and related methods
2014-09-03 17:36:31 -07:00
Ben Ogle
691c7ee585
Considerably more elegant (and correct) moveLeft and moveRight
2014-09-03 17:19:06 -07:00
Paul Betts
dededd80dd
Add Squirrel.Windows 0.4.92
2014-09-03 16:57:22 -07:00
Ben Ogle
48b693c1c1
Add columnCounts to selection methods
2014-09-03 16:20:25 -07:00
Ben Ogle
7a3893c7bb
Update doc strings
2014-09-03 16:10:33 -07:00
Ben Ogle
06165b2167
Remove the max call
2014-09-03 16:10:33 -07:00
Ben Ogle
f82c59d865
Add columnCount to moveRight
2014-09-03 16:10:33 -07:00
Ben Ogle
29f15d0f20
Make moveLeft() with huge values span multiple rows
2014-09-03 16:10:33 -07:00
Ben Ogle
99c07decf2
Add columnCount var to Editor::moveLeft and Cursor::moveLeft
2014-09-03 16:10:33 -07:00
Ben Ogle
851034c8d3
Failing test
2014-09-03 16:10:33 -07:00
Ben Ogle
3a85148f69
Fix doc strings
2014-09-03 16:10:33 -07:00
Nathan Sobo
f87f7c358a
Kill a couple deprecation errors
2014-09-03 17:08:13 -06:00
Ben Ogle
df579a9295
Merge pull request #3445 from atom/bo-line-for-row
...
lineForRow changes
2014-09-03 16:07:42 -07:00
Ben Ogle
b90670ff2d
Gracefully handle the case when there is no screenline
2014-09-03 16:00:57 -07:00
Nathan Sobo
67dc703c18
💄 docs
2014-09-03 16:46:53 -06:00
Nathan Sobo
c508f76af0
Upgrade event-kit for deprecated .off on subscriptions
2014-09-03 16:40:18 -06:00
Nathan Sobo
a8c1f2d0a5
Deprecate Workspace methods
2014-09-03 16:37:36 -06:00
Nathan Sobo
7ad992e52f
💄
2014-09-03 16:35:46 -06:00
Nathan Sobo
87fb0b46f7
Deprecate theorist-provided behaviors in Pane
2014-09-03 16:31:14 -06:00
Nathan Sobo
873818ee52
Deprecate string-based event subscriptions
2014-09-03 16:21:42 -06:00
Ben Ogle
523a255e48
Add Editor::lineTextForScreenRow()
...
Closes #3055
2014-09-03 14:42:46 -07:00
Ben Ogle
5e21d1ca5b
Deprecate Editor::lineLengthForBufferRow
2014-09-03 14:42:46 -07:00
Ben Ogle
0703788209
Editor::linesForScreenRows -> ::tokenizedLinesForScreenRows
2014-09-03 14:42:46 -07:00
Ben Ogle
c0c941b8db
lineForBufferRow -> lineTextForBufferRow
2014-09-03 14:42:46 -07:00
Ben Ogle
e3a0339fe3
Editor::lineForScreenRow -> ::tokenizedLineForScreenRow
2014-09-03 14:42:46 -07:00
Ben Ogle
c4265776b3
Rename unused method
2014-09-03 14:42:46 -07:00
Ben Ogle
ae49fd50b7
DisplayBuffer::linesForRows -> ::tokenizedLinesForScreenRows
...
Clarity!
2014-09-03 14:42:46 -07:00
Ben Ogle
cdbbec91f0
row -> bufferRow for clarity
2014-09-03 14:42:45 -07:00
Ben Ogle
dbb0ff9830
Remove unused method
2014-09-03 14:42:45 -07:00
Ben Ogle
99f899dc4a
lineForScreenRow -> tokenizedLineForRow
...
The method was severely mislabeled
2014-09-03 14:42:45 -07:00
Ben Ogle
2b9b4a48ef
tokenizedLineForRow -> tokenizedLineForScreenRow
2014-09-03 14:42:45 -07:00
Ben Ogle
b516f5a74d
lineForBufferRow -> lineTextForBufferRow
2014-09-03 14:42:45 -07:00
Ben Ogle
05bbc480b0
displayBuffer::lineForRow -> tokenizedLineForRow
2014-09-03 14:42:45 -07:00
Ben Ogle
c0e2ed4282
Fix comments
2014-09-03 12:04:21 -07:00
Ben Ogle
d3c2cd756a
Fix comment
2014-09-03 12:01:36 -07:00
Kevin Sawicki
1ff9da5f7a
Upgrade to markdown-preview@0.101
2014-09-03 11:31:41 -07:00
Nathan Sobo
d3422786c3
Unmount component when EditorView is detached
...
Fixes #3431
When a pane item is moved to another pane, we *detach* the associated
view but we don’t fully remove it. This was to prevent removing a view
when it was used as the pane item directly. However, this was causing
the editor component not to be unmounted, which caused leaks and
incorrect measurements.
We need to unmount the component, but we don’t want to destroy the
editor. So I’ve moved editor destruction to the wrapper view for now,
and I only do it when the view is actually removed.
Ultimately, we need to have a 1:1 relationship with pane items and their
views and only allow a pane item to appear once in the pane tree. Then
we can recycle the same view and avoid this confusing situation where
the old view is detached and a new view is created.
2014-09-03 11:42:56 -06:00
Ivan Zuzak
ebbfaa23ce
Preserve folds when selecting rows by clicking the gutter
2014-09-03 18:54:46 +02:00
Ivan Zuzak
29ad748aa4
Dont propagate fold icon clicks to editor component
2014-09-03 18:52:50 +02:00
Nathan Sobo
d753a7f38d
Merge pull request #3440 from atom/ns-exclusive-selection-intersection
...
Don’t merge adjacent non-empty selections
2014-09-03 09:24:05 -06:00
Ben Ogle
1e4fb5b4bc
nof
2014-09-02 17:44:01 -07:00
Nathan Sobo
cfd2722348
Don’t merge adjacent non-empty selections
...
This improves the behavior of #3433
2014-09-02 18:10:05 -06:00
Ben Ogle
ae0bffc4ea
Fix some doc strings
2014-09-02 17:01:20 -07:00
Ben Ogle
3d8f3883d1
Upgrade deprecation cop to remove the status bar icon.
2014-09-02 16:52:22 -07:00
Ben Ogle
81532d52f7
Move select all fn so docs read better
2014-09-02 16:45:49 -07:00
Ben Ogle
0b34e46a1a
Merge pull request #3420 from atom/bo-update-cursor-selection-apis
...
Update cursor and selection APIs
2014-09-02 16:41:42 -07:00
