Commit Graph

20 Commits

Author SHA1 Message Date
Ash Wilson
8c8426c783 typeof setTimeout isn't enough to probe for snapshot generation 2018-12-21 08:41:09 -05:00
David Wilson
4a151ac210 Fix #14716: Error when deserializing TreeView for project
This change fixes an issue that appears when the user removes the last
project from the workspace and then re-adds it.  At this time an error
is thrown from within ItemRegistry because the PaneContainer that
holds the TreeView in the left-most dock does not clear out its
existing ItemRegistry before deserializing the old TreeView state.

The fix is to create a new ItemRegistry when a PaneContainer is
deserialized so that the previous Pane's items are not retained.
2018-01-22 15:13:37 -08:00
Max Brunsfeld
2374077a6e Wait for async onWillDestroyItem handlers before destroying item 2017-09-12 15:04:37 -07:00
Max Brunsfeld
c6bf86c9b4 Merge pull request #14375 from atom/fb-mdt-ondidstopchangingactivepaneitem
Fix `PaneContainer::onDidStopChangingActivePaneItem()`
2017-06-08 17:25:31 -07:00
Max Brunsfeld
2420d12e44 Merge pull request #14435 from atom/mb-use-native-text-buffer
Use new native text-buffer implementation
2017-06-08 16:50:53 -07:00
Matthew Dapena-Tretter
26d9579b0e 🐛 Fix PaneContainer::onDidStopChangingActivePaneItem()
We weren't ever dispatching this event! Oops XD
2017-06-08 16:42:32 -07:00
Jason Rudolph
f62cb5d427 🐛 Don't attempt to copy items that aren't copyable 2017-06-08 15:42:39 -04:00
Jason Rudolph
de47d3d439 🎨 Extract function: Pane::isItemAllowed(item) 2017-06-07 15:45:02 -04:00
Jason Rudolph
296e407284 Check an item's allowed locations when moving/copying to pane 2017-06-07 12:59:54 -04:00
Max Brunsfeld
dc320181fc Fix handling of .save and .saveAs rejections
* Make Pane.close, Pane.saveActiveItem, and Pane.saveActiveItemAs async.
* Refactor the logic for prompting to save on window unload
2017-05-31 17:46:04 -07:00
Nathan Sobo
2498b991c6 Fix dock dragging 2017-04-08 14:29:27 -06:00
Nathan Sobo
9c28cc0fa8 Construct WorkspaceCenter's PaneContainer instance in the constructor 2017-04-06 16:57:41 -06:00
Nathan Sobo
1711d10af2 Aggregate onDidStopChangingActivePaneItem events across all containers 2017-04-06 16:35:25 -06:00
Nathan Sobo
646047f563 Maintain an active pane container on the workspace
This will be used by many commands that previously only interacted with
the center of the workspace.
2017-04-06 15:30:01 -06:00
Nathan Sobo
f1e30fe7cf 🎨 2017-04-06 13:53:34 -06:00
Nathan Sobo
ec576b12bc Remove PaneContainer.monitorActivePaneItem
Call didChangeActiveItemOnPane directly from panes and when the active
pane changes instead.
2017-04-06 13:18:18 -06:00
Nathan Sobo
2f7fb3f565 Remove PaneContainer.monitorPaneItems 2017-04-06 13:01:17 -06:00
Nathan Sobo
326ae6bf32 Use didDestroyPaneItem to remove item from item registry 2017-04-06 12:56:45 -06:00
Nathan Sobo
317428b58d Inform pane containers directly when adding non-moved pane items 2017-04-06 12:52:42 -06:00
Nathan Sobo
0a877a219f Convert PaneContainer to JS 2017-04-06 11:52:16 -06:00