Commit Graph

15429 Commits

Author SHA1 Message Date
Nathan Sobo
ce5c29fb47 Base the visible lines on the height instead of the clientHeight
Because overlay scrollbars are invisible unless scrolling and even
regular scrollbars can be transparent.
2014-05-09 11:33:04 -06:00
Nathan Sobo
f0fd48202c Refresh scrollbars when overlay/classic style preferences changes 2014-05-09 11:33:04 -06:00
Nathan Sobo
d5eb8c21b2 Only refresh editor scrollbars on stylesheet changes that require it
If a stylesheet is added or removed, we check if it contains a selector
for scrollbars before refreshing anything.
2014-05-09 11:33:04 -06:00
Nathan Sobo
76b9982e04 Emit stylesheet-added/removed from ThemeManager w/ CSSStyleSheet objects
This enables subscribers to detect not just that stylesheets have
changed, but specifically how they have changed. This is used by the
React editor component to only refresh scrollbars when a stylesheet
that actually contains selectors for scrollbar elements is added or
removed.
2014-05-09 11:33:04 -06:00
Nathan Sobo
ca7f11f7d0 Default scrollbar height/width to 15 when it's measure as 0
A 0 measurement indicates that overlay scrollbars are enabled, so we
just fall back to 15px in that case so the user can hover directly over
the scrollbar to scroll.
2014-05-09 11:33:04 -06:00
Nathan Sobo
1c1ace90db Hide and show scrollbars before measuring them after stylesheet changes
We measure the scrollbar-corner node when there's a stylesheet change,
but Chromium won't apply the new style if it was already visible before
the change. This commit hides and shows it before measuring so we get
accurate values.
2014-05-09 11:33:04 -06:00
Nathan Sobo
bdd605e85b Explicitly assign dummy scrollbars to the correct width/height
Previously, dummy scrollbars were always 15px wide/tall. This caused
them to obscure the ability to click for the entire 15px region, even if
the actual scrollbar was styled to be much thinner. Now we explicitly
measure the size of scrollbars on mount and when the stylesheets change
and set the height/width explicitly.
2014-05-09 11:33:04 -06:00
Nathan Sobo
e1b4b921ba Hide scrollbar when not scrollable in a given direction 2014-05-09 11:33:04 -06:00
Nathan Sobo
ab1ede5fe6 Add a dummy scrollbar corner
Horizontal / vertical scrollbars render a 'corner' on the lower right
when they would otherwise overlap. I previously relied on drawing both
dummy scrollbars at their full width/height so the corner got rendered,
but that interfered with the display of the horizontal scrollbar in
certain circumstances because it was too wide to scroll. This commit
provides that behavior with an absolutely positioned div with the same
dimensions as the intersection of scrollbars when both are visible.
2014-05-09 11:33:04 -06:00
Nathan Sobo
5e6d91d66c Don't allow spec window size to interfere with the size of the editor 2014-05-09 11:33:04 -06:00
Nathan Sobo
dbd271f70a Don't obscure last character of long lines with vertical scrollbar
This entailed quite a few changes to dial in scrollbars. The scrollbars
are now adjusted in size to account for the width of the opposite
scrollbar. If the width or height are not explicitly constrained and we
are scrollable in the opposite direction that is constrained, we account
for the width of the opposite scrollbar in assigning a natural height
or width based on the content.
2014-05-09 11:33:04 -06:00
Nathan Sobo
527ada47f9 Account for gutter width in scrollWidth of horizontal scrollbar
Because the scrollbar now spans the entire editor but the scrollable
area does not include the gutter, we need to add the current width of
the gutter to the scroll width of the horizontal scrollbar to allow
it to scroll to the end of the longest lines.
2014-05-09 11:33:03 -06:00
Nathan Sobo
afb70d0a95 Remove stray return in spec 2014-05-09 11:33:03 -06:00
Nathan Sobo
b5f910ad06 Update line number padding when max digits changes 2014-05-09 11:33:03 -06:00
Nathan Sobo
e412371b88 Remove logging 2014-05-09 11:33:03 -06:00
Nathan Sobo
7b4bc16531 Fix specs that broke when accounting for horizontal scrollbar height 2014-05-09 11:33:03 -06:00
Nathan Sobo
e6df30e94c Respect horizontal scrollbar when rendering the vertical, and vice versa
We set overflow to hidden in the opposite scroll direction only if we
can't actually scroll in that direction, causing the white square where
neither scrollbar overlaps to appear at the lower right corner.
2014-05-09 11:33:03 -06:00
Nathan Sobo
d9ba9262bf Update scrollTop to valid position when scrollbar disappears 2014-05-09 11:33:03 -06:00
Nathan Sobo
c4be32a5dd Revert "Revert "Don't obscure the last line of the editor with the horizontal scrollbar""
This reverts commit 1d634e471e.
2014-05-09 11:33:03 -06:00
Corey Johnson
0a32f6b5f0 Merge pull request #2050 from Spice-King/win-cmd-spawn-fix
Fix running .cmd stubs through BufferedProcess
2014-05-09 09:12:31 -07:00
Kyle Filz
f9fe5efbb0 Fix running .cmd stubs through BufferedProcess
ChildProcess.spawn only will run .exe files on Windows, not .cmd, .bat,
.anythingElse.

See joyent/node#2318 for more information.
2014-05-09 09:04:36 -05:00
Kevin Sawicki
3f0302b256 Upgrade to apm@0.52.0 2014-05-09 13:52:31 +02:00
Ivan Žužak
88d024e73b Upgrade to feedback@0.33.0 2014-05-09 12:23:06 +01:00
Daniel Hengeveld
0d190d2cd4 Merge pull request #2112 from atom/why-ghfw
Explain why GH4W
2014-05-08 19:21:53 -07:00
Paul Betts
4afae028ec Explain why GH4W 2014-05-08 19:00:53 -07:00
Paul Betts
5165f0df88 Merge remote-tracking branch 'origin/master' into winreadme
Conflicts:
	README.md
2014-05-08 18:06:05 -07:00
Corey Johnson
5b7b3501a6 Merge pull request #2081 from xcvd/master
Shift backspace keymap
2014-05-08 17:03:25 -07:00
Corey Johnson
c3937d0c4c Merge pull request #2073 from captn3m0/master
Make atom build behind firewalls
2014-05-08 16:53:31 -07:00
Corey Johnson
6e27208c5c Merge pull request #2108 from atom/cj-update-build-docs
Update build docs
2014-05-08 16:42:34 -07:00
Corey Johnson
91342db0ba Tweak build instruction content 2014-05-08 16:34:54 -07:00
Corey Johnson
8f7123ae12 Update build instruction links 2014-05-08 16:31:10 -07:00
Corey Johnson
3a22b3d4b8 Move build instructions to separate files 2014-05-08 16:30:44 -07:00
Corey Johnson
919ca82ccd Update building section of docs 2014-05-08 16:16:31 -07:00
Corey Johnson
d35baac054 Add build instructions section to docs folder 2014-05-08 16:16:13 -07:00
Corey Johnson
9aa2df7cee Merge pull request #2059 from bradgearon/master
append .cmd to apm in package-manager.coffee if platform is win32
2014-05-08 15:14:36 -07:00
Corey Johnson
41ea18a8f1 Merge pull request #2047 from cameronmcefee/master
Wordsmith the Atom readme
2014-05-08 15:10:39 -07:00
Corey Johnson
5cf37fd13e Merge pull request #2045 from atom/cj-tabs-be-weird
Make Atom smarter about guessing if a file uses soft or hard tabs
2014-05-08 15:09:32 -07:00
Corey Johnson
a649d75ab8 Merge remote-tracking branch 'origin/master' into cj-tabs-be-weird
Conflicts:
	package.json
2014-05-08 14:36:50 -07:00
Corey Johnson
255cdbb60a Avoid problems with version pattern ^X.Y.Z
Older versions of npm don't recognize that pattern
2014-05-08 14:14:26 -07:00
Corey Johnson
bd4e56fd08 Upgrade to text-buffer@2.2.2 2014-05-08 14:01:30 -07:00
Corey Johnson
5246d784db Upgrade to text-buffer@2.2.1 2014-05-08 13:50:54 -07:00
Brad Gearon
e945b83318 remove os require use process.platform instead 2014-05-08 12:38:35 -05:00
Kevin Sawicki
38bd996996 Merge pull request #2052 from AngelEzquerra/ignore_mercurial_files
Add mercurial directories to default list of ignored names
2014-05-08 19:23:40 +02:00
Kevin Sawicki
8f3a72e11b Merge pull request #2071 from lee-dohm/doc-fix
📝 Some simple documentation fixes
2014-05-08 19:21:00 +02:00
Kevin Sawicki
ddc62efb44 Upgrade to pathwatcher@1.2.4 2014-05-08 19:17:17 +02:00
Kevin Sawicki
8f08e497a0 Upgrade to scrollbar-style@0.4.0 2014-05-08 19:16:47 +02:00
xcvd
8048f8af5f Shift backspace keymap
Within windows build shift-backspace currently does nothing. Behaviour
untested in linux (perhaps linux.cson should be modified too?)
2014-05-08 11:53:47 +01:00
Abhay Rana
c66d3fdba0 Make atom build behind firewalls
This is to get `npm install` to work behind firewalls where `git://` is blocked.
2014-05-08 12:24:34 +05:30
Lee Dohm
9b49c2f987 📝 Some simple documentation fixes 2014-05-07 22:38:51 -07:00
Paul Betts
bceed13606 Fix Windows build instructions 2014-05-07 20:08:09 -07:00