ungb
07c7e53b1e
fix lint errors
2017-07-10 16:26:47 -07:00
Nathan Sobo
f6d2f966bf
Fix middle-mouse-button paste on Linux
...
Chrome now synthesizes a textInput event on mouseup for middle mouse
button clicks, which rendered our custom JS for handling that case
redundant.
2017-07-10 15:53:23 -06:00
Nathan Sobo
cd27b49dc4
Don't handle ctrl-click events on macOS
...
It brings up the context menu, so we shouldn't change the cursor
position
2017-07-10 14:28:21 -06:00
Nathan Sobo
82619a989b
🎨
2017-07-10 14:27:55 -06:00
Nathan Sobo
960e515e77
Merge pull request #14948 from atom/ns-add-gutter-decoration-class
...
Always render 'decoration' class on custom decorations
2017-07-05 15:24:43 -06:00
Antonio Scandurra
bcaf655325
Update buffer-row and screen-row data fields on each line number node
2017-07-05 11:12:48 +02:00
Antonio Scandurra
942dd03bd0
Assign screen-row to each line number as a data field
2017-07-05 11:11:44 +02:00
Nathan Sobo
e7b4ad48f0
Always render 'decoration' class on custom decorations
2017-07-03 16:10:41 -06:00
Antonio Scandurra
b30f55bb57
Invalidate block decorations height automatically if their size changes
2017-06-30 14:08:49 +02:00
Matthew Dapena-Tretter
863faffd23
Only expect a single 'did-destroy' event
...
These events will only be fired a single time at most, so we should clean up the listeners after that.
This should help minimize accidental memory leaks.
2017-06-27 16:20:33 -07:00
Antonio Scandurra
e0c2509bf7
Merge pull request #14897 from atom/as-jr-fix-not-updating-custom-title-bar
...
Ensure custom title bar is always updated when document.title changes
2017-06-27 11:35:43 +02:00
Antonio Scandurra
57570accbf
Merge pull request #14893 from atom/as-fix-resetting-node-pool-styles
...
Fix resetting styles in NodePool
2017-06-27 11:35:19 +02:00
Antonio Scandurra
9e8f07b926
Convert src/title-bar.coffee to js
...
Signed-off-by: Jason Rudolph <jasonrudolph@github.com >
2017-06-26 16:34:33 +02:00
Antonio Scandurra
62ee913567
Ensure custom title bar is always updated when document.title changes
...
This commit uses a new private API on Workspace that emits an event
every time the window title gets updated (e.g. as a result of an active
pane item changing, the project paths changing, etc.).
This fixes a bug that left the custom title bar with a stale
document.title under some circumstances.
Signed-off-by: Jason Rudolph <jasonrudolph@github.com >
2017-06-26 16:29:31 +02:00
Antonio Scandurra
52ba6c7342
Fix measuring block dec. if adding them before updating element's width
2017-06-26 12:52:18 +02:00
Antonio Scandurra
a171380544
Fix resetting styles in NodePool
...
Previously, we were mistakenly not clearing out some styling properties
like `marginTop`, thus causing e.g. line numbers to be misaligned. This
was caused by manual updates to an element's style object, without a
consequent update to the NodePool.
With this commit we will now rely on `element.styleMap` (a DOM
primitive) to detect which styles have been set on a element that is
about to be recycled and, if the object being created doesn't use them,
simply clear them out.
2017-06-26 11:37:11 +02:00
Max Brunsfeld
c1c0e7e921
Merge pull request #14736 from atom/fb-mdt-observe-dock-visibility
...
Add methods for observing dock visibility
2017-06-22 14:11:52 -07:00
Nathan Sobo
41d5715ef6
Merge pull request #14790 from atom/ns-document-text-decorations
...
Document text decorations
2017-06-15 22:57:34 +02:00
Nathan Sobo
147e9dff42
Document text decorations
2017-06-15 22:15:31 +02:00
Paul Betts
2c29d99f33
Directly tell Squirrel what kinds of shortcuts to create
2017-06-14 15:08:35 -07:00
Antonio Scandurra
0a46c9ad7b
Prevent block decorations from mistakenly wrapping during measurements
...
Before rendering block decorations, we read their heights by putting
them into a special div called `blockDecorationMeasurementsArea`.
Previously, this div was not explicitly sized, which was causing
decorations to wrap while being measured but not when actually rendering
them.
This commit fixes this inconsistency by explicitly styling the
measurement area so that it has the same width as the component scroll
width.
2017-06-13 12:31:27 +02:00
Lee Dohm
6edf6599b7
Merge pull request #14753 from tjkohli/master
...
Improved clarity of Editor not responding actions
2017-06-12 09:15:55 -07:00
Antonio Scandurra
d978a0f2cd
Merge pull request #14734 from atom/as-ns-clip-autoscroll
...
Don't try to measure lines that don't exist
2017-06-12 17:20:17 +02:00
TJ Kohli
5524aca461
Improved clarity of Editor not responding actions
...
Changed "Close" to "Force Close" because "Close" might imply closing the Alert/Dialog instead of the editor, whereas "Force Close" better describes the action that button will take.
2017-06-10 19:30:52 -04:00
Antonio Scandurra
9a0709e95e
Don't try to measure lines that don't exist
...
By the time that the animation frame is delivered, the requested
autoscroll
position could not exist anymore. This could cause the editor component
to measure a non-existent line and, as a result, throw an exception.
With this commit we will always ignore measurements for screen lines
that do not exist.
2017-06-09 18:40:24 +02:00
Max Brunsfeld
c6bf86c9b4
Merge pull request #14375 from atom/fb-mdt-ondidstopchangingactivepaneitem
...
Fix `PaneContainer::onDidStopChangingActivePaneItem()`
2017-06-08 17:25:31 -07:00
Max Brunsfeld
2420d12e44
Merge pull request #14435 from atom/mb-use-native-text-buffer
...
Use new native text-buffer implementation
2017-06-08 16:50:53 -07:00
Matthew Dapena-Tretter
26d9579b0e
🐛 Fix PaneContainer::onDidStopChangingActivePaneItem()
...
We weren't ever dispatching this event! Oops XD
2017-06-08 16:42:32 -07:00
Jason Rudolph
5d7e9a622f
Merge pull request #14640 from atom/jr-directional-pane-navigation-for-entire-workspace
...
Teach directional pane navigation commands to support docks
2017-06-08 19:15:33 -04:00
Jason Rudolph
f62cb5d427
🐛 Don't attempt to copy items that aren't copyable
2017-06-08 15:42:39 -04:00
Matthew Dapena-Tretter
ca6254dd66
Add methods for observing dock visibility
2017-06-07 16:24:28 -07:00
Jason Rudolph
de47d3d439
🎨 Extract function: Pane::isItemAllowed(item)
2017-06-07 15:45:02 -04:00
Max Brunsfeld
f865a75c94
Fix exception on cancelling path selection when saving
...
Fixes #14722
2017-06-07 12:00:25 -07:00
Max Brunsfeld
8f106d2d44
Don't serialize undo/redo stacks when the user is idle
2017-06-07 11:21:39 -07:00
Jason Rudolph
296e407284
Check an item's allowed locations when moving/copying to pane
2017-06-07 12:59:54 -04:00
Wliu
0cd482cbf2
Merge pull request #14729 from atom/wl-fix-docks-docs
...
Fix Docks docs
2017-06-07 11:23:50 -04:00
Wliu
7c48291333
🔥 getPaneContainers from the API
2017-06-07 10:55:26 -04:00
Wliu
02258a9994
📝 Fix get{Left|Right|Bottom}Dock links
2017-06-06 23:34:47 -04:00
Wliu
55a0fcb3f2
📝 Document pane location methods in Workspace
2017-06-06 23:33:46 -04:00
Wliu
c34061a52e
📝 Document the WorkspaceCenter class
2017-06-06 23:33:29 -04:00
Max Brunsfeld
3b56ef8cbf
Merge remote-tracking branch 'origin/master' into mb-use-native-text-buffer
2017-06-06 17:12:34 -07:00
Jason Rudolph
4fecbaf4f5
Merge master into jr-fix-observe-text-editor-methods
2017-06-06 13:59:35 -04:00
Jason Rudolph
268f94b89d
Merge pull request #14695 from atom/jr-editors-live-in-workspace-center
...
Provide API for observing the active text editor
2017-06-06 10:09:52 -04:00
Jason Rudolph
0cadf7e888
Merge branch 'jr-editors-live-in-workspace-center' into jr-fix-observe-text-editor-methods
2017-06-05 17:07:31 -04:00
Antonio Scandurra
baca845e64
Fix not resetting unused styles in NodePool
2017-06-03 14:56:21 +02:00
Antonio Scandurra
f07e1eb009
Merge pull request #14698 from atom/as-ns-recycle-nodes
...
Recycle line and line number DOM nodes
2017-06-03 10:53:47 +02:00
Antonio Scandurra
ec774e143a
Fix lint errors
2017-06-03 10:52:32 +02:00
Jason Rudolph
e1719a8923
Teach Workspace::reset() to properly reset hasActiveTextEditor
2017-06-02 15:56:13 -04:00
Jason Rudolph
2347c9bdaa
Always invoke callback with current active text editor
...
This makes observeActiveTextEditor consistent with observers like
observeActivePaneItem, which always invoke the callback with the current
value, regardless of whether that value is undefined or not.
2017-06-02 15:55:00 -04:00
Jason Rudolph
9629caefb7
Remove unnecessary serialization
2017-06-02 15:09:20 -04:00
