Nathan Sobo
d042d15a50
Autoscroll to cursor on undo
...
Fixes #2815
This commit changes our autoscroll strategy for cursors significantly.
Originally, we were autoscrolling whenever the cursor's marker changed
positions. This worked well, except we didn't end up autoscrolling when
the user *attempted* to move the cursor to an invalid position, such as
moving down at the end of the buffer, due to the fact that the marker
wouldn't change.
Then, we moved to always requesting an autoscroll whenever a position
change was requested via Cursor::changePosition. This missed out on
moving the cursor when inserting text, so we then also added an explicit
autoscroll call when inserting text.
This had the problem of not autoscrolling due to undo. So finally, this
solution combines explicit autoscroll in ::changePosition to capture
intent, as well as implicit autoscrolling whenever the cursor's marker
position changes due to a textual change in the buffer. This captures
undo/redo correctly.
2014-07-07 15:21:48 -06:00
Nathan Sobo
b83f908e28
Merge pull request #2850 from atom/ns-react-account-for-padding-in-softwrap
...
Account for padding-left on scroll view when soft-wrapping lines in the React editor
2014-07-07 14:36:20 -06:00
Nathan Sobo
fad2a63a14
Account for padding-left on the scroll view when soft-wrapping lines
...
Fixes #2844
2014-07-07 14:02:24 -06:00
Nathan Sobo
2de42303d4
💄
2014-07-07 13:55:32 -06:00
Nathan Sobo
a7aed07d70
Merge pull request #2849 from atom/ns-react-fix-softwrap-scroll-left
...
Scroll React editor all the way left when soft wrap is enabled
2014-07-07 13:31:15 -06:00
Nathan Sobo
673b62f547
Scroll React editor all the way left when soft wrap is enabled
...
Fixes #2842
2014-07-07 12:26:33 -06:00
Ben Ogle
19835f2f66
Upgrade tabs to support mousewheel navigation
2014-07-07 11:04:24 -07:00
Kevin Sawicki
7474de8f7e
Upgrade to markdown-preview@0.89
2014-07-07 10:50:07 -07:00
Kevin Sawicki
84c30ef6c5
Set initial concurrency to 1 on all platforms
2014-07-07 10:26:12 -07:00
Kevin Sawicki
0aa5fa9eeb
Increase timeout on Windows CI
2014-07-07 10:14:38 -07:00
Kevin Sawicki
b5f8b159fc
Upgrade to settings-view@0.132
2014-07-07 10:05:16 -07:00
Kevin Sawicki
79357be899
Upgrade to markdown-preview@0.88
2014-07-07 09:29:21 -07:00
Kevin Sawicki
12d6a90ddc
Upgrade to wrap-guide@0.21
2014-07-07 09:13:11 -07:00
Kevin Sawicki
4eb3be6f17
Upgrade to markdown-preview@0.87
2014-07-07 09:12:29 -07:00
Kevin Sawicki
af622c6b74
Upgrade to wrap-guide@0.20
2014-07-07 07:37:51 -07:00
Kevin Sawicki
df8e0a8464
📝 Add is-focused class to cursor example
...
This is required to take effect for the default Atom light syntax
theme.
Closes #2834
2014-07-06 10:08:24 -07:00
Kevin Sawicki
a1c1879ba6
Merge pull request #2813 from atom/ks-codesign-on-windows-ci
...
Codesign on Windows CI
2014-07-05 11:48:39 -07:00
Kevin Sawicki
d1e52d4105
Restore spec task
2014-07-05 11:29:10 -07:00
Kevin Sawicki
0f01840e3e
Restore publish checks
2014-07-05 11:28:56 -07:00
Kevin Sawicki
e1945fce14
Comment out Janky check
2014-07-05 11:15:56 -07:00
Kevin Sawicki
e6ecf10616
Publish builds from this branch to test signing
2014-07-05 11:12:59 -07:00
Kevin Sawicki
b85ebbad2a
Separate /F argument to taskkill
2014-07-05 11:06:07 -07:00
Kevin Sawicki
38ba96a54f
Break up commands into two spawns
2014-07-05 10:49:25 -07:00
Kevin Sawicki
334e2ef7ab
Temporarily disable specs
2014-07-05 10:46:22 -07:00
Kevin Sawicki
58efeb8a20
Force kill on Windows
2014-07-05 10:45:48 -07:00
Kevin Sawicki
3ae6540c70
Kill all atom.exe before signing
2014-07-05 10:45:35 -07:00
Kevin Sawicki
497ac5e5ce
Add kill command for Windows
2014-07-05 10:41:45 -07:00
Kevin Sawicki
8735780473
Reenable specs
2014-07-05 10:29:50 -07:00
Kevin Sawicki
888b5ab098
Always pass specs to test signing
2014-07-05 10:19:14 -07:00
Kevin Sawicki
c897f42d51
Use JANKY_SIGNTOOL env var to sign
2014-07-05 10:19:14 -07:00
Kevin Sawicki
3c5312e834
signtool is now on the PATH
2014-07-05 10:19:14 -07:00
Kevin Sawicki
c59cbb3b25
Use full path to signtool.bat
2014-07-05 10:19:13 -07:00
Kevin Sawicki
b3da11edfb
💄 Use switch
2014-07-05 10:19:13 -07:00
Kevin Sawicki
f56b487935
Call signtool on Windows
2014-07-05 10:19:13 -07:00
Kevin Sawicki
840abd6780
Upgrade to settings-view@0.131
2014-07-05 10:17:49 -07:00
Kevin Sawicki
2e554ac819
Use cross platform path in Project::replace spec
2014-07-05 10:01:19 -07:00
Kevin Sawicki
35c7bc0eef
Upgrade to language-coffee-script@0.24
2014-07-05 08:35:49 -07:00
Ben Ogle
d99a9b0f3f
Merge pull request #2826 from atom/ns-flash-specs
...
Explicitly test removal of flash class prior to next animation frame
2014-07-04 09:53:55 -07:00
Nathan Sobo
7ac8b80172
Explicitly test removal of flash class prior to next animation frame
2014-07-04 09:56:51 -06:00
Ben Ogle
68f2bd56f0
Upgrade find-and-replace to flash the current result
2014-07-03 17:51:43 -07:00
Ben Ogle
e709b986cd
Upgrade themes to fix atom/tabs#64
2014-07-03 17:51:21 -07:00
Ben Ogle
74bdd5f0e8
Merge pull request #2794 from atom/bo-flash
...
Add ability to 'flash' selections
2014-07-03 17:48:08 -07:00
Ben Ogle
48b6c24882
Add Editor::selectionFlashDuration rather than magic number
2014-07-03 17:36:45 -07:00
Ben Ogle
e5f800ef35
💄
2014-07-03 17:32:38 -07:00
Ben Ogle
492022fdd8
Fix spec
2014-07-03 17:32:38 -07:00
Ben Ogle
cf7b87842e
Upgrade all the themes
...
Removes flash / highlighted from ui themes
Adds flash color to syntax themes
2014-07-03 17:32:38 -07:00
Ben Ogle
1838ff2502
Use ‘flash’ class rather than ‘highlighted’.
...
Pull the flash into the base theme rather than the ui themes
2014-07-03 17:32:38 -07:00
Ben Ogle
505bfc28db
fix spec
2014-07-03 17:32:37 -07:00
Ben Ogle
abbe8d2eec
Flash works for selections
2014-07-03 17:32:37 -07:00
Ben Ogle
bf33d96899
Decorations can be flashed
2014-07-03 17:32:37 -07:00
