github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-04-06 03:02:13 -04:00
Code Issues Packages Projects Releases Wiki Activity
35,864 Commits 140 Branches 571 Tags
de363cf32bf63f883f701955142591976d4dc427
Commit Graph

35864 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jordan Eldredge
de363cf32b Merge pull request #18545 from captbaritone/config-race 
Avoid sending async updates on config update
 2018-12-06 10:35:02 -08:00
Jordan Eldredge
878629dd0a Avoid sending async updates on config update 
In
7a5d727e22
the 'set-user-settings' callback was changed so that it nolonger
returned the promise created by `ConfigFile.update()`. This meant that
the logic in
[`ApplicateDelegate.onDidChangeUserSetting()`](https://github.com/atom/atom/blob/5f0231b/src/application-delegate.js#L193-L206) which uses
`.pendingSettingUpdateCount` to avoid triggering in response to calls to
ApplicationDelegate.setUserSettings` was no longer effective.

I noticed this when updating settings via the setting view. If you type
at just the right (wrong?) cadence, you'll notice that your input can
get updated with stale values.

Something like this:

```
You type            "a"      "b"            "c"
config.set          "a"      "ab"           "ac"
config.observe                        "a"         "ab"    "ac"
Input value         "a"      "ab"     "a"   "ac"  "ab"    "ac"
```

It's possible that is the same as https://github.com/atom/settings-view/issues/1062

After this change typing in settings input seems to behave as expected.
 2018-12-05 14:34:30 -08:00
simurai
aad7705687 Merge pull request #18532 from atom/sm/update-settings-view 
⬆️ settings-view@v0.257.3
 2018-12-04 16:20:51 +09:00
Max Brunsfeld
23a88fc278 ⬆️ atom-keymap in package-lock file 2018-12-03 15:02:15 -08:00
Max Brunsfeld
d036413c49 ⬆️ atom-keymap 2018-12-03 14:49:09 -08:00
simurai
fc84acb50a ⬆️ settings-view@v0.257.3 2018-12-03 12:27:39 +09:00
Max Brunsfeld
1ab1592ba8 ⬆️ text-buffer 
Refs #18518
 2018-11-30 09:39:05 -08:00
simurai
08063d67dd Merge pull request #18484 from atom/sm/atom-ui 
Migrate 'atom-ui' into core
 2018-11-29 14:29:42 +09:00
simurai
9d6e4dcee4 Merge pull request #18506 from atom/sm/readme 
Add screenshot to README
 2018-11-29 14:28:07 +09:00
Max Brunsfeld
521a9d6036 ⬆️ bracket-matcher 2018-11-27 22:47:34 -08:00
simurai
72c99b51c0 Add a title 2018-11-28 15:20:35 +09:00
simurai
75e07b18fb Update README with new header and screenshot 2018-11-28 15:15:13 +09:00
simurai
9be188141a Fix and relax some lint rules 2018-11-28 13:21:50 +09:00
Max Brunsfeld
97f7ab3438 Merge pull request #18502 from atom/mb-fold-marker-updates 
Fix typo that messed up fold marker updates
 2018-11-27 11:11:33 -08:00
Max Brunsfeld
be79ca031c Fix typo that messed up fold marker updates 2018-11-27 10:11:32 -08:00
Jason Rudolph
c3c589a1b4 Merge pull request #18501 from atom/bump-atom-version-in-package-lock-json 
Fix Atom version in package-lock.json
 2018-11-27 10:22:35 -05:00
Jason Rudolph
1ad5f87e67 Merge pull request #18500 from atom/tree-view-0.224.5 
⬆️ tree-view@0.224.5
 2018-11-27 10:16:03 -05:00
Jason Rudolph
57fa739d3d Update Atom version to 1.35.0-dev in package-lock.json 
This change should have been part of dadc11963b 🙈
 2018-11-27 09:25:27 -05:00
Jason Rudolph
ad9c63de75 ⬆️ tree-view@0.224.5 2018-11-27 09:20:35 -05:00
simurai
9eb4c06385 Import missing variables 2018-11-27 21:01:41 +09:00
Hubot
dadc11963b 1.35.0-dev 2018-11-26 17:27:50 -06:00
simurai
241a060328 Import fallback variables 
To see if it fixes the missing @use-custom-controls in less-cache
 2018-11-23 19:45:38 +09:00
simurai
ea6a65328d Update package-lock 2018-11-23 14:59:16 +09:00
simurai
4f126b311e Move fonts 2018-11-23 14:51:14 +09:00
simurai
a710f13eaa Move styles to core-ui 2018-11-23 11:44:25 +09:00
simurai
e3d3ec5e10 🔥 Remove atom-ui as a dependency 2018-11-23 11:38:42 +09:00
simurai
76ba4b12e3 Move Atom UI into Core 2018-11-23 11:38:11 +09:00
Vanessa Yuen
f1e1580594 Merge pull request #18478 from atom/gh-prerelease-0.23.0 
⬆️ github package
 2018-11-21 21:04:11 +01:00
Vanessa Yuen
27bf63d960 another version bump for github package 2018-11-21 19:10:17 +01:00
Jason Rudolph
e7a1021c5d Merge pull request #18475 from atom/electron-2-0-14 
⬆️ electron@2.0.14
 2018-11-21 11:31:15 -05:00
Jason Rudolph
a31ae7365f ⬆️ :electron: 2.0.14 2018-11-21 10:31:25 -05:00
Vanessa Yuen
32af10b6f3 commit package-lock 2018-11-21 16:11:34 +01:00
Vanessa Yuen
96fb63bc3f bump github package 2018-11-21 16:11:18 +01:00
Benjamin Gray
47c0a14517 Adjust cursor scope when at end of line (#18469) 
* Use character before newline if possible

* Add tests
 2018-11-21 15:20:57 +11:00
Max Brunsfeld
e4a0d3a890 ⬆️ bracket-matcher 2018-11-20 14:45:35 -08:00
Max Brunsfeld
fa66252b56 ⬆️ bracket-matcher 2018-11-20 13:27:33 -08:00
Max Brunsfeld
5599f8671d ⬆️ text-buffer (prerelease version => equivalent minor version) 2018-11-20 13:04:12 -08:00
Max Brunsfeld
097636b755 Merge pull request #18466 from atom/mb-language-mode-transaction-hook 
Use new .bufferDidFinishTransaction language mode hook
 2018-11-20 13:02:54 -08:00
Max Brunsfeld
597e5239a8 ⬆️ tree-sitter 2018-11-20 12:07:29 -08:00
Max Brunsfeld
31a321a7cf Use new .bufferDidFinishTransaction language mode hook 2018-11-19 22:48:24 -08:00
Max Brunsfeld
a384dde3f5 ⬆️ tree-sitter-c, tree-sitter-cpp 2018-11-18 13:38:22 -08:00
Max Brunsfeld
36d185fa4d ⬆️ tree-sitter-c, tree-sitter-cpp 2018-11-16 14:12:50 -08:00
Max Brunsfeld
27f389eb3a ⬆️ autocomplete-html 2018-11-16 10:05:51 -08:00
Max Brunsfeld
0880bdc47d ⬆️ language-javascript 2018-11-15 15:57:52 -08:00
Max Brunsfeld
f305cfd767 🐎 Avoid duplicate calls to TextBuffer.characterIndexForPosition 2018-11-15 15:55:07 -08:00
Damien Guard
b3d3a52d9e ⬆️ autocomplete-plus 2018-11-15 14:36:33 -08:00
Winston Liu
e156584a2f Merge pull request #18445 from atom/wl-update-language-gfm 
Update language-gfm
 2018-11-15 15:23:19 -05:00
Winston Liu
b513ca0d93 ⬆️ language-gfm@0.90.6 2018-11-15 13:18:35 -05:00
Winston Liu
d9d1ad7224 Merge pull request #18444 from atom/wl-update-tree-view 
Update tree-view
 2018-11-15 13:13:59 -05:00
Winston Liu
a2dec3fb1d ⬆️ tree-view@0.224.4 2018-11-15 11:47:52 -05:00