Antonio Scandurra
de6b836da4
Add test coverage for copying auto{Width,Height}
2016-08-19 14:10:59 +02:00
Antonio Scandurra
c667c77ff3
Copy auto{Width,Height} when copying an editor
2016-08-19 13:58:16 +02:00
Antonio Scandurra
1f4cd6e00d
Merge branch 'master' into ns-fix-editor-auto-height
...
# Conflicts:
# src/text-editor.coffee
2016-08-19 13:27:26 +02:00
Antonio Scandurra
473406f6b7
Merge pull request #12440 from atom/fb-serialize-panes-using-active-index
...
Serialize active pane item using index instead of URI
2016-08-19 13:10:13 +02:00
Antonio Scandurra
7c73ac002e
⬆️ spell-check
2016-08-19 13:07:54 +02:00
Antonio Scandurra
98fb29800a
Don't use deprecate API in tests
2016-08-19 12:40:28 +02:00
Nathan Sobo
4b68e2f411
Remove trailing semicolon
2016-08-19 12:36:26 +02:00
Matthew Dapena-Tretter
fd29f96af9
Serialize active pane item using index instead of URI
2016-08-19 12:36:26 +02:00
Max Brunsfeld
d25f824020
Merge pull request #12469 from atom/mb-fix-tab-length-deserialization
...
Fix tab length deserialization
2016-08-18 21:46:20 -07:00
Max Brunsfeld
26c9e5ee78
Set editor's tokenized buffer's tab length on its display layer when deserializing
2016-08-18 17:06:26 -07:00
Wliu
af48a087c3
Merge pull request #12439 from remexre/master
...
Adds configuration option for large file warning threshold.
2016-08-18 17:32:36 -04:00
Nathan Sobo
a264eaa18a
Serialize TextEditor autoHeight and autoWidth properties
2016-08-18 14:03:44 -06:00
Nathan Sobo
dd82902bf2
Disable autoHeight on text editor pane items
2016-08-18 14:03:44 -06:00
Nathan Sobo
f723bccc29
Add test coverage for deprecated implicit disabling of autoHeight
2016-08-18 14:03:44 -06:00
Nathaniel Ringo
10b3cbc00c
💚 Hopefully fixes configurable-filesize-warning limit specs.
2016-08-18 14:54:23 -05:00
Nathan Sobo
9f8f03b10f
Add test coverage for TextEditor autoHeight
2016-08-18 13:45:00 -06:00
Max Brunsfeld
17f69eeeac
Merge pull request #12463 from atom/mb-fix-editor-deserialization
...
Reset display layer after deserializing an editor
2016-08-18 10:59:57 -07:00
Max Brunsfeld
90b699f5cc
Remove some text editor ivars that are redundant w/ display layer properties
2016-08-18 10:41:11 -07:00
Max Brunsfeld
bf839ab15e
Reset display layer upon deserializing a text editor
2016-08-17 16:57:35 -07:00
Nathaniel Ringo
05602a85ff
💚 Fixes tests for configurable large-file-warning.
2016-08-17 18:11:24 -05:00
Nathan Sobo
7a49013057
Only create a single deprecation warning per editor and improve message
2016-08-17 16:58:17 -06:00
Nathaniel Ringo
7be9ff527f
🎨 Improves customizable-size-warning spec styling.
2016-08-17 17:36:54 -05:00
Nathan Sobo
67313aec8d
Default editor height to 100%
...
Previously, when autoHeight was assigned to false on the editor, we would assign an inline style of height: 100%. This preserves the essence of that behavior without prohibiting users from assigning their own height via more specific CSS rules.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2016-08-17 16:14:04 -06:00
Nathan Sobo
6a0b4d8fc0
Default autoWidth in getter method to match autoHeight
2016-08-17 15:52:51 -06:00
Nathan Sobo
13c00995d4
Return default value of true from TextEditor.getAutoHeight
...
When we need to check for unassigned in the deprecated code path, we
can just read the instance variable directly to avoid getting the
deafult.
Signed-off-by: Antonio Scandurra <as-cii@github.com >
2016-08-17 15:52:51 -06:00
Nathan Sobo
106621e161
Deprecate automatic assignment of autoHeight for text editors
...
Previously, we attempted to automatically determine whether the editor’s
height should be based on the editor’s content or the height of its
container. Unfortunately, DOM APIs are insufficient to make this
determination in a complete way, leading to unpredictable behavior.
This PR deprecates the automatic determination of this behavior. By
default, editors base their height on their content. If an editor has
an explicit height assigned via its style or is positioned absolute with
an explicit top and bottom, we disable the content-based autoHeight and
log a deprecation warning telling the user to assign autoHeight
explicitly.
This paves the way to add an autoWidth setting, which will default to
false.
2016-08-17 15:52:51 -06:00
Nathaniel Ringo
324bf649ea
Improves specs for configurable large file limit.
2016-08-17 15:14:22 -05:00
Nathan Sobo
351bad432b
Merge pull request #12448 from atom/as-editor-auto-width
...
Introduce autoWidth for TextEditors
2016-08-17 12:55:54 -06:00
Nathaniel Ringo
5a1def03ac
Updates spec for configurable large file limit.
2016-08-17 13:37:36 -05:00
Antonio Scandurra
1587dcbe89
Take the gutter width into account when sizing TextEditorElement
2016-08-17 19:21:56 +02:00
Antonio Scandurra
c37138e09e
Revert refactoring to make the diff shorter
2016-08-17 18:08:02 +02:00
Antonio Scandurra
3642292302
🔥 debugger
2016-08-17 18:05:58 +02:00
Antonio Scandurra
6f0fd965cd
Clear out width on TextEditorElement only if autoWidth was previously on
2016-08-17 18:05:16 +02:00
Antonio Scandurra
e71027ed36
Ensure editors don't scroll or show scrollbars when autoWidth is enabled
2016-08-17 17:58:36 +02:00
Antonio Scandurra
5b44b51150
🎨 Clarify naming
2016-08-17 17:20:24 +02:00
Antonio Scandurra
e8f2e3a608
Size TextEditorElement according to the autoWidth property
2016-08-17 16:20:00 +02:00
Antonio Scandurra
2e37d7f0cf
Change state.content.width based on autoWidth
2016-08-17 16:14:57 +02:00
Antonio Scandurra
683bf37907
Add autoWidth to TextEditor
2016-08-17 16:14:36 +02:00
Nathaniel Ringo
b32b8b40fe
Adds configuration option for large file warning threshold.
2016-08-16 16:43:16 -05:00
Max Brunsfeld
f376316d60
Merge pull request #12125 from atom/ns-mb-detangle-editor
...
Remove some of the TextEditor class's Atom-specific dependencies
2016-08-16 12:07:42 -07:00
Max Brunsfeld
c5a6e9c697
Merge branch 'master' into ns-mb-detangle-editor
2016-08-16 09:11:11 -07:00
Max Brunsfeld
782b070964
Use es6 export in null-grammar.js
2016-08-16 09:03:50 -07:00
Antonio Scandurra
2b3adaeace
Merge pull request #12393 from atom/as-remove-backup-before-saving
...
Remove config option `editor.backUpBeforeSaving`
2016-08-16 13:29:59 +02:00
Max Brunsfeld
2fa48a13e4
Merge pull request #12434 from atom/mb-atom-home-from-shell-child-process
...
Allow ATOM_HOME to be reassigned if the new value is valid
2016-08-15 17:50:19 -07:00
Max Brunsfeld
8702b4ca47
Remove 'Some textSome textSome textSome text'
2016-08-15 17:12:40 -07:00
Max Brunsfeld
8018dc9d57
Allow ATOM_HOME to be reassigned if the new value is valid
2016-08-15 17:05:18 -07:00
Max Brunsfeld
4b0183d074
Remove extraneous TextEditor setter methods
2016-08-15 16:45:10 -07:00
Max Brunsfeld
0d099d2fd5
Serialize all TextEditor parameters needed for the DisplayLayer
2016-08-15 15:51:22 -07:00
Max Brunsfeld
4bcdbf4d2f
Don't have registry update any editors before initial packages are loaded
2016-08-15 15:29:27 -07:00
Max Brunsfeld
1c99c399d1
Merge branch 'master' into ns-mb-detangle-editor
2016-08-15 11:17:07 -07:00
