Nathan Sobo
df4ea9293d
Build DisplayBufferMarker object to help track marker screen positions
...
There are 3 failures, which I think are attributable to the fact that
I'm not emitting events from the when the selection tail changes, and
I'm not emitting redundant events when the head is changed to the
same position it was previously, whereas before I wasn't guarding
against redundant events.
2013-02-02 21:11:42 -07:00
Nathan Sobo
60304b76b1
Don't cancel a snippet if the cursor moves due to a buffer change
2013-02-02 18:01:18 -07:00
Nathan Sobo
bd96db781e
Pass old/new buffer and screen positions to marker position observers
...
This is needed by the snippets package, which needs to know where the
cursor was previously when it moves to decide whether to cancel the
current snippet.
2013-02-02 18:00:35 -07:00
Nathan Sobo
e25d83ccbc
Use new addEqualityTester method to employ _.isEqual in specs
2013-02-02 17:58:39 -07:00
Nathan Sobo
d144dd4efe
Merge branch 'dev' into better-anchors
2013-02-02 17:03:57 -07:00
Nathan Sobo
94f1630152
Bind window focus and focusout events separately to fix spec
2013-02-02 17:02:07 -07:00
Nathan Sobo
7867d0cb3b
Fix spec for 'focused' to 'is-focused' class rename.
2013-02-02 16:55:51 -07:00
Nathan Sobo
abafb541df
Merge remote-tracking branch 'origin/dev' into better-anchors
2013-02-02 16:47:09 -07:00
Nathan Sobo
f6ea6a39d9
Remove anchorPoint state from EditSession
2013-02-02 16:46:25 -07:00
Nathan Sobo
aa076a0bf2
Remove focused specs
2013-02-02 16:45:15 -07:00
Nathan Sobo
80b39ae263
Replace mentions of 'anchor' with 'tail' in selection and its spec
2013-02-02 16:44:13 -07:00
Nathan Sobo
6beee10160
Replace anchor w/ marker in selection destruction spec
2013-02-02 16:41:57 -07:00
Nathan Sobo
12425b796c
Tweak specs now that buffer changes don't autoscroll the cursor
2013-02-02 16:34:28 -07:00
Nathan Sobo
e53403718a
Tell marker head observers if a move was caused by a buffer change
...
This is used by cursor to only autoscroll when the marker head is
explicitly moved, so that passive movements caused by buffer insertions
don't trigger autoscrolling.
2013-02-02 16:17:14 -07:00
Nathan Sobo
bd1a100d17
Always wrap marker screen positions at soft newlines
2013-02-02 15:59:08 -07:00
Nathan Sobo
c865b9f53a
Update selection autoscroll specs with 3-valued logic
...
If autoscroll is true, we center the view on the selection. If false,
we do no autoscrolling at all. And if undefined we autoscroll to the
cursor.
2013-02-02 15:58:35 -07:00
Nathan Sobo
cb6de5b2a4
Honor autoscroll option when setting a selection's buffer range
...
If we pass an explicit autoscroll option when selection, we don't want
to autoscroll the cursor. If the option is true, we'll autoscroll to
the middle of the selection. If the option is false, we don't want any
autoscrolling, including to the cursor. The cursor should only autoscroll
when the option is undefined.
2013-02-02 15:17:24 -07:00
Kevin Sawicki
04cfdc7c61
💄
2013-02-02 14:10:32 -08:00
Nathan Sobo
4a191586db
Ensure we don't try to draw a destroyed selection on editor refresh
...
Destroying the cursor will cause a redraw, which causes a problem when
we execute it synchronously in specs because destroying the cursor also
destroys the marker associated with the selection. Here we remove the
selection first to avoid this problem.
2013-02-02 15:10:01 -07:00
Kevin Sawicki
6efdd7b54b
Only start worker if project has path
2013-02-02 14:09:59 -08:00
Nathan Sobo
3d8406f5a3
Clip screen positions before translating to buffer positions
2013-02-02 15:07:17 -07:00
Nathan Sobo
752383651d
Don't add bufferChange to DisplayBuffer change events
2013-02-02 15:01:42 -07:00
Nathan Sobo
5e56206fcc
This never should have been checked in.
2013-02-02 15:00:54 -07:00
Kevin Sawicki
5cd3c04702
Load fuzzy finder paths in web worker at startup
...
Previously the paths were first loaded when the fuzzy finder
view was first attached.
Now a web worker is started when the package activates that
sets the paths on the fuzzy finder view the first time it
displays if the worker has completed by the time an event occurs
that displays the view.
2013-02-02 12:47:46 -08:00
Kevin Sawicki
a3b95a923d
Don't update unless view is on the DOM
2013-02-02 11:28:29 -08:00
Kevin Sawicki
387e73bb50
Clear previous interval before setting new one
2013-02-02 11:25:38 -08:00
Jon Rohan
fa940d0386
Merge pull request #168 from github/window-focused
...
Atom Window Focused
2013-02-01 17:50:28 -08:00
Jon Rohan
0d2a328dcc
making the editor .focused .is-focused for symmetry
2013-02-01 19:23:52 -05:00
Kevin Sawicki
999bca5871
💄
2013-02-01 16:21:14 -08:00
Kevin Sawicki
69097bee50
Kill trailing newline and inline empty arrays
2013-02-01 16:20:25 -08:00
Kevin Sawicki
83b6a93684
Add initial CSON pretty printer
2013-02-01 16:15:54 -08:00
Jon Rohan
a004433edd
adding dark theme focused
2013-02-01 19:15:39 -05:00
Jon Rohan
e54c3d8fbb
adding is-focused to body, and styling light ui
2013-02-01 18:40:53 -05:00
Justin Palmer
672a4a17a7
kill the svg namespace, d3 uses createElementNS
2013-02-01 15:22:08 -08:00
Corey Johnson
4e60bf6501
Fix focused spec bug
2013-02-01 14:54:26 -08:00
Justin Palmer
6e31e278e8
Merge pull request #226 from github/ui-dark-tweaks
...
Ui dark tweaks
2013-02-01 14:29:17 -08:00
Justin Palmer
52285e4c78
delete key defeats the :octocat:
2013-02-01 14:19:39 -08:00
Justin Palmer
0a46020914
line up results with input box
2013-02-01 14:18:52 -08:00
Corey Johnson
ab8537f317
Upgrade Jasmine to 1.3.1
2013-02-01 14:13:56 -08:00
Justin Palmer
da6bbd70f9
cleanup look of command panel
2013-02-01 14:09:52 -08:00
Justin Palmer
615f60e729
Merge pull request #221 from github/github-code-theme
...
Creating GitHub_Dark and GitHub_Light.
2013-02-01 13:53:19 -08:00
Justin Palmer
85ee0367ea
tone down wrap guide in atom-dark
2013-02-01 13:45:39 -08:00
Justin Palmer
edc982484b
etched style for atom-light-ui
2013-02-01 13:45:17 -08:00
Justin Palmer
5a96f3f8cd
use etched style for pane edges
2013-02-01 13:38:42 -08:00
Justin Palmer
6734c2fb37
tone down the core colors slightly so they work in harmony with atom-dark-ui
2013-02-01 13:12:09 -08:00
Kevin Sawicki
d7d473c3d6
Doc styling new things in both light and dark themes
2013-02-01 12:26:12 -08:00
Jon Rohan
a7b28f0dec
updating default config.json to use atom-dark-ui and atom-dark-syntax
2013-02-01 14:42:49 -05:00
Jon Rohan
b9b3daba77
Merge branch 'dev' into github-code-theme
...
Conflicts:
Rakefile
2013-02-01 14:28:23 -05:00
Justin Palmer
eb349eca69
Merge pull request #220 from github/better-dot-atom
...
A better dot atom
2013-02-01 11:26:02 -08:00
Kevin Sawicki
5285ee2b76
16 is the new 12
2013-02-01 11:17:12 -08:00
