Commit Graph

32853 Commits

Author SHA1 Message Date
Ash Wilson
e2c9cc1692 Private diagnostic method to dump the active watchers 2017-08-18 09:08:34 -04:00
Ash Wilson
a0bdc50535 Return a Promise from watchPath 2017-08-17 22:48:03 -04:00
Ash Wilson
fb5f197ae7 Protect against stale NativeWatcher events 2017-08-17 22:47:39 -04:00
Ash Wilson
aa26eba678 Jasmine, not Mocha 2017-08-17 22:01:25 -04:00
Ash Wilson
6ffb3f3ff2 Test first 2017-08-17 21:59:32 -04:00
Nathan Sobo
f41be89d5e Merge pull request #15372 from atom/as-ns-fractional-pixel-ratio-support
Always round GPU layer dimensions to physical pixel boundaries
2017-08-17 17:13:52 -06:00
Damien Guard
a533680fa0 Exclude x86/TEST from build matrix on appveyor for speed 2017-08-17 14:23:18 -07:00
Ian Olsen
325ff2e25c Merge pull request #15373 from atom/revert-14701-pb-remove-unneeded-files-win
Revert "Remove unneeded files from build result"
2017-08-17 14:11:44 -07:00
Ian Olsen
e8251bdb97 Revert "Remove unneeded files from build result" 2017-08-17 13:49:25 -07:00
Ian Olsen
7daae84bc9 Merge pull request #14701 from atom/pb-remove-unneeded-files-win
Remove unneeded files from build result
2017-08-17 11:36:28 -07:00
Max Brunsfeld
2fa6513cbd Merge pull request #15228 from atom/mb-fix-set-text-via-diff-bug
Upgrade text-buffer for setTextViaDiff fix
2017-08-17 11:09:36 -07:00
Antonio Scandurra
88a06f8c5b Always round GPU layer dimensions to physical pixel boundaries
This ensure subpixel anti-aliasing works when `window.devicePixelRatio`
is not an integer.

Signed-off-by: Nathan Sobo <nathan@github.com>
2017-08-17 19:56:13 +02:00
Max Brunsfeld
15f7fe9f22 ⬆️ text-buffer 2017-08-17 10:14:00 -07:00
Nathan Sobo
a1df975ac6 Merge pull request #15276 from captbaritone/rm-legacy
Remove unused methods to translate legacy menu items
2017-08-17 09:52:56 -06:00
Nathan Sobo
e80658081a Merge pull request #15327 from captbaritone/accel-2
Base context menu accelerators on activeElement
2017-08-17 09:19:10 -06:00
Nathan Sobo
927fa3c9cb Merge pull request #15367 from atom/as-fix-scrollbar-visibility
Set visibility: hidden on dummy scrollbars if native ones are invisible
2017-08-17 09:17:30 -06:00
Nathan Sobo
6c20d6199f Merge pull request #15359 from atom/as-fix-folding
Fix folding for lines that contain a comment
2017-08-17 09:15:39 -06:00
Antonio Scandurra
1ffc8997d2 Set visibility: hidden on dummy scrollbars if native ones are invisible
This prevents the cursor from unexpectedly changing when approaching the
bottom/right corner of the editor with the mouse, even when no scrollbar
is being shown.
2017-08-17 15:11:32 +02:00
Antonio Scandurra
c99ac52152 Fix folding for lines that contain a comment
In attempting to optimize the performance of `isFoldableAtBufferRow` in
3c87b74, we mistakenly introduced a bug that caused lines that contained
a comment but didn't start with one to not be foldable anymore.

With this commit we are restoring the previous behavior, thus only
disabling folding for lines that start with a comment (ignoring leading
whitespaces).
2017-08-17 14:28:30 +02:00
simurai
e9e63a5f90 ⬆️ one-dark/light-ui@v1.10.7 2017-08-17 20:48:27 +09:00
Antonio Scandurra
0be3e9441b Merge pull request #15357 from atom/as-ignore-invalid-scroll-top-left
Ignore scroll requests to NaN, null or undefined positions
2017-08-17 11:57:55 +02:00
Antonio Scandurra
1b5ed62e4f Ignore scroll requests to NaN, null or undefined positions 2017-08-17 09:17:52 +02:00
Nathan Sobo
cd8233028d Merge pull request #15347 from atom/ns-capture-mouseup
Use capture phase for mouseup handler
2017-08-16 17:24:37 -06:00
Nathan Sobo
d88ddc3d4d Merge pull request #15345 from atom/ns-round-max-scroll-top
Round return values of getMaxScrollTop, getScrollHeight
2017-08-16 17:24:09 -06:00
Nathan Sobo
ccb3aaacf7 Merge pull request #15346 from atom/ns-fix-alt-bindings
Suppress default-prevented composition events on compositionstart instead of compositionupdate
2017-08-16 17:23:50 -06:00
Nathan Sobo
3926dac789 Use capture phase for mouseup handler
This ensures that we always handle the mouseup even if the mouse is
outside of the editor when the button is released
2017-08-16 16:28:18 -06:00
Nathan Sobo
3d9b49056e Suppress default-prevented composition events on compositionstart
This avoids creating a composition checkpoint and reverting to it on the
next keystroke, which causes the cursor to move.
2017-08-16 16:06:53 -06:00
Nathan Sobo
9cf7f609f5 Round return values of getMaxScrollTop/Left 2017-08-16 15:59:04 -06:00
Katrina Uychaco
d2a266e369 ⬆️ text-buffer@13.0.10 2017-08-16 14:21:57 -07:00
Nathan Sobo
72322985d9 Merge pull request #15337 from atom/ns-remeasure-longest-line
Remeasure the longest line's width when the font size changes
2017-08-16 14:32:22 -06:00
Jordan Eldredge
228f65da5f Base context menu accelerators on activeElement
Addresses issue pointed by out @nathansobo in #15277 where keybindings
for unfocusable nodes were being surfaced as accelerator indicators in
context menus.

When you right click in the DOM, your focus goes to the first focusable
ancestor of your click target. This change uses the ancestor that you
are actually focused on when looking for avaliable key bindings rather
than using the event target directly. This ensures that any surfaced key
bindings are actually reachable.
2017-08-16 11:58:05 -07:00
Nathan Sobo
2bcfd934c0 Fix tests by ignoring off screen lines
Also, clear the dataset when recycling DOM elements

Signed-off-by: Antonio Scandurra <as-cii@github.com>
2017-08-16 12:31:42 -06:00
Antonio Scandurra
15e3fbaa07 Merge pull request #15339 from atom/ns-as-clear-lines-to-measure-later
Only clear linesToMeasure when we have actually measured
2017-08-16 20:08:59 +02:00
Nathan Sobo
9d356020c5 Remeasure the longest line's width when the font size changes 2017-08-16 11:53:55 -06:00
Nathan Sobo
c626836b2e Only clear linesToMeasure when we have actually measured
Previously, as soon as we decided to render linesToMeasure, we would
clear them out. However, if a second update interleaved with the update
that initially requested measurement, it could cause the requested lines
to not be present when the measurement phase from the first update
occurred. Now, any additional updates will only add to the set of lines
that need to be measured until the measurement phase actually happens.

Signed-off-by: Antonio Scandurra <as-cii@github.com>
2017-08-16 11:28:58 -06:00
Nathan Sobo
b9421f721e Merge pull request #15338 from atom/ns-hide-extra-lines-to-measure
Hide off-screen lines when we render them for measurement
2017-08-16 10:45:29 -06:00
Nathan Sobo
c398fe66c9 Hide off-screen lines when we render them for measurement 2017-08-16 10:00:57 -06:00
Bryant Ung
da2c3fb56b Revert "⬆️ autocomplete-plus@v2.35.8"
This reverts commit 3c2f257155.
2017-08-15 20:47:32 -07:00
Wliu
aac5458f3c ⬆️ settings-view@0.251.5 2017-08-15 22:01:26 -04:00
Nathan Sobo
e9a00ce9b3 Merge pull request #15324 from atom/ns-fix-mousewheel-handling
Only scroll one axis at a time, whichever has the greater delta
2017-08-15 19:29:36 -06:00
simurai
3c2f257155 ⬆️ autocomplete-plus@v2.35.8 2017-08-16 10:17:19 +09:00
Nathan Sobo
de456159a7 Merge pull request #15322 from atom/ns-move-placeholder-text
Move placeholder text inside lines div
2017-08-15 18:13:23 -06:00
Ian Olsen
edcac6897f Merge branch 'master' into pb-remove-unneeded-files-win 2017-08-15 16:12:15 -07:00
Nathan Sobo
4493ae2270 Only scroll one axis at a time, whichever has the greater delta 2017-08-15 16:08:07 -06:00
Nathan Sobo
b35708b8cf Add test for placeholder text positioning 2017-08-15 15:48:18 -06:00
Nathan Sobo
c9b558a08a Move placeholder text inside .lines div
If themes apply padding to the .lines div, the placeholder text looks
mis-aligned unless it is placed within the .lines div
2017-08-15 15:38:04 -06:00
Nathan Sobo
586b818bae Merge pull request #15317 from atom/as-fix-wrong-measurements
Move cursors container inside lines container
2017-08-15 11:38:54 -06:00
Antonio Scandurra
382e1b402a ⬆️ apm 2017-08-15 19:25:01 +02:00
Antonio Scandurra
3d71e627eb Move cursors container inside lines container
This will ensure that applying any style that changes the location of
the lines container will also correctly position the cursors.
2017-08-15 18:44:23 +02:00
Nathan Sobo
8e6497bfba Merge pull request #15277 from captbaritone/accel
Add accelerator indicators to context menus
2017-08-15 10:40:35 -06:00