Commit Graph

13077 Commits

Author SHA1 Message Date
Antonio Scandurra
e51bad5618 🐛 Install WindowEventHandler in ctor 2015-10-13 12:38:45 +02:00
Antonio Scandurra
3ac0656a26 Reset Workspace before Project
Otherwise some paths will be leaked.
2015-10-13 11:29:51 +02:00
Antonio Scandurra
cf5d94f084 Return a promise in test runners 2015-10-13 09:02:37 +02:00
Antonio Scandurra
4a59da9194 Express timeout in seconds 2015-10-13 08:35:02 +02:00
Nathan Sobo
f7a3e6c425 Don’t load base style sheets until config is loaded
We need to know what themes are active in order to load the correct LESS
variables.
2015-10-12 16:12:46 -06:00
Nathan Sobo
d4c88cc7fd Merge branch 'master' into ns-alternative-test-env 2015-10-12 15:55:28 -06:00
Nathan Sobo
69e8b0cfb1 Prevent title change during specs 2015-10-12 15:19:55 -06:00
Kevin Sawicki
21d11daf0c Merge pull request #9101 from atom/tj-fix-dragging-and-dropping-files
Fix #4300 by preventing 'will-navigate' event from firing
2015-10-12 12:01:41 -07:00
Antonio Scandurra
3ee0be33d5 🐎 Speed up test suite by disposing Project::emitter 2015-10-12 19:46:12 +02:00
Ross Allen
41984a2317 Add onDidStopChangingActivePaneItem for async callbacks
`onDidChangeActivePaneItem` is called synchronously when the active pane
item changes, and several non-critical actions preform work on that
event. Critical UI feedback, like changing the active tab, needs to
happen synchronously, but most other functionality should be run
asynchronously.
2015-10-12 10:24:07 -07:00
Antonio Scandurra
304d35a300 Shim process stdout and stderr 2015-10-12 15:39:56 +02:00
Antonio Scandurra
56e13bba69 Reset Workspace in AtomEnvironment 2015-10-12 15:01:00 +02:00
Antonio Scandurra
612664fd4d 📝 Remember how/when to reset AtomEnviroment::workspace 2015-10-12 09:00:58 +02:00
Antonio Scandurra
aebc1229f1 Always install uncaught error handler 2015-10-12 08:29:43 +02:00
Antonio Scandurra
e1a1474b8d 🐛 Clear views after resetting everything else
This prevents a bug where calling `::getView` returns two different instances if
such method is invoked after views are cleared out (e.g. packages deactivation
in `packageManager.reset()`).
2015-10-11 19:27:19 +02:00
Antonio Scandurra
f77f62625e Add activateItem config to Workspace::open
Now that we have deleted `Project::open(...)`, all the methods that previously
used it need to switch to `Workspace::open(...)` instead. These two methods,
however, are not idempotent because the latter performs additional operations.

Since some specs relied on not activating an item after opening it, this commit
adds a parameter to prevent such activation.

Refs: 1ebcf166c7
2015-10-11 18:24:42 +02:00
Max Brunsfeld
74c0836be5 🔥 Duplicate devMode/inDevMode parameter to Package, PackageManager 2015-10-09 17:34:22 -07:00
Max Brunsfeld
75463829f9 Pass inDevMode to package-manager as a boolean value
Rather than as a bound function
2015-10-09 17:26:19 -07:00
Max Brunsfeld
369f3d2648 Don't use atom.{notifications,config,deserializers,confirm} in Pane
Still need to get rid of one use of showSaveDialogSync
2015-10-09 17:18:26 -07:00
Thomas Johansen
af36a23e95 🐛 Fix #4300 by preventing 'will-navigate' 2015-10-10 01:21:49 +02:00
Max Brunsfeld
778023c78b Make factory for StylesElements on atom.styles 2015-10-09 13:46:32 -07:00
Antonio Scandurra
1a8beef74f 🐛 Load config schema before loading base stylesheets 2015-10-09 19:10:55 +02:00
Antonio Scandurra
4ce814320d Call side effects methods after instantiating instance variables
This prevents a 🐛 where the `onDidLoadBundledKeymaps` was fired before
`MenuManager` had the chance to listen to it thereby not showing the appropriate
menu entries.
2015-10-09 17:41:33 +02:00
Antonio Scandurra
60e4b78da3 Move package reset down into PackageManager 2015-10-09 10:04:04 +02:00
Antonio Scandurra
4863b71fd7 Set timeout in the main process 2015-10-09 09:20:19 +02:00
Max Brunsfeld
43d0241685 Reset project in AtomEnvironment::reset 2015-10-08 17:54:43 -07:00
Max Brunsfeld
7617c35856 Rename AtomEnvironment::removeEditorWindow -> ::destroy 2015-10-08 17:51:27 -07:00
Max Brunsfeld
5c545c0898 Don't register CommandRegistry's window listeners in AtomEnvironment constructor 2015-10-08 17:34:41 -07:00
Max Brunsfeld
04c85e3aae Avoid using atom global in registerDefaultCommands 2015-10-08 17:21:55 -07:00
Max Brunsfeld
4835fef7be Reset service-hub in AtomEnvironment::reset() 2015-10-08 16:29:54 -07:00
Max Brunsfeld
a9c8640ab1 Stop using directory providers when their providing packages are deactivated 2015-10-08 15:20:13 -07:00
Max Brunsfeld
2af6f995b4 Clean up repository-providers when their providing packages are are deactivated 2015-10-08 13:49:37 -07:00
Max Brunsfeld
fb2a1284f6 Clear notifications and context menus in AtomEnvironment::reset 2015-10-08 12:41:07 -07:00
Max Brunsfeld
d0283d8f05 Reset Clipboard in AtomEnvironment::reset 2015-10-08 11:56:12 -07:00
Max Brunsfeld
9664d34750 Reset MenuManager in AtomEnvironment::reset 2015-10-08 11:56:12 -07:00
Antonio Scandurra
fa41cf68a4 🐛 Fix ::registerDefaultOpeners 2015-10-08 15:49:01 +02:00
Antonio Scandurra
24365b95df 💄 Satisfy linter requirements 2015-10-08 14:13:49 +02:00
Antonio Scandurra
9ac4034135 🔥 Drop --spec-directory 2015-10-08 14:04:23 +02:00
Antonio Scandurra
5da32540b1 🎨 2015-10-08 11:54:11 +02:00
Antonio Scandurra
1d280e8d92 Introduce timeout option
The idea with this commit is to implement a timeout functionality that does not
rely on a system utility (such as unix `timeout`). Tests could hang because of a
CPU-bound task and, as a result, we need to handle timeouts in a separate
process.

An ideal implementation would first spawn the timeout, which in turn would spawn
the tests, acting as a supervisor and making sure they do not exceed the
supplied time. However, setting up such an environment would have been trickier,
thus the test process spawns the timeout cop before running any test. This, in
turn, invokes a `setTimeout` function and kills the parent process as soon as
the timeout gets triggered, logging to console the reason why the parent process
was killed (and exiting the parent process with code 130).

I haven't used `Task` because, in order to log stuff to the console, we need to
fork the ChildProcess from `remote`, as otherwise nothing gets written out.
2015-10-08 11:38:48 +02:00
Nathan Sobo
4746153cc5 Merge branch 'master' into ns-alternative-test-env 2015-10-07 16:53:39 -05:00
Nathan Sobo
8e834794a9 Remove scroll listener on destroy so we don’t call undefined onScroll
/cc @izuzak because no PR, @as-cii because this fixes an unexpected
issue with your change.
2015-10-07 16:52:37 -05:00
Nathan Sobo
4808c9f9e8 Eliminate config and confirm global references in Pane 2015-10-07 16:32:47 -05:00
Nathan Sobo
4c51d29868 Merge remote-tracking branch 'origin/master' into ns-alternative-test-env 2015-10-07 16:10:29 -05:00
Nathan Sobo
3636eb35d8 Merge pull request #8811 from atom/as-double-reflow-measurements
DOM-based measurements
2015-10-07 15:43:59 -05:00
Nathan Sobo
aa682d5b19 Restore initial styles in AtomEnvironment::reset 2015-10-07 15:25:06 -05:00
Antonio Scandurra
c3d85f85a4 🔥 Remove unused LOC 2015-10-07 15:25:06 -05:00
Antonio Scandurra
52c43a71d3 Pass legacyTestRunner parameter 2015-10-07 15:25:06 -05:00
Max Brunsfeld
13301b551c 📝 Document Workspace::buildTextEditor 2015-10-07 15:25:06 -05:00
Max Brunsfeld
5aee514ef5 🔥 debuggers 2015-10-07 15:25:05 -05:00