Commit Graph

26325 Commits

Author SHA1 Message Date
Nathan Sobo
ff681752f7 Add a nextViewUpdatePromise helper so we get stack traces from timeouts 2015-11-09 00:35:33 -07:00
Nathan Sobo
e9dfc080a3 Convert text-editor-component-spec to Babel for async/await
It's much easier to reason about async/await than Jasmine's
built-in queuing system, and using them made it easier to
debug flaky async tests.
2015-11-09 00:35:32 -07:00
Nathan Sobo
bddb601b45 ⬆️ snippets 2015-11-09 00:35:32 -07:00
Nathan Sobo
51a7c9ea68 Always set devMode to true for spec windows 2015-11-09 00:35:32 -07:00
Nathan Sobo
7edb80155a ⬆️ text-buffer 2015-11-09 00:35:32 -07:00
Nathan Sobo
80adbe8562 ⬆️ find-and-replace 2015-11-09 00:35:32 -07:00
Nathan Sobo
3a4199a0cd Allow (start/end)(Buffer/Screen)Position in findMarker queries on layers 2015-11-09 00:35:32 -07:00
Nathan Sobo
533146bc6a Document new APIs 2015-11-09 00:35:32 -07:00
Nathan Sobo
3f4d8d0104 ⬆️ text-buffer 2015-11-09 00:35:31 -07:00
Nathan Sobo
9714f2e729 Emit decoration events synchronously in legacy spec environment
This is needed to keep a bunch of package tests passing that expect
synchronous decoration updates.
2015-11-09 00:35:31 -07:00
Nathan Sobo
5e9cec2ec7 ⬆️ text-buffer 2015-11-09 00:35:31 -07:00
Nathan Sobo
f6859210d0 ⬆️ text-buffer 2015-11-09 00:35:31 -07:00
Nathan Sobo
9ee3d53975 Destroy the selections marker layer when editors are destroyed 2015-11-09 00:35:31 -07:00
Nathan Sobo
2f81e5faac Store folds in their own marker layer 2015-11-09 00:35:31 -07:00
Nathan Sobo
29bb1bb31b Add TextEditor-level marker layers and use them for selections 2015-11-09 00:35:31 -07:00
Nathan Sobo
1ee6384332 Add TextEditorMarkerLayer 2015-11-09 00:35:31 -07:00
Nathan Sobo
b1a5b58fa2 Rename Marker to TextEditorMarker to resolve ambiguity w/ TextBuffer API
We expose both kinds of markers in Atom, and the docs were actually
wrong when we refer to Markers from TextBuffer because it linked to the
TextEditor layer’s Marker implementation. This will clarify the
difference.
2015-11-09 00:35:30 -07:00
Nathan Sobo
b508cc6d9f Fix linter error 2015-11-09 00:35:30 -07:00
Nathan Sobo
205b6bf66c ⬆️ text-buffer 2015-11-09 00:35:28 -07:00
Nathan Sobo
78513f4528 Remove duplicated method definition 2015-11-09 00:35:28 -07:00
Nathan Sobo
4139863cee ⬆️ text-buffer (pre-release) 2015-11-09 00:35:28 -07:00
Nathan Sobo
a3ff0ad75a 🎨 Rename method 2015-11-09 00:35:28 -07:00
Nathan Sobo
75d0a0820c Allow properties to be overridden for a single marker in LayerDecoration 2015-11-09 00:35:28 -07:00
Nathan Sobo
acf142863c Add TextEditor::decorateMarkerLayer 2015-11-09 00:35:27 -07:00
Nathan Sobo
20f4c61325 Drop stray sample.js file 2015-11-09 00:35:27 -07:00
Nathan Sobo
3a25fe4975 Remove id from decoration properties
It doesn’t make sense to include this when we’ll reuse the same
properties for multiple decoration instances when decorating marker
layers.
2015-11-09 00:35:27 -07:00
Nathan Sobo
7d22ed788c Test decorateMarker + decorationStateForScreenRowRange 2015-11-09 00:35:27 -07:00
Nathan Sobo
9d6168aac8 Fix gutter spec indentation 2015-11-09 00:35:27 -07:00
Nathan Sobo
d7b0ab9179 Simplify updating of custom gutter decoration state 2015-11-09 00:35:27 -07:00
Nathan Sobo
92ed7c8b15 Don’t return Decoration objects from model to view
Preparation for LayerDecorations, in which individual decoration objects
won’t exist for every marker.
2015-11-09 00:35:27 -07:00
Nathan Sobo
d46091d7e5 Remove dead code 2015-11-09 00:35:27 -07:00
Nathan Sobo
800440d5ca Remove logging 2015-11-09 00:35:27 -07:00
Nathan Sobo
3c98c30b43 Wait for animation frames synchronously after actions
This avoids test flakiness, presumably due to an animation frame firing
before we have a chance to wait due to jasmine’s queueing.
2015-11-09 00:35:26 -07:00
Nathan Sobo
2af010e729 Remove dead test
It tests functionality that no longer matters since we don’t subscribe
to decorations being destroyed in DisplayBuffer
2015-11-09 00:35:26 -07:00
Nathan Sobo
0169c1160e Wait for next DOM update synchronously after change to avoid flakiness 2015-11-09 00:35:26 -07:00
Nathan Sobo
0ac42a12f3 Add waitsForNextDOMUpdate helper function 2015-11-09 00:35:18 -07:00
Nathan Sobo
4b5e4d02eb Use real clock in text-editor-component-spec
This will make it much easier to test asynchronous update logic.
2015-11-09 00:35:18 -07:00
Nathan Sobo
1aefb22789 Add ViewRegistry.prototype.getNextUpdatePromise
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2015-11-09 00:35:18 -07:00
Max Brunsfeld
cdaac9dfcc wip 2015-11-09 00:35:18 -07:00
Max Brunsfeld
50d5151a3e ⬆️ text-buffer (pre-release) 2015-11-09 00:35:18 -07:00
Ivan Žužak
e077f8a24b Merge pull request #9333 from atom/iz-contributing-guide-bugs-and-features
Add section on reporting bugs to contributing guide
2015-11-08 22:13:09 +01:00
Ivan Žužak
e711e5e3ef 🎨 🔨 words 2015-11-08 22:12:07 +01:00
Ivan Žužak
1c12fbaed1 Use consistent order and clarify screenshots and gifs item 2015-11-08 21:40:18 +01:00
Ivan Žužak
9f42638617 Add GIF recording tools for Linux 2015-11-08 20:43:19 +01:00
Ivan Žužak
047bfc879c Fix typo 2015-11-08 20:40:55 +01:00
Wliu
7bcdc9ab51 ⬆️ language-php@0.33.0 2015-11-07 20:05:24 -05:00
Nathan Sobo
0f6c608b88 Add to changelog 2015-11-07 16:29:56 -07:00
Nathan Sobo
29014d1a74 Merge pull request #9485 from atom/ns-disable-throttle-hack
Disable throttling in test windows via WebAudio hack
2015-11-07 16:02:33 -07:00
Nathan Sobo
d46cea9c41 Disable throttling in test windows via WebAudio hack
Throttling in test windows is annoying when tests run interactively,
and *seems* to cause issues with animation frames not firing even in
headless tests, though it’s difficult to fully confirm since this issue
is intermittent.
2015-11-07 16:01:20 -07:00
Nathan Sobo
1fd2ba084c Merge pull request #8232 from lpommers/move-lines-up-and-down-with-multiple-selections
Move lines up and down with multiple selections
2015-11-07 14:40:58 -07:00