github/backbone
1
1
Fork 0
mirror of https://github.com/jashkenas/backbone.git synced 2026-01-14 17:37:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

using typeof rather than _.isObject for model.save

Browse Source
This commit is contained in:
Tim Griesser
2012-12-26 13:07:36 -05:00
parent 3283442550
commit 047d0d6bf4
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
backbone.js
View File

@@ -461,7 +461,7 @@
model.attributes = attributes;
var serverAttrs = model.parse(resp, options);
if (options.wait) serverAttrs = _.extend(attrs || {}, serverAttrs);
if (_.isObject(serverAttrs) && !model.set(serverAttrs, options)) {
if (typeof serverAttrs === 'object' && !model.set(serverAttrs, options)) {
return false;
}
if (success) success(model, resp, options);

3
test/model.js
View File

@@ -423,10 +423,11 @@ $(document).ready(function() {
equal(model.get('title'), 'Twelfth Night');
});
test("save with non-object success response", 1, function () {
test("save with non-object success response", 2, function () {
var model = new Backbone.Model();
model.sync = function(method, model, options) {
options.success(model, '', options);
options.success(model, null, options);
};
model.save({testing:'empty'}, {
success: function (model) {