github/backbone
1
1
Fork 0
mirror of https://github.com/jashkenas/backbone.git synced 2026-04-08 03:00:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #438 from gravof/master

Browse Source 
Model is no longer considered to be new if its id is a falsey value
This commit is contained in:
Jeremy Ashkenas
2011-06-29 18:03:00 -07:00
parent 7ed20d7906 4e9037b018
commit 0b74a24b69
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
backbone.js
View File

@@ -342,7 +342,7 @@
// A model is new if it has never been saved to the server, and has a negative
// ID.
isNew : function() {
return !this.id;
return this.id == null;
},
// Call this method to manually fire a `change` event for this model.

6
test/model.js
View File

@@ -96,7 +96,11 @@ $(document).ready(function() {
a = new Backbone.Model(attrs);
ok(a.isNew(), "it should be new");
attrs = { 'foo': 1, 'bar': 2, 'baz': 3, 'id': -5 };
ok(a.isNew(), "any defined ID is legal, negative or positive");
a = new Backbone.Model(attrs);
ok(!a.isNew(), "any defined ID is legal, negative or positive");
attrs = { 'foo': 1, 'bar': 2, 'baz': 3, 'id': 0 };
a = new Backbone.Model(attrs);
ok(!a.isNew(), "any defined ID is legal, including zero");
});
test("Model: get", function() {