github/backbone
1
1
Fork 0
mirror of https://github.com/jashkenas/backbone.git synced 2026-04-30 03:00:06 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3410 from kperry42/http304-fetch

Browse Source 
Fix fetch() to properly handle HTTP 304 "Not Modified"
This commit is contained in:
Jeremy Ashkenas
2014-12-11 15:53:17 -05:00
parent 54a4c17343 ea24e0a20d
commit 3c8da29e02
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
backbone.js
View File

@@ -457,8 +457,8 @@
if (options.parse === void 0) options.parse = true;
var model = this;
var success = options.success;
options.success = function(resp) {
if (!model.set(model.parse(resp, options), options)) return false;
options.success = function(resp, status) {
if (status !== "notmodified" && !model.set(model.parse(resp, options), options)) return false;
if (success) success(model, resp, options);
model.trigger('sync', model, resp, options);
};
@@ -893,9 +893,11 @@
if (options.parse === void 0) options.parse = true;
var success = options.success;
var collection = this;
options.success = function(resp) {
var method = options.reset ? 'reset' : 'set';
collection[method](resp, options);
options.success = function(resp, status) {
if (status !== "notmodified") {
var method = options.reset ? 'reset' : 'set';
collection[method](resp, options);
}
if (success) success(collection, resp, options);
collection.trigger('sync', collection, resp, options);
};