github/backbone
1
1
Fork 0
mirror of https://github.com/jashkenas/backbone.git synced 2026-01-23 13:58:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

Issue #33. Refactor towards View#_ensureElement

Browse Source
This commit is contained in:
Jeremy Ashkenas
2010-10-20 14:41:50 -04:00
parent c025904432
commit 705aff58a3
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
backbone.js
View File

@@ -515,14 +515,7 @@
// if an existing element is not provided...
Backbone.View = function(options) {
this._configure(options || {});
if (this.options.el) {
this.el = this.options.el;
} else {
var attrs = {};
if (this.id) attrs.id = this.id;
if (this.className) attrs.className = this.className;
this.el = this.make(this.tagName, attrs);
}
this._ensureElement();
if (this.initialize) this.initialize(options);
};
@@ -603,10 +596,20 @@
if (this.options) options = _.extend({}, this.options, options);
if (options.model) this.model = options.model;
if (options.collection) this.collection = options.collection;
if (options.el) this.el = options.el;
if (options.id) this.id = options.id;
if (options.className) this.className = options.className;
if (options.tagName) this.tagName = options.tagName;
this.options = options;
},
// Ensure that the View has a DOM element to render into.
_ensureElement : function() {
if (this.el) return;
var attrs = {};
if (this.id) attrs.id = this.id;
if (this.className) attrs.className = this.className;
this.el = this.make(this.tagName, attrs);
}
});