github/backbone
1
1
Fork 0
mirror of https://github.com/jashkenas/backbone.git synced 2026-04-30 03:00:06 -04:00
Code Issues Packages Projects Releases Wiki Activity

Speed up method calls in delegateEvents and delegate

Browse Source
This commit is contained in:
Jimmy Yuen Ho Wong
2014-02-20 01:23:30 +08:00
parent 19d82b8338
commit 846de91c88
1 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
backbone.js
View File

@@ -1067,6 +1067,7 @@
delegateEvents: function(events) {
if (!(events || (events = _.result(this, 'events')))) return this;
this.undelegateEvents();
var delegate = this.delegate;
for (var key in events) {
var method = events[key];
if (!_.isFunction(method)) method = this[events[key]];
@@ -1074,23 +1075,20 @@
var match = key.match(delegateEventSplitter);
var eventName = match[1], selector = match[2];
this.delegate(eventName, selector, method);
method = method.bind && method.bind(this) || _.bind(method, this);
delegate.call(this, eventName, selector, method);
}
return this;
},
// Add a single event listener to the element.
// Add a single event listener to the element responding only to the
// optional `selector` or catches all `eventName` events.
delegate: function(eventName, selector, method) {
if (_.isFunction(selector)) {
method = selector;
selector = undefined;
}
eventName += '.delegateEvents' + this.cid;
if (!selector) {
this.$el.on(eventName, _.bind(method, this));
this.$el.on(eventName, method);
} else {
this.$el.on(eventName, selector, _.bind(method, this));
this.$el.on(eventName, selector, method);
}
return this;
},