github/backbone
1
1
Fork 0
mirror of https://github.com/jashkenas/backbone.git synced 2026-01-22 13:28:22 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #854 from braddunbar/inline-add-remove

Browse Source 
Only Increment Length Once
This commit is contained in:
Jeremy Ashkenas
2012-01-11 17:19:47 -08:00
parent 8cfb243b8e 4dd506c3d4
commit a8dbe4efa7
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
backbone.js
View File

@@ -416,11 +416,11 @@
// Add a model, or list of models to the set. Pass **silent** to avoid
// firing the `added` event for every new model.
add : function(models, options) {
var i, l;
var i, length;
options || (options = {});
if (!_.isArray(models)) models = [models];
models = slice.call(models);
for (i = 0, l = models.length; i < l; i++) {
for (i = 0, length = models.length; i < length; i++) {
var model = models[i] = this._prepareModel(models[i], options);
var hasId = model.id != null;
if (this._byCid[model.cid] || (hasId && this._byId[model.id])) {
@@ -429,13 +429,13 @@
this._byCid[model.cid] = model;
if (hasId) this._byId[model.id] = model;
model.bind('all', this._onModelEvent, this);
this.length++;
}
this.length += length;
i = options.at != null ? options.at : this.models.length;
splice.apply(this.models, [i, 0].concat(models));
if (this.comparator) this.sort({silent: true});
if (options.silent) return this;
for (i = 0; i < l; i++) {
for (i = 0; i < length; i++) {
models[i].trigger('add', models[i], this, options);
}
return this;