github/backbone
1
1
Fork 0
mirror of https://github.com/jashkenas/backbone.git synced 2026-04-30 03:00:06 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1129 from r00k/allow-content-of-0-in-make

Browse Source 
Allow make to take falsy arguments for content.
This commit is contained in:
brad dunbar
2012-03-21 14:27:10 -07:00
parent f784ae3801 c7034b9735
commit cb8a12fe16
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
backbone.js
View File

@@ -1192,7 +1192,7 @@
make: function(tagName, attributes, content) {
var el = document.createElement(tagName);
if (attributes) $(el).attr(attributes);
if (content) $(el).html(content);
if (content != null) $(el).html(content);
return el;
},

8
test/view.js
View File

@@ -33,6 +33,14 @@ $(document).ready(function() {
equal($(div).text(), 'one two three');
});
test("View: make can take falsy values for content", function() {
var div = view.make('div', {id: 'test-div'}, 0);
equal($(div).text(), '0');
var div = view.make('div', {id: 'test-div'}, '');
equal($(div).text(), '');
});
test("View: initialize", function() {
var View = Backbone.View.extend({
initialize: function() {