github/backbone
1
1
Fork 0
mirror of https://github.com/jashkenas/backbone.git synced 2026-01-24 14:27:56 -05:00
Code Issues Packages Projects Releases Wiki Activity

willbailey's patch to use getByCid for internal lookups ... much safer.

Browse Source
This commit is contained in:
Jeremy Ashkenas
2010-10-14 07:36:11 -04:00
parent 184687b28f
commit eb9f54c8fe
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
backbone.js
View File

@@ -422,7 +422,7 @@
// hash indexes for `id` and `cid` lookups.
_add : function(model, options) {
options || (options = {});
var already = this.get(model);
var already = this.getByCid(model);
if (already) throw new Error(["Can't add the same model to a set twice", already.id]);
this._byId[model.id] = model;
this._byCid[model.cid] = model;
@@ -439,7 +439,7 @@
// hash indexes for `id` and `cid` lookups.
_remove : function(model, options) {
options || (options = {});
model = this.get(model);
model = this.getByCid(model);
if (!model) return null;
delete this._byId[model.id];
delete this._byCid[model.cid];