github/backbone
1
1
Fork 0
mirror of https://github.com/jashkenas/backbone.git synced 2026-01-23 22:08:04 -05:00
Code Issues Packages Projects Releases Wiki Activity

ouch, leaking global attrs. (shakes fist)

Browse Source
This commit is contained in:
Jeremy Ashkenas
2011-05-27 12:17:10 -04:00
parent 93c82aad55
commit ff57b6536d
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
backbone.js
View File

@@ -103,13 +103,13 @@
// same arguments as `trigger` is, apart from the event name.
// Listening for `"all"` passes the true event name as the first argument.
trigger : function(eventName) {
var list, calls, ev, callback, args, i, l;
var list, calls, ev, callback, args;
var both = 2;
if (!(calls = this._callbacks)) return this;
while (both--) {
ev = both ? eventName : 'all';
if (list = calls[ev]) {
for (i = 0, l = list.length; i < l; i++) {
for (var i = 0, l = list.length; i < l; i++) {
if (!(callback = list[i])) {
list.splice(i, 1); i--; l--;
} else {
@@ -257,14 +257,14 @@
// Run validation.
var validObj = {};
for (attr in old) validObj[attr] = void 0;
for (var attr in old) validObj[attr] = void 0;
if (!options.silent && this.validate && !this._performValidation(validObj, options)) return false;
this.attributes = {};
this._escapedAttributes = {};
this._changed = true;
if (!options.silent) {
for (attr in old) {
for (var attr in old) {
this.trigger('change:' + attr, this, void 0, options);
}
this.change(options);