Commit Graph

1757 Commits

Author SHA1 Message Date
Tim Griesser
16bcd429c8 bumping jquery to 1.7+ 2012-12-22 15:39:28 -05:00
Casey Foster
e16c762ec5 Remove unused declarations in add, noglobals for phantomjs 2012-12-21 15:06:09 -08:00
Casey Foster
6868457ff5 Match comparator string checks in sort and add 2012-12-21 13:29:10 -08:00
Jeremy Ashkenas
2abe2850e5 Merge pull request #2004 from elasticsales/master
Adding test for change event only firing if setting an object with a different value
2012-12-21 12:39:18 -08:00
Casey Foster
320347d94a Merge pull request #2005 from braddunbar/success-args
Fix #2003 - success callback arguments.
2012-12-21 11:55:19 -08:00
Brad Dunbar
0aff3f2b62 Use collection in Collection#fetch. 2012-12-21 14:45:34 -05:00
Brad Dunbar
6023be49e1 Remove unused arguments. 2012-12-21 14:14:32 -05:00
Brad Dunbar
6d589bad78 Fix #2003 - success callback arguments. 2012-12-21 14:06:45 -05:00
Phil Freo
e2bcc8c6ea Adding test for change event only firing if setting an object with a different value 2012-12-21 13:54:10 -05:00
Casey Foster
ef0db237ca Revert set/save argument juggling 2012-12-21 10:47:30 -08:00
Casey Foster
b6ca71c594 Simplify argument juggling for set/save 2012-12-21 09:51:09 -08:00
Jeremy Ashkenas
1357ecd413 tricky merge with master ... 2012-12-21 12:25:45 -05:00
Jeremy Ashkenas
40b7419e48 Merge pull request #2002 from braddunbar/named-optional
Fix #1980 - Named and optional params.
2012-12-21 09:19:33 -08:00
Casey Foster
1c131daef6 Clear up comments in last test 2012-12-21 08:19:38 -08:00
Casey Foster
09bd7fe8a8 Fix test case 2012-12-21 08:18:15 -08:00
Jeremy Ashkenas
812a8465de failing test case 2012-12-21 11:13:09 -05:00
Casey Foster
d0af33646c Even smarter sort-reduction 2012-12-21 08:07:55 -08:00
Jeremy Ashkenas
0e20e93b81 fixed leaking global 2012-12-21 10:58:46 -05:00
Jeremy Ashkenas
45b3870136 Merge branch 'simple' of github.com:documentcloud/backbone into simple 2012-12-21 10:56:57 -05:00
Jeremy Ashkenas
5ac783bd2d complete test suite passing. 2012-12-21 10:56:57 -05:00
Tim Griesser
b3c06874ae Merge pull request #2001 from braddunbar/simple
Ensure toJSON receives the correct attributes.
2012-12-21 07:53:33 -08:00
Jeremy Ashkenas
2eab0fe3b8 hasChanged shouldn't be true after the constructor. 2012-12-21 10:51:02 -05:00
Jeremy Ashkenas
3ffcce8cb8 trying new hasChanged() semantics 2012-12-21 10:46:02 -05:00
Jeremy Ashkenas
e5c30a396a merged with simple 2012-12-21 10:24:19 -05:00
Jeremy Ashkenas
34f852803a revisited tests with simple silent 2012-12-21 10:23:16 -05:00
Casey Foster
e658535bd0 Add test for smart add-sorting 2012-12-21 06:46:23 -08:00
Brad Dunbar
1c4a1e3bc5 Fix #1980 - Named and optional params. 2012-12-21 09:39:54 -05:00
Casey Foster
5debd9d363 Perf tweaks, see http://jsperf.com/testing-equals-versus-strict-equals/3, http://jsperf.com/conditional-assignment-vs-reassignment 2012-12-21 06:36:39 -08:00
brad dunbar
c9b025fd86 Merge pull request #1996 from caseywebdev/sort
Only sort when a model is changed or added
2012-12-21 06:04:12 -08:00
Brad Dunbar
5350dc9dea Ensure toJSON receives the correct attributes. 2012-12-21 08:53:12 -05:00
Tim Griesser
4089bf0e42 sync tests passing, tweaking save validation rules 2012-12-20 23:28:49 -05:00
Casey Foster
e7df5886c2 Bring add/sort optimization over to simple 2012-12-20 15:08:46 -08:00
Casey Foster
4817c419eb Bring add optimization over to simple 2012-12-20 15:00:39 -08:00
Casey Foster
72f9d124b3 Speed up set, see http://jsperf.com/isobject-vs-typeof 2012-12-20 14:43:50 -08:00
Casey Foster
da9da5530d Options everywhere 2012-12-20 14:39:02 -08:00
Casey Foster
810c535dc0 Only sort when a model is changed or added 2012-12-20 13:24:10 -08:00
Jeremy Ashkenas
ddefc0a5f5 Merge pull request #1995 from braddunbar/simple
Use boolean for `nested`.
2012-12-20 13:06:34 -08:00
Jeremy Ashkenas
d7179e553d Pour one out on the ground for JSLitmus... 2012-12-20 16:06:17 -05:00
Brad Dunbar
0de1512fff Use boolean for nested. 2012-12-20 16:05:02 -05:00
Jeremy Ashkenas
23a0673321 using 'current' instead of storing extra state 2012-12-20 16:00:31 -05:00
Jeremy Ashkenas
c0f3f424bb remove lingering silents 2012-12-20 15:39:32 -05:00
Jeremy Ashkenas
9c55b4b349 finished with the simple case for models ... hurrah 2012-12-20 15:30:29 -05:00
Jeremy Ashkenas
14bfb400fc ... progress ... 2012-12-20 14:53:33 -05:00
Brad Dunbar
7f29c8c032 Remove accidental global. 2012-12-20 11:54:26 -05:00
Casey Foster
4ec055f752 Add missing space in docs 2012-12-20 08:30:07 -08:00
Casey Foster
b28c1460db Fix #1987 - Mention the removal of options.index in the changelog 2012-12-20 08:23:07 -08:00
Casey Foster
fa041b4c10 Merge pull request #1994 from braddunbar/once-noop
Add test for once without callback.
2012-12-20 08:06:21 -08:00
Brad Dunbar
9e542c0224 Add test for once without callback. 2012-12-20 11:02:59 -05:00
Jeremy Ashkenas
74633ab41a Merge pull request #1991 from gsamokovarov/model-change-test
Add test for #1989
2012-12-20 07:34:08 -08:00
brad dunbar
83de3d3799 Merge pull request #1993 from caseywebdev/options
Fix #1987 - Be consistent when passing options to trigger callbacks
2012-12-20 07:22:20 -08:00