Commit Graph

2683 Commits

Author SHA1 Message Date
Jmeas
459dc24f80 Fixes listenToOnce memory leak. 2014-11-03 09:52:12 -05:00
Jmeas
71cecdc1e2 Failing spec for listenToOnce 2014-11-03 09:52:12 -05:00
Adam Krebs
854a2a4f99 Merge pull request #3362 from jmm/jmm/docs-trailing-whitespace
Remove trailing whitespace (line containing only space chars).
2014-10-30 17:44:48 -04:00
Jesse McCarthy
8997f6949d Remove trailing whitespace (line containing only space chars). 2014-10-30 17:05:54 -04:00
Adam Krebs
5b97de0a3d Merge pull request #3360 from morganrallen/localStorageDoc
fixed camel case filename for doc run script
2014-10-29 09:14:50 -04:00
Morgan 'ARR\!' Allen
81eb7fd3cb fixed camel case filename for doc run script 2014-10-27 18:52:45 -07:00
Jeremy Ashkenas
eda14bdfb9 Merge pull request #3357 from braddunbar/trailing-slash
Update trailing slash for search params.
2014-10-23 18:25:02 -04:00
Brad Dunbar
23599e7472 Update trailing slash for search params. 2014-10-23 18:16:29 -04:00
Jeremy Ashkenas
687ebf679f Merge pull request #3354 from janaspage/patch-3
Un-split an infinitive verb tense.
2014-10-22 15:25:00 -04:00
Janas Page
c568fee881 Un-split infinitive [v 2]. 2014-10-22 12:15:24 -07:00
Janas Page
188bd820d5 Un-split an infinitive verb tense.
Just grammar.
2014-10-22 11:13:51 -07:00
Adam Krebs
f1a742d6f0 Merge pull request #3351 from janaspage/patch-2
Hyphenate compound modifier.
2014-10-21 17:20:44 -04:00
Janas Page
45c80b74dc Hyphenate compound modifier.
It's a single adjective: the compound word "two-way" (as opposed to two adjectives: "two" and "way").
2014-10-21 14:19:35 -07:00
Adam Krebs
ace13558ac Merge pull request #3326 from biversen21/master
Update backbone.js comment for clarity
2014-10-20 14:52:02 -04:00
Adam Krebs
0a51e22c05 Merge pull request #3336 from admangum/issue_3306
clone options passed to reset
2014-10-09 15:56:57 -04:00
admangum
dae5424bd5 clone options passed to reset 2014-10-09 12:31:35 -07:00
Adam Krebs
833ab6f327 don't just test for the presence of options, test that it points to the same object as passed in. 2014-10-03 14:03:55 -04:00
Adam Krebs
8a73ff87bc Merge pull request #3329 from hmil/fix-options-success
fix flawed test
2014-10-03 13:57:16 -04:00
Hadrien Milano
cdce75ef76 fix wrong test: collection.model must be a function 2014-10-03 17:59:35 +02:00
Hadrien Milano
e10ab33e73 fix flawed test 2014-10-02 22:15:26 +02:00
Brian Iversen
dd00fd45a7 Update backbone.js comment for clarity
Fixed comment in backbone.js
2014-09-26 12:11:00 -07:00
Jeremy Ashkenas
743ebb788d Merge pull request #3318 from NickStefan/patch-1
Update README to better match backbonejs.org
2014-09-25 12:59:35 -04:00
Nick Stefan
56b66130f4 removed the strong tags, but kept the "with" on 14 2014-09-25 09:50:42 -07:00
Adam Krebs
4927b6e3f0 Merge pull request #3281 from jisaacks/master
Allow Collection.at to accept negative indexes
2014-09-25 12:22:18 -04:00
Nick Stefan
644c912b33 Update README to better match backbonejs.org
line 14 readme missing the word "with":
Backbone supplies structure to JavaScript-heavy applications by providing models key-value binding and custom events, collections...
--> on backbonejs.org reads as -->
Backbone.js gives structure to web applications by providing models with key-value binding and custom events, collections...

Also bolded models, views and collections just as they are on backbonejs.org
2014-09-23 15:21:21 -07:00
Jeremy Ashkenas
c349965312 Merge pull request #3301 from AndrewEastwood/patch-1
Enhancing Model with isEmpty function
2014-09-23 15:37:45 -04:00
Adam Krebs
b966584356 Merge pull request #3039 from fastest963/master
Send correct 'at' when firing 'add' event
2014-09-11 13:45:42 -04:00
James Hartig
34e1a1e40c Send correct 'at' when firing 'add' event 2014-09-11 13:04:36 -04:00
Adam Krebs
fa69c207cd Merge pull request #3265 from tomascasas/bb-col-doc-update
Collection docs: models is not optional if options is passed in
2014-09-11 11:29:38 -04:00
Andrew Ivaskevych
a1b7ac32eb Adding the isEmpty function into the modelMethods 2014-09-09 18:03:55 +03:00
Andrew Ivaskevych
e6fa0e2aaa Enhancing Model with isEmpty function 2014-09-09 16:47:52 +03:00
JD Isaacks
bcd7549bc9 Set correct number of assertions 2014-09-02 10:33:05 -04:00
JD Isaacks
992fc7b794 Add test for negative indexes in at method 2014-09-02 10:28:48 -04:00
JD Isaacks
84fc093a26 Allow Collection.at to accept negative indexes
This allows you to do things like

```javascript
mycollection.at(-2) // get second to last, etc.
```
2014-08-27 11:14:31 -04:00
Brad Dunbar
1dbe3ddf2f Merge pull request #3152 from braddunbar/ie6
Handle incorrect hash/search values in IE6.
2014-08-18 16:53:23 -04:00
Tomas Casas
7a20f16b93 Collection docs: models is not optional if options is passed in 2014-08-13 19:35:46 -03:00
Adam Krebs
6a82b0c897 Merge pull request #3259 from megawac/patch-1
Allow MDN to select an appropriate localization [ci-skip]
2014-08-06 12:50:13 -04:00
Graeme Yeates
fc6b2a6030 Allow MDN to select an appropriate localization 2014-08-06 11:05:16 -04:00
Adam Krebs
56fbfc19db Merge pull request #3258 from NotBobTheBuilder/master
Update JavaScript toJSON API documentation URL
2014-08-06 11:00:41 -04:00
Jack Wearden
4b38a61bbe Update JavaScript toJSON API documentation URL
The previous link to MDN had rotted, this seems to be the closest correct URL.
2014-08-06 15:56:51 +01:00
Jeremy Ashkenas
f2612a92df Merge pull request #3222 from emorikawa/master
Prevent memory leak by `stopListening` on Backbone.Model `destroy`
2014-08-04 17:31:30 -04:00
Jeremy Ashkenas
f7cc792bdc Merge pull request #3236 from akre54/save-and-patch-diff-attrs
Allow Model#save with patch: true to take different attrs
2014-08-04 15:39:40 -04:00
Adam Krebs
0770ab45bb Merge pull request #3240 from HHSnopek/master
add example to Backbone.$ for commonjs
2014-07-24 15:21:43 -04:00
Henry Snopek
0538fc724b add example to Backbone.$ for commonjs 2014-07-24 15:19:19 -04:00
Sam Breed
f59e37eeb2 Merge pull request #3239 from akre54/document-patch
document patch
2014-07-24 12:18:50 -06:00
Adam Krebs
937fa5390d document patch 2014-07-24 13:54:45 -04:00
Adam Krebs
ac384b2c1e test for attributes set on the model correctly in patch save 2014-07-23 11:38:36 -04:00
Adam Krebs
2deb84a982 allow Model#save with patch: true to take different attrs. Fixes #3232 2014-07-23 09:47:29 -04:00
Adam Krebs
4e02c9ad09 Merge pull request #3234 from go-oleg/master
Docs: Fix URL to MDN's JSON.stringify() toJSON behavior
2014-07-22 23:00:14 -04:00
Oleg Seletsky
749c47763b Docs: Remove localization from URL to MDN's JSON.stringify() 2014-07-22 17:37:56 -07:00