Adam Krebs
06f19f45af
fix tagName test description
2014-03-23 01:59:42 +02:00
Adam Krebs
c10267db3f
view test reorg
2014-03-21 01:44:48 +02:00
Nate Hunzaker
a04d7da6e4
DOM element creation should be overrideable
...
- Add test for _createElement
- Send tag name to _createElement
2014-03-20 19:34:13 -04:00
Brad Dunbar
72f7da4208
A little clarification.
...
* Rename #_remove as #_removeElement.
* Add #_setAttributes instead of using #setElement.
* Slim down tests a bit.
* #delegate returns this.
2014-03-14 11:56:16 -04:00
Jimmy Yuen Ho Wong
ad39972d5d
Return undefined from delegate
2014-03-14 18:04:18 +08:00
Adam Krebs
f67c7a11c3
test delegate returns listener
2014-03-14 06:35:20 +04:00
Adam Krebs
291f3bcde4
nicer jq test
2014-03-13 12:59:36 +04:00
Adam Krebs
3850d37def
add missing semi
2014-03-12 19:55:08 +04:00
Adam Krebs
d99e43b564
test for undelegate with handler and selector, and use an element that exists in the DOM for bubbling
2014-03-12 15:20:40 +04:00
Adam Krebs
d21fd79d8f
remove namespace test from custom events test.
2014-03-12 15:16:33 +04:00
Adam Krebs
be11f3a010
add an undelegate method to View and pass back the listener from delegate
2014-03-12 11:07:33 +04:00
Jimmy Yuen Ho Wong
393a209ca8
Merge _remove and remove tests and remove _setEl tests
2014-03-10 21:18:14 +08:00
Jimmy Yuen Ho Wong
b840669fa7
Rename _removeElement to _remove and test _remove for event undelegation
2014-03-10 21:18:13 +08:00
Adam Krebs
c62708f04b
use notEqual body isntead of equal null
2014-03-06 15:26:44 +04:00
Adam Krebs
bef78ef496
test setEl and el.parentNode
2014-03-06 15:22:13 +04:00
Adam Krebs
9eff496762
Revert "View conformance tests"
...
This reverts commit 7eedd4bc0a
2014-03-06 11:14:16 +04:00
Adam Krebs
6d6999976a
test _removeElement
2014-03-06 10:46:41 +04:00
Jimmy Yuen Ho Wong
1cb19be4e9
Test for view.remove and view._removeElement
2014-03-05 18:31:13 +08:00
Adam Krebs
81809e188f
add global Element guard for IE8
2014-03-04 23:07:28 +02:00
Jimmy Yuen Ho Wong
6cef2f12e5
Check typeof length instead of instanceof
2014-03-04 23:05:11 +02:00
Jimmy Yuen Ho Wong
fca75fb6bd
Fix up global in view test
2014-03-04 23:04:59 +02:00
Adam Krebs
0fca38cd82
view test cleanup
2014-03-04 14:45:22 +02:00
Adam Krebs
70933e51cf
fix merge conflict
2014-03-04 14:19:35 +02:00
Adam Krebs
a9d066a84e
test view.$ interface and rename _createContext to _setEl in view test
2014-03-04 14:17:42 +02:00
Adam Krebs
01f794fe99
Merge remote-tracking branch 'wyuenho/view-native-hooks' into view-native-hooks
...
Conflicts:
backbone.js
test/view.js
2014-03-04 14:15:16 +02:00
Jimmy Yuen Ho Wong
20935c85ee
Fix test for fc95eae
2014-03-04 13:42:41 +02:00
Jimmy Yuen Ho Wong
6ebb6e1752
_createContext is side-effect only
2014-03-04 13:42:41 +02:00
Jimmy Yuen Ho Wong
d78fb34aff
Prefix all hooks with _ and introduce _undelegate
2014-03-04 13:42:40 +02:00
Jimmy Yuen Ho Wong
5f66f9af18
Rename make to _createContext and have _ensureElement and setElement delegate to it
2014-03-04 13:42:40 +02:00
Adam Krebs
90c36cadac
add View#delegate as a single event listener version of delegateEvents for easier overriding
2014-03-04 13:42:40 +02:00
Adam Krebs
0cdb38b03f
revert c1e62cda: add View#make back in for overriding
2014-03-04 13:42:40 +02:00
Jimmy Yuen Ho Wong
7eedd4bc0a
View conformance tests
2014-03-04 15:00:14 +08:00
Jimmy Yuen Ho Wong
3cef7fa7b6
Fix test for fc95eae
2014-02-22 00:02:37 +08:00
Jimmy Yuen Ho Wong
09d376237b
_createContext is side-effect only
2014-02-20 14:18:21 +08:00
Jimmy Yuen Ho Wong
8ab8646361
Prefix all hooks with _ and introduce _undelegate
2014-02-20 05:31:36 +08:00
Jimmy Yuen Ho Wong
33e23df577
Rename make to _createContext and have _ensureElement and setElement delegate to it
2014-02-20 05:11:11 +08:00
Adam Krebs
e9543ee591
add View#delegate as a single event listener version of delegateEvents for easier overriding
2014-02-18 17:34:54 -05:00
Adam Krebs
02d270f455
revert c1e62cda: add View#make back in for overriding
2014-02-18 17:09:01 -05:00
Brad Dunbar
56e3221325
Tweak fixture attachment.
2013-11-19 17:37:09 -05:00
kupriyanenko
ba9eeb52ba
Add support for runnig tests with jQuery-compatible libraries
2013-11-18 00:32:20 +02:00
Adam Krebs
866b84d9a9
remove jQuery-specific selector
2013-09-16 11:01:58 -04:00
Adam Krebs
2bd5df99c5
remove $(document).ready(...) from tests
2013-09-16 10:51:32 -04:00
Brad Dunbar
51eed189bf
Dispense with View#options merging.
2013-04-09 09:38:23 -04:00
Brad Dunbar
a22cbc7f36
Fix #2458 - Options are not attached to views.
2013-04-08 13:58:15 -04:00
Jean Boussier
108e114bd1
Improve consistency: get rid of a zealous early error breaking apps in inconvenient ways
...
Since jQuery.on() and Backbone.Events.on are silently ignoring invalid callbacks,
Backbone.View.delegateEvents should too.
See #2184 for previous discussion about how Backbone is supposed to behave on obvious developer errors
2013-01-25 11:24:57 -05:00
Tim Griesser
c1e62cda99
removing view.make
2012-12-28 16:34:15 -05:00
Jeremy Ashkenas
1191640d84
Fixes #1363 , fixes #1461 , removes View#dispose, adds Events#listenTo and Events#stopListening, and implements View#remove in terms of those.
2012-12-11 13:41:39 -05:00
Adam Krebs
bc87c3fa46
add options function test
2012-11-27 11:22:19 -05:00
Tim Griesser
a96fe08f92
allowing events to be passed in view's options
2012-11-16 14:21:59 -05:00
Genadi Samokovarov
85a1e3ea5c
Use _.pick to simplify View#_configure
2012-10-22 12:51:43 +03:00
