Commit Graph

2785 Commits

Author SHA1 Message Date
Justin Ridgewell
6aed2485ae Revert "Merge pull request #3465 from jridgewell/trigger-objects"
This reverts commit 760004faa7, reversing
changes made to 7315c56d2e.
2015-02-17 17:06:21 -05:00
Adam Krebs
0b2835f7fc Merge pull request #3490 from yousefcisco/master
Customise model cid prefix
2015-02-12 12:23:12 -05:00
Yousef Cisco
2d041d799d Updated Model to allow configuration of the cid prefix 2015-02-12 17:16:55 +00:00
Jeremy Ashkenas
377b9c89e4 Merge pull request #3485 from megawac/qunit-update
[minor] Update QUnit to v1.7.1
2015-02-10 10:47:20 -05:00
Graeme
1577524edd Update QUnit to v1.7.1 2015-02-10 00:31:04 -05:00
Adam Krebs
87a4af8f3b fetch docs cleanup 2015-02-09 12:04:38 -05:00
Adam Krebs
956138fe5f Merge pull request #3480 from wettowelreactor/patch-1
Fix #3477. Clarify Model.fetch docs
2015-02-09 12:00:19 -05:00
Camille Roussel
389ca5400d Fix #3477. Clarify Model.fetch docs 2015-02-08 18:56:07 -08:00
Adam Krebs
d8645e61d3 Merge pull request #3482 from arianf/master
Fixed copyright range to be updated to 2015
2015-02-08 16:02:10 -08:00
Arian Faurtosh
e48212d73e Fixed copyright range to be updated to 2015 2015-02-08 10:50:59 -08:00
Brad Dunbar
9f81d980f0 Model#url id falls back to #get(this.idAttribute). 2015-02-05 07:37:30 -05:00
Stephen Thomas
0f2e968913 Add failing test for save and wait. 2015-02-05 07:33:25 -05:00
Jeremy Ashkenas
713c288475 Merge pull request #3455 from jridgewell/listenTo-memory-leak
Fix listenTo memory leak
2015-02-03 14:16:15 -05:00
Jeremy Ashkenas
9d8339905b Merge branch 'master' of https://github.com/jashkenas/backbone 2015-02-03 11:33:26 -05:00
Jeremy Ashkenas
98b6be8852 redoc 2015-02-03 11:33:25 -05:00
Jeremy Ashkenas
c1ce7a7484 Merge pull request #3423 from jridgewell/ajax_context
Call the success callback with context
2015-02-02 13:48:49 -05:00
Jeremy Ashkenas
68220af813 Tweak View#el docs further. 2015-01-30 12:49:46 -05:00
Jeremy Ashkenas
61a5eaf2e1 Merge pull request #3456 from akre54/el-docs
Clarify docs around View#el. Fixes #3454
2015-01-30 12:48:19 -05:00
Justin Ridgewell
3aac74d121 Undo concat #on tests 2015-01-29 23:23:22 -05:00
Justin Ridgewell
4018a5683f Rearrange and comment Events 2015-01-29 23:20:58 -05:00
Justin Ridgewell
826b110b45 Create internal use stopListening
This is to prevent an infinite off -> stopListening -> off ->
stopListening.
2015-01-29 11:28:38 -05:00
Jeremy Ashkenas
760004faa7 Merge pull request #3465 from jridgewell/trigger-objects
Test trigger arguments behavior
2015-01-28 15:42:50 -05:00
Justin Ridgewell
b49f17c2ad off cleans up listenTo 2015-01-27 21:33:12 -05:00
Justin Ridgewell
778d447922 Address listenTo and off memory leak
https://github.com/jashkenas/backbone/pull/3455#issuecomment-71677970
2015-01-27 20:55:54 -05:00
Justin Ridgewell
e01869d4b0 Break instead of continuing 2015-01-27 17:21:30 -05:00
Justin Ridgewell
6796ca06c5 Comment eventsApi refactor 2015-01-27 00:43:13 -05:00
Justin Ridgewell
c73a3c33b2 Inline onceWrapper 2015-01-26 23:28:10 -05:00
Justin Ridgewell
59c3704955 Test trigger arguments behavior
To be clear, I think the trigger with object behavior is silly. But I
needed tests to ensure that my [`eventsApi` refactor]
(https://github.com/jridgewell/backbone/tree/eventsApi-refactor) kept
the current functionality.
2015-01-26 16:54:54 -05:00
Justin Ridgewell
7ecf183dce Test trigger arguments behavior
To be clear, I think the trigger with object behavior is silly. But I
needed tests to ensure that my [`eventsApi` refactor]
(https://github.com/jridgewell/backbone/tree/eventsApi-refactor) kept
the current functionality.
2015-01-25 13:49:19 -05:00
Justin Ridgewell
9abb4ab700 Trigger with object behaves dumbly
If you trigger with an object, it's prop value is prepended onto the
listener's arguments.
2015-01-25 13:31:48 -05:00
Justin Ridgewell
50adef3c03 Refactor the eventsApi
http://jsperf.com/eventsapi-refactor
2015-01-25 03:57:00 -05:00
Justin Ridgewell
d7b7a9c07d Use faster listeningTo iteration 2015-01-24 14:56:51 -05:00
Justin Ridgewell
1cb600ec54 Simplify #stopListening 2015-01-24 14:56:51 -05:00
Justin Ridgewell
0c200ca31f Delete events hash if there are none. 2015-01-24 14:56:10 -05:00
Justin Ridgewell
85fb8c30de Fix listenTo memory leak
Fixes https://github.com/jashkenas/backbone/issues/3453
2015-01-24 14:56:10 -05:00
Justin Ridgewell
c48cf5f22e Do not alter the "on" events array 2015-01-24 14:44:17 -05:00
Adam Krebs
828ace793b Clarify docs around View#el. Fixes #3454 2015-01-23 14:55:48 -05:00
Adam Krebs
7315c56d2e Merge pull request #3461 from jridgewell/listenToOnce-noop
Ensure listenToOnce without a callback noops
2015-01-23 14:12:16 -05:00
Justin Ridgewell
85885130a8 Ensure listenToOnce without a callback noops
This mirrors the test directly above, ensuring `#once` without a
callback noops.
2015-01-23 14:08:21 -05:00
Tim Griesser
3bad9a74bb Merge pull request #3459 from braddunbar/at-string
Collection#set - options.at accepts a string.
2015-01-23 09:39:13 -05:00
Brad Dunbar
1b0c67bdf8 Collection#set - options.at accepts a string.
Closes #3353.
2015-01-23 06:33:15 -05:00
Brad Dunbar
f888f10591 Merge pull request #3452 from zzmp/patch-1
update copyright year range
2015-01-21 14:18:26 -05:00
Zach Pomerantz
94922c7c42 update copyright year range 2015-01-21 10:47:41 -08:00
Adam Krebs
c5c4d27292 Merge pull request #3449 from braddunbar/split-events
Fix #3448. Ensure listenToOnce splits event names.
2015-01-19 23:33:55 -07:00
Brad Dunbar
dc048c6bf8 Ensure events are triggered by the correct name. 2015-01-19 12:36:44 -05:00
Brad Dunbar
f6695d13fe Fix #3448. Ensure listenToOnce splits event names.
Calling `listenToOnce('x y', …)` should be functionally equivalent
to `listenToOnce('x', …); listenToOnce('y', …)`.
2015-01-19 09:42:11 -05:00
Adam Krebs
d52ed125a8 Merge pull request #3435 from braddunbar/search-test
Ensure a search test fails when appropriate.
2015-01-04 23:22:02 -05:00
Brad Dunbar
7af3329175 Ensure a search test fails when appropriate. 2015-01-04 11:38:51 -05:00
Jeremy Ashkenas
f752362cfb Merge pull request #3431 from yokangy/patch-1
Add missing articles ('a', 'the')
2015-01-01 15:56:33 -05:00
Y Kang
585e2441f6 Add missing articles ('a', 'the')
In the definition for the 'Error' event, the singular nouns 'request' and 'server' require articles. I've also removed the word 'remote' from 'remote server' as the definitions for the 'Request' and 'Sync' events only refer to 'the server'.
2015-01-01 11:11:54 -08:00