Brad Dunbar
7828d6d22d
Prefer on/off over bind/unbind.
2012-06-03 15:06:44 -04:00
brad dunbar
465f297aee
Merge pull request #1374 from braddunbar/test-refactor
...
Refactor a test for simplicity.
2012-06-03 11:35:52 -07:00
Brad Dunbar
41f64c7f1a
Refactor a test for simplicity.
2012-06-03 13:55:40 -04:00
Sam Breed
626e3f16f7
adding correct number of expected assertions to nested change events model test
2012-06-03 11:38:18 -06:00
brad dunbar
3ad4ee8615
Merge pull request #1373 from wookiehangover/test_expected
...
adding the `expected` argument to all tests
2012-06-03 10:17:13 -07:00
Sam Breed
f4ebee0406
adding the expected argument to all tests
2012-06-02 18:07:11 -06:00
Sam Breed
c924e05bff
adding tests for #1355
2012-05-30 11:32:53 -04:00
Félix Horro Pita
6250b6353a
Pass options to success function on save, create and destroy.
2012-05-30 13:14:41 +02:00
Félix
b371d56669
Pass fetch options to success function (as error function does).
...
It will allow to use context (an other options) in callback function on success.
2012-05-29 12:59:04 +03:00
brad dunbar
5509e13842
Merge pull request #1349 from nervetattoo/docs-advocate-proper-el-usage
...
Advocate proper usage of $el over $(this.el) in documentation
2012-05-25 16:42:02 -07:00
Raymond Julin
f222360cd4
Advocate proper usage of $el over $(this.el) in documentation
2012-05-26 00:11:31 +02:00
Brad Dunbar
201373a128
Documentation for #1342 .
2012-05-24 15:04:44 -04:00
brad dunbar
b6dc6a224e
Merge pull request #1342 from caseywebdev/master
...
Allow Collection to receive falsy `comparator` to override default
2012-05-24 09:26:40 -07:00
Casey Foster
c016a1c58f
Added a few more cases for the test
2012-05-24 09:11:29 -07:00
Casey Foster
4a0acdee50
Simplified falsy comparator test case
2012-05-24 09:02:22 -07:00
Casey Foster
3952cde5d0
Merge pull request #1 from wookiehangover/issue1342
...
adding tests for falsy comparator
2012-05-24 06:52:26 -07:00
Sam Breed
98e01bbc4a
adding test for falsy comparators ( #1342 )
2012-05-23 23:53:13 -06:00
Jeremy Ashkenas
3c7c8d2f1a
Merge branch 'master' of github.com:documentcloud/backbone
2012-05-23 17:14:26 -04:00
Jeremy Ashkenas
f86674d6a7
Fixes #1343 , adding Collection#slice
2012-05-23 17:13:48 -04:00
Casey Foster
6d21c05b18
Allow Collection to receive falsy comparator to override default
2012-05-23 08:50:33 -07:00
Jeremy Ashkenas
7bea8ee34d
Merge pull request #1341 from caseywebdev/master
...
Updated `Collection.sort()` doc to clarify priority maintenance
2012-05-23 08:06:03 -07:00
Casey Foster
6f3328f239
Updated Collection.sort() doc to clarify priority maintenance
2012-05-23 07:56:55 -07:00
Jeremy Ashkenas
fdb3451cbf
Merge pull request #1323 from hswolff/mobile-site
...
implement optimized mobile version of Backbone website
2012-05-21 08:46:47 -07:00
Harry Wolff
29be393d24
Further updates:
...
* Clean up @media query indentation
* Support other larger resolution mobile phones
* Fix Backbone logo to not appear smushed
* Try alternate mobile sidebar display to indicate scrolling
* Fix width to be dynamic depending on width of screen
2012-05-21 08:59:26 -04:00
Jeremy Ashkenas
e34e14c466
Merge pull request #1322 from braddunbar/backbone-$
...
Jettison setDomLibrary in favor of Backbone.$.
2012-05-16 06:14:36 -07:00
Harry Wolff
6cabc5bbc1
remove comment, fix my xy
2012-05-15 23:39:09 -04:00
Harry Wolff
5af01e2a83
implement optimized mobile version of backbone website
2012-05-15 23:27:43 -04:00
Brad Dunbar
dcd10430b9
Update docs.
2012-05-15 18:46:25 -04:00
Brad Dunbar
04bd18e38e
Jettison setDomLibrary in favor of Backbone.$.
2012-05-15 17:45:58 -04:00
Jeremy Ashkenas
020ed1018a
smart @braddunbar simplification.
2012-05-15 17:38:44 -04:00
Jeremy Ashkenas
1a767d6abe
Changed mind. More breathing room.
2012-05-15 17:34:39 -04:00
Jeremy Ashkenas
b3425b8411
Fixing Backbone.ajax implementation.
2012-05-15 17:33:56 -04:00
Jeremy Ashkenas
9f161aeb26
Merge pull request #1317 from lennym/master
...
Allow Backbone.ajax to reflect changes made to $.ajax or Backbone.setDomLibrary()
2012-05-15 14:31:47 -07:00
lennym
ba249903e6
Copied Backbone.ajax from global DOM lib at runtime to allow calls to Backbone.setDomLibrary to take effect and improve compatibility with test frameworks that mock $.ajax
2012-05-15 17:40:19 +02:00
Jeremy Ashkenas
f141984333
Merge branch 'master' of github.com:documentcloud/backbone
2012-05-14 14:42:58 -04:00
Jeremy Ashkenas
080241a492
changing links to underscorejs.org
2012-05-14 14:42:23 -04:00
Jeremy Ashkenas
291bfadef6
Merge pull request #1307 from wookiehangover/issue1306
...
additional documentation for Model.clear
2012-05-14 09:18:35 -07:00
Brad Dunbar
192b1c0673
Events.off uses reverse iteration to avoid altering indicies.
...
See comments on 83a24bb2d5
2012-05-14 11:57:57 -04:00
Jeremy Ashkenas
cb50c10b47
adding scrollkit as an example site
2012-05-14 11:41:05 -04:00
Brad Dunbar
83a24bb2d5
Fix #1310 - off does not skip consecutive events.
2012-05-14 07:53:01 -04:00
Sam Breed
99072115ac
documenting model.clear's new behavior in the 0.9.0 changelog
2012-05-13 18:25:04 -06:00
Sam Breed
d14e8cf0d9
additional documentation for Model.clear
...
* specifies that the `id` attribute is removed
2012-05-12 00:37:42 -06:00
Jeremy Ashkenas
7d8c51a3c3
Merge pull request #1293 from wookiehangover/issue1292
...
Fix #1292 - unexpected results when passing undefined to Model.hasChanged
2012-05-10 14:55:01 -07:00
Jeremy Ashkenas
52c54d4c3e
adding a rel=canonical
2012-05-10 17:38:33 -04:00
vlad
d862436d2e
fixed broken fragment links to underscore proxy methods
2012-05-08 11:57:02 -04:00
Jeremy Ashkenas
c919568286
Merge pull request #1295 from braddunbar/refactor-preparemodel
...
Refactor _prepareModel.
2012-05-08 08:27:04 -07:00
Brad Dunbar
0ea9f47b35
Refactor _prepareModel.
2012-05-08 06:54:14 -04:00
Sam Breed
638af0f68e
updating model.previous arguments check to match hasChanged
2012-05-07 20:29:24 -06:00
Sam Breed
c3aed6f713
simplifying hasChanged if statement
2012-05-07 19:58:52 -06:00
Sam Breed
cacd01d530
Fix #1292 - unexpected results when passing undefined to Model.hasChanged()
...
* additional check in hashChanged for when `attr` is present but undefined
* adds tests for expected results when passing undefined
2012-05-07 19:45:03 -06:00
