I tried a couple of different OS version, and this one was the first
where Firefox 11 seems to connect correctly at least some of the time.
(To clarify: the tests were passing in Firefox 11 on all OS versions I
tried, but in most cases a connection error prevented Karma from
knowing this. I only know because I saw the reports in the Sauce web
interface.)
In Node 6, running Karma gave the following warning:
Error during loading "/home/runner/work/backbone/backbone/node_modules/karma-sauce-launcher" plugin:
Unexpected token function
I had no such error running karma after installing karma-sauce-launcher
locally in Node 14, so this upgrade might fix some things.
We are not exactly in the business of supporting old Node versions, so
this should be relatively painless.
If I understand the documentation correctly, it is not strictly
necessary that these variables be read from the workflow file; they
may also be read directly by the target processes.
Fixes#3882Fixes#4159
Backbone does a bit of extra work to determine when to update `_byId` on every model change event because `change:id` will not work if `idAttribute` has changed. This causes issues as the `change` event happens after every `change:` event which means during a change the `_byId` hasn't updated. Rather than adding complexity to collection the solution is to have the model notify with the id changes.
If adding a public event isn't desired, for an internal solution the model is aware of it's collection and could modify model.collection._byId directly within the set.
Either of these solutions seem preferrable to handling `change:[idAttribute]`
Replaces the need for:
https://github.com/jashkenas/backbone/pull/4227/files#diff-c773bb9be277f0f3f2baa308b6e0f3a486790fe99fea81ddd0ba409846250571R1205
